[08:06:08] yo o/ [15:20:43] mdholloway|brb: niedzielski: bearND: objections to rolling out production? [15:21:05] dbrant: none from me! [15:21:20] dbrant: 👍 [15:25:52] dbrant: none [15:47:31] dr0ptp4kt: I'm in the middle of the installation, I'm probably going to be late to the meeting [15:56:07] joakino: GOGOGO [16:12:59] dr0ptp4kt: I'm back for the meeting but having trouble getting in [16:17:23] mdholloway: bearND: re https://gerrit.wikimedia.org/r/#/c/291790, i'm ok to merge, but we'll need to coordinate the deploy as it needs a config change in ops/puppet [16:17:44] so if you have something in the pipeline that you want to deploy asap, would be better not to merge this one right away [16:19:36] mobrovac: does the coordination mean that you will do the deploy? [16:20:29] mobrovac: anyways, we'd like to get some new feed routes added and deployed by tomorrow, so your team can hook them up in RB [16:21:33] bearND: ok, so let's do it like this: i won't merge it now, but tomorrow morning and make sure it gets deployed with the config change [16:21:44] bearND: so you can deploy stuff today if you want to [16:23:11] mobrovac: sounds good to me [16:23:14] kk [16:24:11] 👍 [16:24:47] mobrovac: btw, here are the deployer notes we use: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/RESTBase_services_for_apps/Deployment_process [17:18:32] jdlrobson: my testing of the svg patch stalled as pageimages seems to not be returning anything for me on my local mwv [17:18:37] will update the task once i know more [17:18:50] okay. i'm investigating the class stuff you pointed out [17:18:52] it's very strange [17:25:22] dr0ptp4kt: I know yer swamped but can you swap your annual review with dbrant so that we can have a Web Process talk tomorrow? The latter is scheduled fer next Monday, which is a little brutal for us SF'ers. :) [17:39:18] HaeB: ah thanks, i left out the direct apk link by mistake [17:41:36] dbrant: no big deal ;) but i always look at it to glean the version number (to mark release dates in charts for the app's metrics) [17:45:04] jdlrobson: don't get lost -- raise a bug if necessary [17:45:12] but it's the first thing i noticed [17:45:17] (the patch itself looks fine) [17:59:34] maxbinder: done [18:11:20] jhobs: please can you push the patch you have so far for the Wikidata descriptions so we can take a look at the failing tests together? [18:24:41] phuedx: with regards to PageImages - might be related to non free images [18:36:44] jhobs: ? [18:38:21] jdlrobson: on a break for a little bit since meetings were all through lunch, I'll get it asap when I'm back [18:38:38] just hit `git review` with what you have [18:38:44] i have 30 mins and i dont know what to do with it [18:38:53] reviewing your patch would at least be something [18:42:04] jhobs: ? otherwise i guess im going to be forced into an early lunch despite not being hungry :) [18:43:25] jdlrobson: i'm not at the computer atm. I almost always have to work through lunch due to meeting timing so I tend to take a break sometime after or leave a bit early [18:43:43] jdlrobson: but yeah, I stepped out about 30min ago so I might not be back before your 30 minutes :/ [18:44:43] well please submit as soon as you get back - every minute we waste with starting review we're losing time to wrap that work up. [18:45:13] i guess i have to go for lunch now then. When Im back should coincide with you being back [18:47:08] yeah it's a bummer the task has no activity even though it was picked up about a week ago [18:47:32] maybe it's not a 2 pointer, should we re-estimate it? [19:38:51] Jhobs ping! Assume your back home. [19:39:33] Will take a look at your patch while I wait for this interview [19:40:50] Can you post it? [19:51:20] jdlrobson: https://gerrit.wikimedia.org/r/291976 [19:51:41] it's failing the first test because it doesn't find it for some reason even though I see it locally [19:51:59] and the second test fails because it doesn't properly go to the Nearby page [19:52:21] but I'm not sure why. I haven't looked at the failing tests too much today, like I said, I noticed it over the weekend and did mostly interview prep this morning [19:53:48] jdlrobson: whoops, forgot to attach the task [19:54:24] i'm looking. Anything involving Wikidata descriptions will fail on @integration tests [19:54:36] since our integration job doesn't include a Wikibase instance [19:54:49] jdlrobson: wait hold on, this patch has a mistake i fixed but must have done so in a different branch [19:54:53] lemme fix it again real fast [20:02:03] jdlrobson: interview ping [21:55:35] jdlrobson: realized I need to change it somewhere in the PHP as well; what's the method for getting the namespace in PHP (and page name)? vars['wgNamespaceNumber'] is not working [21:58:53] Help page on namespaces doesn't mention PHP variables for some reason :/ [22:08:10] nvm, I've found it [22:12:13] niedzielski: hey do you have a minute? [22:12:27] mhurd: sure [22:12:34] what's up? [22:12:35] niedzielski: bat cave? [22:12:40] omw [22:14:07] Jhobs Title::getNamespace I believe [22:17:50] am gonna take a look [22:19:02] jhobs: you can use mw.config to get the namespace number [22:19:07] in the front end [22:19:27] jdlrobson, bmansurov: look ^ for "nvm I found it" ;) [22:19:37] plus, I was asking for PHP, not frontend bman [22:19:54] sweet [22:24:57] jhobs: gonna take another pass [22:25:09] jdlrobson: jenkins fail appears to be a timeout [22:46:50] HaeB: hey you there? [22:47:00] hi [22:47:00] is there a page which lists wiki projects in order of traffic? [22:49:00] something like https://stats.wikimedia.org/EN/TablesPageViewsMonthlyCombined.htm ? [22:51:10] HaeB: yes.. but ordered [22:51:24] i am trying to work out which projects to roll out to [22:52:51] jhobs: do you remember the url for the wikidata instance on localhost? [22:52:55] finally have a working vagrant [22:53:45] jdlrobson: I was testing manually since this change shouldn't actually affect how anything is grabbed from wikidata, just when it shows [22:54:17] so I didn't set up a wikidata instance, I just hardcoded in the value that would be returned by it [22:55:01] i want to test with it to check the browser tests before unleashing them on beta cluster [22:56:40] yeah that table is *almost* ordered (i think the ordering was based on traffic at an earlier point in time but not updated when some languages overtook others). for a quick check it should still be useful [22:56:48] for top 6 you can also check https://reportcard.wmflabs.org/graphs/pageviews [22:56:53] other than that, not sure [22:57:26] of course it's not a lot of work to just run a query [22:57:31] mm http://wikidata.wiki.local.wmftest.net:8080/ fail [22:57:50] ill just manually sort that table then [22:58:01] thanks HaeB [23:39:46] jhobs: gonna take a look at the wikidata patch first thing tomorrow [23:39:53] my wikibase installation is b0rked