[09:37:26] morning [09:43:20] morning [09:56:54] morning [09:58:13] i've joined a gym 😱 [10:18:56] good for you :) [10:25:53] phuedx: I got the antenna today, will just pick it up at the post office. Is the documentation up to date? I'll start tonight/tomorrow, would be cool if it just works :D [10:35:18] phedenskog: the documentation is up to date [10:35:23] * phuedx crosses fingers [10:35:36] i await bug reports [10:36:20] * phuedx will be away for a little while [10:37:56] I'll send a PR if I find something [11:11:24] OPEN SOURCE!!! [11:11:43] 🙏 [11:27:41] phuedx: can you add your wmf email as a secondary address on gerrit? it's hard to remember what to type in the reviewers box when I want to add you :p [11:38:09] tgr: hah! of course [11:38:16] :p [11:40:25] tgr: done [16:00:38] joakino: is hangouts working for you for the hovercards meeting? [16:13:01] niedzielski: the Amazon App Store has rejected the app again, because of the Nearby bug (blank screen) :( I can't repro on my Fire tablet... [16:13:21] dbrant: yeesh [16:14:02] dbrant: looks like i uploaded the right version, so we got that going for us [16:15:12] dbrant: i'll check on my end. no crashing or logging reported in https://rink.hockeyapp.net/manage/apps/226649/app_versions/24 [16:18:45] niedzielski: i'll look in the logcat dump that they provide, as well [16:22:07] this headache is killing me [16:30:23] joakino: suck it up [16:30:40] seriously though, hope you feel better <3 <3 <3 [16:30:55] that's what I get for exercising [16:31:13] phuedx: you still on the highway? [16:31:19] yup [16:31:26] well [16:31:32] that sucks [16:31:35] we're in london now [16:31:36] is it rush hour? [16:31:43] there was an accident [16:31:56] four lanes of traffic moving at ~1 mph [16:32:16] classic phuedx [16:33:14] joakino: https://github.com/phuedx/popups-corpus [16:33:34] gonna mail the team in a second [16:37:35] cool.io [16:39:25] joakino: unbelievably surprised that that ^ is not actually a registered domain [16:41:56] haha [16:45:49] WAT [16:46:11] jhobs: it's camped [16:46:52] phuedx: ? [16:47:06] referring to your follow-on patch? haha [16:48:10] sorry, not camped [16:48:14] but it's on back order [16:48:44] http://nic.io/go/whois/cool.io [16:49:12] jhobs: you still only have +1? [16:51:17] ah that's what you meant [16:51:23] and yes phuedx [17:12:38] dbrant: do you happen to have an arm version of that api 15 emulator? [17:13:01] niedzielski: nope, it's x86 [17:16:45] dbrant: hm, in the logcat it says "EGL Version: 1.4" but the manifest requires version 2. maybe that's the issue? https://github.com/mapbox/mapbox-gl-native/blob/release-android-v4.0.1/platform/android/MapboxGLAndroidSDK/src/main/AndroidManifest.xml#L4 [17:17:17] i would think it would crash trying to get the config tho [17:17:45] dbrant: i was also wondering if it might be related to https://github.com/mapbox/mapbox-gl-native/issues/3985 [17:23:00] whoops, scratch that egl version business [17:23:28] dbrant: or this issue https://github.com/mapbox/mapbox-gl-native/issues/4779 [17:23:50] there's all these errors in the log: [EGL-ERROR]: egl_image* _egl_create_image_ANDROID_native_buffer(egl_display*, egl_context*, EGLClientBuffer, EGLint*, void*):593: CHUN try create image with crop 0,0,0,0 [17:26:57] niedzielski: well that's frustrating [17:26:59] Hi niedzielski and dbrant – fyi the Sketch file that the Zeplin spec is linked to was designed in 1x (360x640px) resolution while the Phone density setting in Zeplin was on hdpi, which threw measurements out of whack. I've just changed it to mdpi so correct style sizes etc should now be shown. [17:27:22] reets: thanks! [17:27:53] dbrant: i'm going to follow up on that latter ticket with some info and see if the mapbox folks know what's up [17:27:55] reets: very nice! [18:41:35] bearND: hey do you have a minute? [18:51:18] bearND: mdholloway: sorry about not reviewing the featured article patch in time - i added a comment to https://phabricator.wikimedia.org/T132764 [19:48:58] bmansurov: can you check the latest patch set? I'm eager to get it wrapped up. I also replied to your comment. [19:49:24] ok [19:52:29] jhobs: all good [19:53:53] bmansurov_break: sweet. I'm gonna head out now. Back/neck are really hurting and this chair isn't helping. Ping me on gchat if there are any emergencies during the SWAT [20:01:52] jhobs: cool, get well soon [20:07:20] mhurd_afk: no worries. I responded on the ticket. [20:21:56] kaldari: hey you're nick on the deployments page is wrong [20:22:12] oops [20:22:14] your [20:23:48] bmansurov: fixed :) [20:24:18] 👏 [20:31:12] mdholloway: oh i joined the hangout from the invite [21:13:14] bmansurov: https://phabricator.wikimedia.org/T135630#2351005 [21:13:58] looking [21:16:36] i'm going to swat deploy a fix, tgr [21:17:47] thx [21:20:00] tgr: i thought i figured out what was wrong, but i was wrong [21:20:16] tgr: seems like something is wrong with ResourceLoader [21:20:20] mw.loader.getState( 'ext.gadget.Navigation_popups' ) is returning null [21:20:27] even though the module is being loaded [21:20:37] tgr: or is it called something else in hungarian? [21:27:18] looks like it's called ext.gadget.latszer [21:28:01] bmansurov: yes, unfortunately gadget names are localized [21:28:38] tgr: ok, the quickest fix would be to use the localized name, but i'm thinking about more general approach [21:28:54] you can check for windows.pg [21:29:25] it's fragile due to race conditions, though [21:29:31] yes [21:30:16] or a particularly horrible hack would be to iterate through all RL modules and check if the URL matches MediaWiki:Gadget-popups.js [21:30:45] interesting [21:32:32] you could abuse the l10n system and have some message for the gadget name [21:34:26] tgr: you mean gadget module names are translated? [21:35:16] no, but you could just create a 'popups-gadget-name' message and ask on wikitech-ambassadors that people set it to the gadget name [21:35:35] tgr: ok, i suppose that would take a long time [21:35:49] and hope its the same on wikipedia, wikibooks etc :) so yeah, that's not a great idea [21:36:04] tgr: how about I wait until all modules whose names start with 'ext.gadget.' and wait until they are loaded? [21:36:14] normally wikidata is great for these things but I don't think they deal with the MediaWiki namespace [21:36:43] so I was thinking about loading all gadget modules and then enabling popups [21:36:56] maybe a bad idea [21:37:13] you can just push the check as late as possible (ie. just before displaying the popup) [21:37:35] yeah that maybe better [21:37:36] that way, the hovercards JS will be loaded unnecessarily, but no UX effect [21:38:20] and if you display some hovercards while navopups is still loading, that's a bit confusing but not a huge deal [21:39:22] tgr: that would mess up the event logging we have in place [21:39:43] so some bigger change is needed [21:40:33] for huwiki I would just go with adding 'latszer' to the blacklist, that's the least likely to have unexpected side effects [21:40:49] especially since you have one hour until the SWAT :) [21:41:19] ok [21:41:47] in general, I think using wikidata is neat if the WD community is up for it [21:43:38] iw-link the gadget definition pages (e.g. https://en.wikipedia.org/wiki/MediaWiki:Gadget-Navigation_popups ) to each other and that gives you the RL module name [22:01:17] tgr: cool thanks, i'll deploy the patch later today [23:22:40] bmansurov: does production hovercards remember the beta setting? [23:23:33] tgr: you mean when it's enabled for non-beta users?