[05:26:28] hey guys [05:26:45] i have some questions regarding wikipedia's android app [05:26:58] i want to know how it works ? how it saves pages for offline reading ? [05:27:10] does wikipedia android app uses's mediawiki API ? [05:55:55] arcade_: i think that's all MW api currently. we fetch the page and do transforms on the images to make them point to a local copy. you can check out some of the code here https://phabricator.wikimedia.org/diffusion/APAW/browse/master/app/src/main/java/org/wikipedia/savedpages/SavedPageSyncService.java [05:57:14] niedzielski-afk: what about the CSS and JS [05:57:24] afaik mw api does not provide css and js [05:57:30] it just provide body right [05:58:22] arcade_: we pre-package the css and some of hte javascript. https://phabricator.wikimedia.org/diffusion/APAW/browse/master/scripts/make-css-assets.bash [05:58:43] oh . [05:58:48] arcade_: a lot of the javascript is custom for android to make the page work well with native components [05:58:58] i am making something similar for wikitolearn but in qt [05:59:04] arcade_: https://phabricator.wikimedia.org/diffusion/APAW/browse/master/www/ [05:59:17] arcade_: neat! [06:00:39] thanks niedzielski-afk [06:01:06] arcade_: np! :) [06:01:54] niedzielski-afk: if you are interested you can see my codebase here : https://github.com/hackertron/W2L/tree/sub/storage [06:02:48] niedzielski-afk: cool! thanks! [06:07:29] one more thing , how have you implemented search feature ? [06:07:29] mw query parameter ? or something else [08:14:24] yo [08:28:15] hi! [08:51:36] joakino: are you around for the earlier swat window? [09:18:20] joakino: https://www.kickstarter.com/projects/1189548155/colborne-bota-how-wine-was-meant-to-be-carried [09:18:25] hipster bota? [09:20:40] phuedx: amazing [09:21:14] awesome to stay drunk all day [14:29:16] do I need to get https://gerrit.wikimedia.org/r/#/c/294036/ merged before the swat? cc dr0ptp4kt brion phuedx [14:29:36] is that the branch copy of the patch? [14:30:25] i could add some +s but it's my patch so :) [14:30:30] not sure if am suppsoed to [14:33:45] brion: I tested it locally and everything worked as expected, but I submitted so didn't want to score it [14:33:51] what do we do :p [14:34:07] hehe [14:34:50] so it needs to be merged before the swat window right? [14:37:07] no idea [14:37:10] well i'll bite [14:37:35] *pushed it* [14:37:39] the +2 button [14:38:02] haha, thanks brion [14:38:15] it's a short change, it shouldn't cause any troubles [14:59:30] whee [15:10:39] jhobs: fyi, for some reason i'm not getting a zero banner on mobile web today while on one of our test provider configs [15:11:12] jhobs: i'll phab it [15:12:35] mdholloway: thanks. Add me as a subscriber and tag dr0ptp4kt for priority [15:12:52] jhobs: will do [15:12:54] prioritization* [15:13:14] mdholloway: is the srcset fixed now? we just swatted [15:13:14] https://en.m.wikipedia.org/w/api.php?action=mobileview&format=json&noheadings=true&page=Cat&prop=sections%7Ctext%7Clastmodified%7Clastmodifiedby%7Clanguagecount%7Cid%7Cprotection%7Ceditable%7Cdisplaytitle%7Cthumb%7Cdescription%7Cimage%7Crevision§ionprop=toclevel%7Cline%7Canchor%7Clevel%7Cnumber%7Cfromtitle%7Cindex§ions=all&thumbwidth=640 [15:13:18] mdholloway: thanks for the heads-up [15:13:29] i see it fixed, just want to verify with app folk [15:13:39] joakino: i'll grab an iphone and test [15:13:57] https://www.irccloud.com/pastebin/MvLWUqNl/ [15:14:19] coreyfloyd: ^ is the srcset fixed now? we just swatted [15:14:19] https://en.m.wikipedia.org/w/api.php?action=mobileview&format=json&noheadings=true&page=Cat&prop=sections%7Ctext%7Clastmodified%7Clastmodifiedby%7Clanguagecount%7Cid%7Cprotection%7Ceditable%7Cdisplaytitle%7Cthumb%7Cdescription%7Cimage%7Crevision§ionprop=toclevel%7Cline%7Canchor%7Clevel%7Cnumber%7Cfromtitle%7Cindex§ions=all&thumbwidth=640 [15:15:17] thanks mdholloway [15:16:03] joakino: looking! [15:16:29] thanks! [15:16:43] joewalsh: can you also verify ^ [15:17:27] coreyfloyd looks like it's in there- should I verify with the current store ver of the app? [15:17:33] the mobileview on normal and mobile domains both have srcsets from my tests [15:17:35] diff <(curl -s [15:17:35] "https://en.wikipedia.org/w/api.php?action=mobileview&format=json&noheadings=true&page=Cat&prop=sections%7Ctext%7Clastmodified%7Clastmodifiedby%7Clanguagecount%7Cid%7Cprotection%7Ceditable%7Cdisplaytitle%7Cthumb%7Cdescription%7Cimage%7Crevision§ionprop=toclevel%7Cline%7Canchor%7Clevel%7Cnumber%7Cfromtitle%7Cindex§ions=all&thumbwidth=640" | grep -F [15:17:36] "srcset=\\\"//upload.wikimedia.org/wikipedia/commons/thumb/a/ae/AfricanWildCat.jpg/330px-AfricanWildCat.jpg 1.5x") <(curl -s [15:17:36] "https://en.m.wikipedia.org/w/api.php?action=mobileview&format=json&noheadings=true&page=Cat&prop=sections%7Ctext%7Clastmodified%7Clastmodifiedby%7Clanguagecount%7Cid%7Cprotection%7Ceditable%7Cdisplaytitle%7Cthumb%7Cdescription%7Cimage%7Crevision§ionprop=toclevel%7Cline%7Canchor%7Clevel%7Cnumber%7Cfromtitle%7Cindex§ions=all&thumbwidth=640" | grep -F [15:17:36] "srcset=\\\"//upload.wikimedia.org/wikipedia/commons/thumb/a/ae/AfricanWildCat.jpg/330px-AfricanWildCat.jpg 1.5x") [15:17:50] sorry for the spam [15:18:41] joakino: so far so good. I'm mobile - in line at WWDC [15:18:59] joakino: but no problems in the app so far [15:19:16] awesoemee [15:19:20] if the iOS guys say it's working i'll defer to them ;) [15:19:36] thanks all [15:22:22] joakino: Joe also says it works [15:22:52] nice, thanks coreyfloyd joewalsh [15:22:59] joakino: thanks for getting this out [16:35:45] You never know what you might find in the street in SF https://usercontent.irccloud-cdn.com/file/B4wXhKfE/1465835700.JPG [16:40:00] lol [17:01:41] joakino: phuedx standerp [17:01:43] coreyfloyd: LOL nice [17:01:57] coreyfloyd: who is that BUM? [17:28:01] dr0ptp4kt: is there a YouTube link for the next meeting or are you not anticipating the hangout to hit capacity? [17:31:24] jhobs: i don't think we'll hit capacity [17:34:54] dr0ptp4kt, mdholloway: http://earthsideband.com/ [17:34:57] nzr: i'm quite not sure about what to make with https://phabricator.wikimedia.org/T135430#2371876 , does that mean that you are ok with the last change that the gif shows, or not? :p [17:35:05] thx phuedx! [17:35:41] joakino: i am okay with it but not happy :) we keep not pushing for better solutions for technical reasons. [17:35:59] we don't push for better solutions for technical reasons [17:36:33] nzr: in this case I think it is a matter of perf team members and others preferring imitating the browser rather than a custom ux for lazy loaded images [17:36:56] as you know i like better the custom ux, i'm just following what it says on the task [17:37:20] if you think we need to discuss more that change, I'm happy to split it up to another task [17:37:38] phuedx: thx! [17:39:04] i'm just not sure how to proceed, don't want to submit the change if it's not going to get design signoff [17:41:18] nzr: ^ just give me a 👍 or if it's not good to signoff by design then 👎 and I'll split that last change to a followup task and ping the appropiate people for discussion :) [17:41:55] joakino: sure. [17:42:05] thanks! [18:02:22] dbrant|brb: niedzielski: looking at feed coordinator now [18:03:48] mdholloway: cool, no rush :) [18:43:00] niedzielski: manual rebase :( https://gerrit.wikimedia.org/r/293556 [18:43:11] dbrant: on it [23:00:19] \o bmansurov just taking a look at your patch [23:02:41] jdlrobson: o/