[07:45:38] o/ phuedx [07:46:14] so the mw.router doesn't seem to be a drop in replacement of MF.router, Special:Nearby doesn't work, possibly others too [08:25:50] morning y'all [08:26:05] bmansurov: is that because of missing module dependencies or because mw.router isn't a thing? [08:26:39] phuedx: morning, it's mw.router being a little different from mf router [08:26:40] oh no [08:26:42] i see it [08:26:49] phuedx: luckily it was a small fix [08:27:01] aude's saying that there's also a difference in behaviour [08:28:05] bmansurov: which editor do we cover with acceptance tests? [08:28:23] "skins.minerva.editor" didn't depend on mediawiki.router but the tests still pass? [08:28:36] welcome to mf tests [08:28:44] or is mediawiki.router being loaded elsewhere [08:28:52] and we were lucky [08:29:05] snark welcome, answers more welcome ;) [08:29:41] i suppose so, as all modules are loaded on one page [08:34:04] good morning! [08:35:07] ok -- the wikitext editor isn't broken [08:35:11] (just checking…) [08:35:14] hey hashar [08:35:27] I was looking at the missing mediawiki.router issue for MF [08:36:05] what puzzles me is that MediaWiki has a test to verify resource loaders dependencies have all dependencies (afaik) [08:36:12] (speaking of https://gerrit.wikimedia.org/r/#/c/294649/3/extension.json,cm ) [08:36:34] but maybe in the test context, the mediawiki.router is available [08:37:06] anyway, if you want to deploy it today anytime, let me know I will be happy to assist / do it [08:37:21] ^ bmansurov, joakino [08:37:28] i see that the patch has just been merged [08:37:30] so… [08:37:31] now? [08:39:26] hashar: i've merged the master patch and tested locally the one against wmf6, both look good [08:39:39] i'm happy to verify the deployment if you want [08:39:50] sounds like a plan [08:39:55] is that testable on beta cluster? [08:40:25] it was merged 5 min ago [08:40:26] maybe http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Nearby [08:40:35] not sure if it is still on the beta cluster, let me check [08:40:57] we can force run the jenkins job that update the beta cluster ( https://integration.wikimedia.org/ci/view/Beta/ ) [08:41:03] it is on a 10 minutes schedule iirc [08:41:15] hashar: it should be testable on the beta cluster [08:41:15] whatever you feel is best [08:41:23] it'll trigger in 5 min more if not [08:41:31] I am force building https://integration.wikimedia.org/ci/view/Beta/job/beta-code-update-eqiad/ [08:41:35] cool [08:41:39] 👍 [08:42:13] for the context, I was the one pushing .6 yesterday [08:42:32] aude created the task and we quickly talked about it [08:42:53] then I eventually I got distracted and been too tired to call a rollback :/ [08:43:29] 00:00:03.242 From https://gerrit.wikimedia.org/r/p/mediawiki/extensions/MobileFrontend [08:43:30] 00:00:03.242 b3cfee8..051c92a master -> origin/master [08:43:34] kay [08:44:05] phuedx: for the editor, one of the dependencies already was depending on mw.router, so it never threw an error. [08:44:30] my Firefox on Linux doesn't have location bah " Try an open area with a better signal. " [08:44:36] I am next to the window! [08:44:43] hrm still not working http://en.wikipedia.beta.wmflabs.org/wiki/Special:Nearby [08:46:10] ^ verified [08:47:19] phuedx: does it work for you? [08:47:25] not on my phone [08:48:10] iPhone 6, iOS 9.3.2 [08:48:13] hrm this worked http://en.wikipedia.beta.wmflabs.org/wiki/Special:Nearby?debug=true [08:48:44] prod mode works, debug mode doesn't, wat [08:49:40] phuedx: seems to work now [08:49:46] can you check on your phone? [08:50:32] joakino: working fine /cc hashar [08:50:43] caching issue? [08:50:45] resourceloader caching? [08:50:49] yeah, seems like it [08:51:41] alright, everything seems fine hashar [08:52:01] http://en.wikipedia.beta.wmflabs.org/wiki/Special:Nearby or http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Nearby [08:52:26] debug=true works on my phone too [08:52:45] oh RL caching [08:52:50] I have no clue how to clean it up (: [08:52:51] :( [08:53:28] hashar: it seemed to clean itself in a couple of minutes [08:53:31] works fine now [08:55:08] so we can +2 the .6 one and swat it :) [08:55:36] 👍 [08:55:36] will ask ops [08:56:35] err s/ask/notify/ [08:56:40] * joakino joins [08:56:49] cause we never know :] [08:58:42] joakino: phuedx should I handle the prod deploy or would you like to do it ? [08:59:10] hashar: i believe i have permissions but i'm super-rusty but i'm happy to help verify [08:59:15] don't look at me, i don't have access yet [08:59:35] i really need to learn... [09:01:12] I am going to share my screen over hangout with zeljko [09:01:13] https://hangouts.google.com/hangouts/_/wikimedia.org/amusso-zfilipin [09:01:17] feel free to join :) [09:02:26] ^ AWESOME [09:25:00] ok [09:25:02] that was cool [09:25:08] Kudos !! [10:18:11] aude_: Special:Nearby is fixed. Thank you for all the investigation yesterday! [11:22:27] taking a break [11:22:33] (i've been on one for about 15 minutes [11:22:34] ) [11:49:16] back [13:03:52] phedenskog: i've just read your issue about modprobe [13:04:00] after a little reading it looks like you're right: http://dummdida.tumblr.com/post/117157045170/modprobe-in-a-docker-container [13:24:20] out [15:15:36] bmansurov: congrat on the Nearby patch :) [15:15:52] nzr: you able to make the meeting in two hours in that meeting i set with phedenskog and (not on this channel) krinkle and joakino ? [15:15:56] bmansurov: we have ended up deploying it ~ six hours ago and phuedx / joakino confirmed the fix on prod [15:16:18] hashar: thanks? but you guys did the most of the work to get it to prod. [15:16:33] the others did :D [15:16:41] hash [15:16:51] I just invited everyone in a hangouts, did CR+2 and ran git pull && scap sync-dir extensions/MobileFrontend [15:16:53] hashar: i was expecting to do a swat but it already has been wooo [15:17:04] amazing [15:17:13] yeah I think it was serious enough to land it asap [15:17:24] eventually we talked about opening a SWAT window during european mornings [15:17:31] I have reached to rest of Releng team about it [15:17:36] hashar: that'd be awesome [15:17:40] I guess [15:17:55] only reading team patches will be swatted hehe [15:17:56] WMDE / Wikidata folks can probably use a window that better accomodate with European times [15:18:05] oh them too [15:18:16] ultimately, you guys would handle the swat :] [15:18:35] good opportunity to learn [15:18:59] yeah [15:19:20] and we need to demystify deployment. it is pretty much straightforward nowadays [15:19:50] freeing up time to carefully look at logs / monitoring etc and prepare for a rollback (which can be done in a few seconds) [15:19:53] stay tuned! [15:20:17] cool, i will [15:39:32] dr0ptp4kt: yep [15:41:29] nzr: thx [15:46:59] bearND: hey, what do you think about removing the /media and /mobile-summary routes from the mobile content service repo? those seem like we're maintaining dead code [15:47:49] bearND: possibly also /mobile-text, though not sure about that one [15:54:41] bmansurov joakino you guys got https://phabricator.wikimedia.org/T135539 covered? [15:54:49] bmansurov: joakino i just emailed on it [15:57:23] mdholloway: Hmm, I could go either way. Not sure if we're still considering adding an infobox to the link preview. The media route might be a good one to build up later. Let's see what dbrant says about mobile-text. [15:58:05] bearND: mdholloway: remove it :.( [16:10:27] dr0ptp4kt: I haven't talked to joakino yet, but I think we'll get to the bottom of this soon. [16:12:20] sure [16:33:34] phuedx: aha [16:33:56] mdholloway /cc bearND dbrant: o/ hello! I was going to address your comment in review but realized the other devs might want to pitch in. I called the Content Service Retrofit service cache CsCachedService because I wanted to keep pushing the idea that the Content Service isn't just for mobile devices. It's really confusing to me as a client to thi [16:33:56] nk of it that way and makes me think I should prefer MW API on desktop. There is no Desktop Content Service. Can we drop "Mobile" from the name? [16:37:23] niedzielski: bernd and i are in a meeting, chat with you shortly! [17:02:34] phuedx: joakino standup [17:09:43] niedzielski: hmm, yeah. that's an interesting point: on one hand, if the desktop site found a use for the service, it would be great! on the other, the justification for the existence of this service as i understand it is to support the mobile platforms. [17:10:00] it gets a bit philosophical, i guess. i'd be curious to hear what others had to think. [17:12:39] https://phabricator.wikimedia.org/project/board/67/query/W8dSOcTA8KFd/ [17:15:35] dr0ptp4kt: did you want to babysit the afternoon SWAT of the wikidata descriptions config change, or should I schedule it for next week? [17:16:10] I would do it but I have something I absolutely cannot move :/ [17:56:46] i'm outtt [18:08:44] mdholloway: niedzielski-afk : In general I'm not thrilled with the current name, same for mobile-sections endpoint name. Maybe something with reading or read in the name would be better? In this particular case however I wanted to use the generic RESTBase name since some endpoints might be provided by other teams, e.g. the summary endpoint is currently [18:08:44] maintained by the services team, although that might change in the future. [18:15:57] jhobs: i can babysit, but is it *only* a config change? is there no code waiting for a train or anything like that? [18:16:32] jhobs: or is all of the stuff generally SWAT'able [18:16:34] ? [18:16:52] jhobs: the point is i'm fine either way, just want to make sure i know what to look for [18:17:21] dr0ptp4kt: there is code merged atm waiting for a train [18:17:31] jhobs: today's train? [18:17:32] dr0ptp4kt: the config change needs to be SWATted [18:17:36] no, tuesday [18:17:59] dr0ptp4kt: We could SWAT on Tuesday instead if you want [18:18:02] jhobs: so what does the config do? is the point it needs to be SWAT'd today so things start taking effect tuesday? [18:18:20] bearND: since this is about the the content type, you could perhaps also use something that doesn't match the entry point name; this is especially relevant for featured page / news / * entry points, where the same format might be used for several entry points [18:18:26] jhobs: could there be any adverse effects in swat'ing tonight? [18:18:41] dr0ptp4kt: the config change enables wikidata descriptions in beta labs. If we do it now, it'll be available as soon as the train rolls. If we wait for the train, it'll be enabled whenever we SWAT. [18:18:58] dr0ptp4kt: I don't believe so, but there's also not much harm in waiting [18:19:05] it's really just a matter of velocity at this point [18:19:40] bearND mdholloway: thanks, that sounds good to me. i'll change CS to RB since this cache just uses RB service factory [18:21:18] dr0ptp4kt: why don't we just wait for Tuesday. I'll be able to babysit it then anyways [18:22:48] jhobs: wfm [18:30:18] jhobs: i should ask, though, is this going to overinflate sprint points materially? [18:30:35] dr0ptp4kt: how do you mean? [18:31:03] jhobs: like will there be points carried over that will make us have to trim cards from the next sprint? [18:31:37] dr0ptp4kt: Technically, yes, I suppose. [18:31:40] dr0ptp4kt: i mean, we can split out the deployment to a new task if you want. (Spoiler alert: it'll be a 1-pointer) [18:32:38] ok....jhobs, i'm totally cool with babysitting tonight in that case - would you please line it up on the swat calendar for tonight? given that it's confined to beta labs where master is already running, seems easy [18:34:04] dr0ptp4kt: ok, will do. I //believe// to verify it you'll have to log in to beta on beta labs since the patch to move to stable won't have ridden the train yet [18:34:41] dr0ptp4kt: or simply check the config variable is set properly (which you should be able to do with mw.config.get() in a JS console) [18:40:28] dr0ptp4kt: I put the diff to the deployment wikipage in the task and pinged you so you can see the patch from there. Thanks for covering the SWAT! [18:47:43] bearND dbrant mdholloway: would anyone mind if i rename PageActivity to MainActivity since it'll be hosting at least the FeedFragment soon? [18:48:35] niedzielski: hmm. no objection in principle, i suppose. [18:48:54] +1 [19:21:45] +1 [20:02:05] yo jhobs, the mw.config.get('wgMFDescription'); should be easy enough, but is there a page on en.m.wikipedia.beta.wmflabs.org where i would expect to see the wikidata description when stuff is SWAT'd? [20:03:01] maxbinder: jhobs you guys in the hangout? [20:03:18] dr0ptp4kt: you won't see it yet because the code won't have hit the train yet. Unless beta labs has a beta on top of it [20:03:32] dr0ptp4kt: and if it does, I'm not sure of a specific page, sorry :/ [20:03:35] maxbinder: jhobs oh right, meeting hasn't started yet [20:03:38] maxbinder: one second [20:03:47] jhobs: the beta cluster gets whatever's merged into master [20:03:53] er... that was meant for dr0ptp4kt not maxbinder haha [20:04:14] dr0ptp4kt: oh it's not in group0 like testwiki? [20:04:20] jhobs: nope [20:04:40] jhobs: generally, once stuff is merged into master it should be on the beta cluster in something like 30 minutes iirc [20:04:48] 10 [20:04:50] dr0ptp4kt: ooooooooooh well then yeah you should be able to test it. I'm not certain of a specific page though, sorry. I'll do some looking around. [20:04:59] but yeah, there's a jenkins job that updates the beta cluser [20:05:08] what!? phuedx !? [20:05:15] dr0ptp4kt: i got confused by the whole "beta cluster" vs "labs" vs" beta mode" vs "staging" vs "test wiki" [20:05:18] phuedx: maybe you know what page i could check? [20:05:41] (once the change is swat'd)? [20:07:15] phuedx: ok, looks like albert einstein will work. genius. cc jhobs [20:07:19] and thx jhobs [20:07:30] albert einstein [20:07:40] claude monet used to be khammerstein's test page of choice [20:11:25] jhobs: working on a tweak to cachedpages.sh [20:11:41] and now that i'm free, i'll submit a screenie of the cached page too [20:12:38] phuedx: thank you! [20:31:11] rebuilding my primary mwv instance on my laptop [20:31:15] bye bye bandwidth [21:06:53] jhobs: https://gerrit.wikimedia.org/r/#/c/294838/ something to ponder [21:08:43] out [21:35:05] bmansurov: updated: https://gerrit.wikimedia.org/r/#/c/293883/2 [21:35:23] cool [21:36:51] thanks bmansurov and dr0ptp4kt, i'm off [21:37:02] later