[07:57:49] yo / [07:57:53] o/ even [08:32:02] put a pinch of cinnamon in my omelette this morning [08:32:05] delish [09:22:03] joakino: yt? [09:22:08] or are you eating ice cream [09:22:10] ? [09:25:17] nm [09:45:41] i wonder if anyone reads our js docs [12:48:52] o/ i was just looking at them last night! [12:48:56] phuedx: ^ [12:51:05] jdlrobson: what was the reason for hiding coordinates on mobile? [13:05:46] Volker_E: i don't know for sure but I think they have inline styles with nowrap that break the layout [13:05:57] not sure if that is the reason though [15:09:59] joakino: is the patch back on reading-web-staging? [15:10:20] dr0ptp4kt: just sent an email about that haha [15:10:23] 2quick2fast [15:10:25] yes [15:10:28] joakino: ah, ok...one moment [15:10:32] dr0ptp4kt: http://reading-web-staging.wmflabs.org/wiki/Elvis_Presley?mobileaction=beta [15:10:40] joakino: er a few moments [15:10:44] i haven't been able to find anything [15:10:49] seems to work fine for me [15:10:50] sure, no problem [15:10:57] it'll be there all day [15:11:29] joakino: what's the current state of user styles/scripts on mobile/in Minerva? (talking to community member) [15:12:30] i can't remember, i don't think userjs or css are enabled [15:12:42] i think commonjs and css ended up being enabled though [15:15:52] joakino: The only thing I've found about was https://gerrit.wikimedia.org/r/#/c/168815/ [15:17:05] Volker_E: yeah, that changed later though, that patch predates me in wm too [15:17:21] current code seems to just forbid common.js and common.css https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/modules/MobileUserModule.php [15:18:57] Volker_E: jdlrobson changed kaldari's impl, he would know more about why https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/commit/bb70e28226f21c4139bf8ec1b0997fd44860d7e3 [15:19:37] i've heard that those js and css scripts usually break the mobile web experience since they predate minerva, and people were filing bugs related to them when they forgot what they were doing [15:19:37] joakino: so i'm streaming music, and i'm saying to myself "why does it keep breaking up?!@" [15:19:55] joakino: and then i say to myself, "oh yes, throttling the network connection will do that" [15:20:02] haha [15:20:07] classic [15:20:30] happens to me too, why is mw-vagrant taking 2 minutes to load all the resourceloader modules [15:20:44] "oh, I forgot i was throttling" heheh [15:26:11] joakino: phuedx i no longer see the reflow. i commented as much on https://phabricator.wikimedia.org/T137874 [15:26:50] dr0ptp4kt: wohoow [15:27:04] self-fixed bugs are the best kind of bugs [15:49:47] Volker_E: hey [15:50:05] user styles/scripts are all possible on mobile [15:51:45] but not common scripts [15:51:56] they need to be in minerva.js or mobile.js [15:52:11] (since as joakino points out many are incompatible with the mobile experience) [15:52:29] jdlrobson: when are they loaded? [15:52:34] at bottom? [15:52:37] bottom yup [15:55:18] joakino: i'm aiming to reschedule our web planning meetings earlier in the day with jkatz and nzr and maxbinder and CKoerner_WMF and moushira when she can make it. does 9 am sf time work for you in general? [15:56:57] joakino: if there's some way to make it even slightly later, we'll get a better timeslot, but i need to check with the office admins to see what's possible [15:59:55] dr0ptp4kt: 9am 👍 [16:00:02] joakino: thx [16:01:16] dr0ptp4kt, maxbinder: gonna join the afternoon grooming but not the early one today [16:03:52] 👍 jhobs [16:31:48] dbrant: i'm still getting the same backstack behavior with the because you read card interactivity patch, even on the latest patchset [16:31:59] i'm charging up a different phone to see if it's android-version specific [16:32:38] mdholloway: hmm, what are the exact steps? and what's the API level of the device? [16:33:08] it's API 23 [16:33:32] i click a list item to go to an article, then click back and i go to the previous page in the backstack rather than back to the feed [16:34:05] continuing to click back just takes me further back in history [16:34:43] mdholloway: ah, i see! If the PageFragment already had a nonempty backstack of its own, then this would be the case. [16:35:11] mdholloway: if you Back out all the way, do you eventually make it back to the feed?> [16:35:24] dbrant: i'll test [16:36:20] mdholloway: this behavior will be a little trickier to get right. It might need to be handled in a subsequent patch. [16:38:54] dbrant: yep, looks like i do eventually get back to the feed once the page backstack is empty [16:39:16] dbrant: i'm ok leaving refining this until later [17:02:14] phuedx: standerp [17:17:40] bearND: standup time! [17:19:45] mdholloway: omw [17:36:36] mdholloway: you're handling sos today, right? [17:36:44] dr0ptp4kt: yep, i'm there [17:40:47] mdholloway: thx [17:46:58] dr0ptp4kt: pretty quiet this week with wikimania [19:09:01] dbrant: bearND: we don't have any mocks showing what an 'in the news' card will look like, do we? [19:09:33] this endpoint looks like it won't be too tricky to write, but the card and endpoint tasks are kind of underspecified [19:10:35] mdholloway: kaity's original design had a mock for 'in the news': https://app.zeplin.io/project.html#pid=56b3ef430f64a4eb0f1b9d27&sid=571529f2c7312f087aab1b4d [19:11:21] dbrant: aha, thanks [19:12:50] mdholloway: so, ideally, the endpoint would provide the full text of the news item (as written on the main page), plus a list of wiki links parsed from the news item. [19:13:07] dbrant: so, from https://en.wikipedia.org/wiki/Template:In_the_news, I could do something like take the four list items, scrape the page links from them, and return them in plaintext along with a set of page title/desc/summary/thumbs? [19:13:16] ah, ok [19:14:14] mdholloway: or rather from Template:In_the_news, instead of the main page [19:16:41] dbrant: so, for instance, 'In basketball, the Cleveland Cavaliers defeat the Golden State Warriors to win the NBA Finals.' [19:16:43] right? [19:16:55] and the others [19:17:10] or just the one? [19:17:30] mdholloway: yep, the others, too [19:18:02] the other thing is that this doesn't appear to be pegged to a date the way, say, the featured article is [19:18:42] so it might have to be one that comes with the aggregated content but then we don't provide additional copies of as we go back in time [19:18:50] and the endpoint wouldn't include a date [19:19:06] looks like it's just updated as stuff happens [19:20:53] mdholloway: hmm that's true, so we'll only be able to have feed cards for 'current' news, not older news [19:21:07] still not bad, though [19:21:29] dbrant: yeah, i think that's reasonable [19:31:20] joewalsh: i'll be there in a minute or two [19:31:32] dr0ptp4kt: no prob [19:32:53] mdholloway: dbrant : are we still doing grooming or am i in the wrong room? [19:33:16] bearND: er, omw [19:52:53] bearND: i'll take one quick look again. probably good to merge. [20:02:36] bearND: not sure if you saw, but looks like it needs a rebase [20:04:01] mdholloway: yes, i saw that. should be done shortly [21:07:44] anyone coming to grooming? [21:08:26] ^ jdlrobson, dr0ptp4kt, bmansurov? [21:08:57] jhobs: i'm not [21:09:11] jhobs: coming [21:12:48] jdlrobson: jhobs and i decided to cut it short. my mic wasn't working, plus we're a bit short of people today