[05:13:45] o/ [08:15:12] o/ [09:18:26] morning [13:29:47] dbrant: o/ so i just noticed this morning that the 'random' cards in the mocks are different than i expected [13:30:55] as in, don't actually use any random content but essentially act as a link to load a random page in PageActivity [13:33:04] mdholloway: ah yes; actually, got a quick second for batcave? [13:33:18] dbrant: sure, will find headphones and be there in a moment [15:00:23] dbrant: i thought your toolbar overlay patch would depend on the support library upgrade, but looks like it doesn't [15:00:41] mdholloway: nope, i found an even more correct xml attribute to use. [15:00:51] dbrant: if we need it, i can see about upgrading to JDK 8 on the ci machine, otherwise it can probably wait [15:00:56] dbrant: ah ok [15:01:13] should upgrade ci soon any for consistency's sake, i suppose [15:01:44] yeah, probably better if ci uses the latest jdk anyway [15:04:42] dr0ptp4kt: spetro? [15:04:52] bmansurov: si [15:04:54] jdlrobson: phuedx, jhobs ^ [16:58:48] joakino jdlrobson bmansurov jhobs phuedx start without me. meeting going longer [16:59:07] dr0ptp4kt: 👍 [16:59:10] ^ ditto for jdlrobson and I atm [16:59:24] jhobs: 👍 [18:28:36] mdholloway: (i've asked Rita for any nonstandard vector assets used in the card mocks) [18:30:54] mdholloway: i'm having a bit of trouble testing your patch for the Featured Article card... i'm running the latest content service locally, but not getting the card to appear in the app [18:31:23] dbrant: i'll take a look [18:42:47] dbrant: oh, i think it's having trouble deserializing the aggregated response because we're now sending a full random response rather than a placeholder string. i'll do a quick patch. [18:43:04] cool [18:46:31] dbrant: ok, the new PS should work [18:49:04] dbrant: actually, we probably don't want to send a random card summary in the aggregated response if the random card is going to be static. but we can change that later. at least now the patch is in sync with the service. [18:49:28] yep, that's fine [20:11:22] mdholloway: alright, the meat of the TFA card looks good to me; If you agree that any design tweaks can come in a later patch, I'm ready to merge. [20:11:42] dbrant: merge it! [21:08:50] bearND: that's the second time in as many hours that i've gotten a 504 in content service CI for no obvious reason :( [21:09:40] mdholloway: hmm, that's really strange. I was wondering why the tests would fail after a simple change like this [21:10:35] mdholloway: i do remember seeming 504s locally when running the test, while my machine was super slow. I think those are simply timeouts [21:11:26] i think i got that when I was running the nagios checker script, which also tests the Swagger spec, inside the VM [21:12:23] bearND: ah, i see. if it keeps up, maybe we'll have to bump up the timeout limit. [21:13:18] mdholloway: great work on the 'in the news' endpoint! [21:13:28] bearND: thanks! :)