[10:14:55] <hashar>	 I have broke the apps-android-wikipedia-* jobs 
[10:15:02] <hashar>	 working on porting them to Jessie and Java 8
[11:44:17] <dr0ptp4kt>	 joakino: phuedx either of you there?
[11:50:50] <dr0ptp4kt>	 tgr: you there?
[11:54:23] <dr0ptp4kt>	 joakino: phuedx i understand you're on vacation...sorry to bug you. just thought i'd see if you or tgr would be able to troubleshoot https://phabricator.wikimedia.org/T138578 and work with greg-g to do a deploy to fix
[11:58:06] <hashar>	 apps-android-wikipedia-* jobs  should be fine now. Reverted back to Trusty/Java 7
[11:58:24] <hashar>	 (context was https://phabricator.wikimedia.org/T138506 )
[14:03:12] <dbrant>	 mdholloway: o/ so, is our CI not working now?
[14:03:27] <mdholloway>	 dbrant: what's your vote for what i pick up next: in the news card or main page card?
[14:03:31] <mdholloway>	 dbrant: yeah it's busted
[14:03:54] <mdholloway>	 dbrant: but all of the projects are more broken and hashar is helping with that so i was waiting for that to play out before i bug him
[14:04:40] <dbrant>	 mdholloway: let's get the main page card out of the way...
[14:05:14] <mdholloway>	 dbrant: sounds good
[14:05:19] <dbrant>	 mdholloway: and I can add interactivity and design tweaks to the TFA card.
[14:23:12] <hashar>	 mdholloway: good morning.  I am having a quick break/pause right now. Will come back in a few minutes :
[14:23:13] <hashar>	 )
[14:23:40] <mdholloway>	 hashar: sounds good! talk to you in a few minutes :)
[14:23:51] <hashar>	 twist: java 8 works :)
[14:24:25] <mdholloway>	 excellent
[14:44:23] <hashar>	 mdholloway: so
[14:44:41] <hashar>	 mdholloway: sorry took longer than expected.   This morning I have hacked a bit / sprinted toward having Java 8
[14:45:14] <hashar>	 we now have java 8 on the Jessie slaves. I eventually found out the -test and -lint jobs needed some android sdk to be installed though the jobs were not automatically installing android sdk
[14:45:35] <hashar>	 so I have fixed that (each job now ask the android-emulator to detect the target platform and install the sdk)
[14:45:36] <hashar>	 BUT
[14:46:01] <hashar>	 the way the Jenkins plugin works is that it looks for a property "platform" in either of  default.properties or  project.properties
[14:46:12] <hashar>	 which are the maven standard files as I understand it
[14:46:32] <hashar>	 the android apps using gradle, the file does not exist and the plugin skip installing 
[14:47:04] <hashar>	 the workaround I found is https://gerrit.wikimedia.org/r/#/c/295893/  
[14:47:17] <hashar>	 namely copy pasting the version given in gradle via  android.compileSdkVersion  
[14:47:30] <hashar>	 and add it in a dummy project.properties file solely to please the Jenkins plugin
[14:47:45] <hashar>	 not sure whether that compileSdkVersion is the proper one to refer to but that seems to work just fine
[14:48:15] <hashar>	 so I guess I can rebase my patch to use the previous sdk (23),  migrate to Jessie
[14:48:41] <hashar>	 then you can rebase your patch ( https://gerrit.wikimedia.org/r/#/c/295674/1 ) and have it change the sdk version in the project.propeties files and it should pass just fine
[14:49:26] <mdholloway>	 hashar: ok!  all of that sounds good
[14:50:01] <hashar>	 the wall of text above is a summary of my morning hacking session :-}
[14:50:05] <mdholloway>	 hashar: the other problem we're seeing is that currently is this: ERROR: JAVA_HOME is set to an invalid directory: /usr/lib/jvm/java-8-openjdk-amd64 -- will this be resolved in the course of the above changes?
[14:50:11] <hashar>	 ohh
[14:50:22] <hashar>	 in the Jenkins configuration page ?
[14:50:40] <mdholloway>	 that's in the console output in the failing test results
[14:50:55] <hashar>	 mind linking to a console showing that ?
[14:51:01] <hashar>	 it is definitely on the Jessie slaves
[14:51:02] <mdholloway>	 https://integration.wikimedia.org/ci/job/apps-android-wikipedia-test/2930/console
[14:52:20] <hashar>	 eek
[14:52:27] <hashar>	 yeah looks like I broke it
[14:52:46] <hashar>	 lets me  do the switch to jessie java8
[14:57:50] <hashar>	 switching jobs to Jessie
[14:57:56] <hashar>	 then I will send the couple patches rebased
[14:58:47] <mdholloway>	 hashar: sounds good!
[15:04:41] <hashar>	 mdholloway: I have switched the jobs to Jessie and reordered/fixed the patches
[15:04:49] <hashar>	 one introduce the project.properties with target=23
[15:04:54] <hashar>	 the other is your patch rebased on top of it
[15:05:10] <hashar>	 the only change to your patch is to bump  target=24  in project.properties
[15:05:15] <hashar>	 hopefully they are both going to pass
[15:05:28] <mdholloway>	 hashar: ok!  looking now
[15:11:51] <mdholloway>	 hashar: \o/
[15:11:52] <mdholloway>	 merging
[15:12:09] <hashar>	 https://integration.wikimedia.org/ci/job/apps-android-wikipedia-test/2933/consoleFull
[15:12:14] <hashar>	 Compilation API android-23 missing. Downloading...
[15:12:14] <hashar>	 :D
[15:12:16] <hashar>	 it is magic
[15:13:01] <hashar>	 I will let you mark https://phabricator.wikimedia.org/T138506 as fixed :-}
[15:13:26] <mdholloway>	 hashar: will do.  thanks so much for your help!
[15:16:03] <hashar>	 mdholloway: and probably want to announce the java8 switch somehow :}
[15:17:12] <mdholloway>	 hashar: good point.  i'll put a quick note to mobile-l on my todo list
[15:19:09] <mdholloway>	 cc'ing ops probably wouldn't hurt
[15:46:55] <mdholloway>	 dbrant: should i do a quick patch to explicitly require java 8 in app/build.gradle (along the same lines as we used to require java 7)?
[15:59:42] <dbrant>	 mdholloway|biab: any reason that would be necessary?
[16:01:41] <dbrant>	 wouldn't the user see a message from the Android SDK that it requires java 8?
[16:08:29] <mdholloway|biab>	 dbrant: i haven't tried to build with the wrong java version in a while so i'm not sure how cryptic the output is.  if it's not obvious what the problem is at first, an explicit message might save some head-scratching.  but if that's the case, hopefully we'll hear about it!  
[16:09:15] <dbrant>	 mdholloway|biab: isn't that the message we saw when first trying to upgrade to 24.0.0?
[16:12:03] <mdholloway|biab>	 dbrant|brb: yep -- i didn't spot it then (and still don't see it; it's not in the console output for the failing PS) -- what build log were you looking at?
[16:12:42] <mdholloway|biab>	 (heading out now, back in a bit for real)
[16:32:23] <dbrant|brb>	 mdholloway: https://integration.wikimedia.org/ci/job/apps-android-wikipedia-test/2903/console
[16:33:34] <mdholloway>	 dbrant|brb: odd -- earlier output was more cryptic and i didn't bother reading subsequent failures: https://integration.wikimedia.org/ci/job/apps-android-wikipedia-test/2899/console
[16:34:05] <dbrant|brb>	 mdholloway: that's when it was still in the process of downloading the updates
[16:35:02] <mdholloway>	 dbrant|brb: i see
[16:35:11] <mdholloway>	 no need to change build.gradle then
[18:29:01] <Krenair>	 jdlrobson, I think if Greg is not around but you need to make an emergency fix you should just do it
[18:29:20] <jdlrobson>	 Krenair: i don't have SWAT rights so I'd need a deployer as well :/
[18:29:24] <Krenair>	 maybe run it by chad or tyler or reedy or someone
[18:29:30] <Krenair>	 oh, which change is needed?
[18:29:39] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/295958/ < Krenair 
[18:30:39] <Krenair>	 is adywiki really using legacy stuff?
[18:33:27] <Krenair>	 hm, apparently so
[18:33:33] <jdlrobson>	 id="mp-topbannerleft" < Krenair 
[18:33:39] <Krenair>	 yep
[18:34:38] <Krenair>	 Okay so this is effectively reverting the new wikis to the state they were in just a few days ago, so should be safe
[18:35:13] <MaxSem>	 jdlrobson, get permission in #releng and I'll deploy
[18:35:29] <jdlrobson>	 MaxSem: am trying :)
[18:35:38] <jdlrobson>	 MaxSem: thanks for volunteering though. I really appreciate it.
[18:35:45] <jdlrobson>	 i'll fix up that diff patch in return today :)
[18:36:23] <Krenair>	 already doing
[18:36:44] <jdlrobson>	 Krenair: thanks. Let me know if I can repay the favour by helping you with any reviews/bugs :)
[18:37:22] <Krenair>	 no worries, I don't expect any personal favours for this
[18:38:31] <jdlrobson>	 i hope my gratitude is enough :)
[18:53:05] <hashar>	 jdlrobson: hello! looks like you got the MF bogus transformation sorted out and deployed ? ( https://phabricator.wikimedia.org/T138578 )
[19:01:02] <jdlrobson>	 hashar: yup thanks to Krenair :)
[19:01:47] <hashar>	 awe
[19:02:02] <hashar>	 jdlrobson: out of curiosity arent you familiar with deployment to be able to swat it ?
[19:02:56] <jdlrobson>	 hashar: im not SWAT trained. Initially it was because I was a frontend dev and there were concerns about the PHP aspects of it, then I was a little concerned if I had SWAT rights it would distract me more than I am already :)
[19:05:25] <hashar>	 jdlrobson: sounds fair :-}
[19:05:47] <hashar>	 jdlrobson: for what it is worth, we are having discussion about opening more SWAT windows and level up a wide range of folks
[19:06:00] <hashar>	 ultimately even PHP illiterate (like me ) and frontend devs should be able to swat stuff 
[19:06:09] <hashar>	 (that is the theory / idea on the paper)
[19:06:33] <hashar>	 anyway, good to see Krenair stepped in to assist in pushing ;-}
[19:08:02] <dbrant>	 mdholloway: bearND: can we get some reviews in, before we close out? ;)
[19:08:20] <Krenair>	 Just like with +2 rights, I think deployment rights for people who only usually deal with JS is fine as long as they don't deploy things they're not confident in, and are extra careful with anything not in their area
[19:19:02] <mdholloway>	 dbrant|brb: yep, i'll look your new stuff over shortly
[19:19:35] <mdholloway>	 i've just about got your comments on Random card pt. 1 addressed
[19:19:42] * mdholloway is interested in learning to SWAT
[19:23:15] <hashar>	 mdholloway: looks like a lot of people are  :-}  phuedx and joakino definitely are
[19:23:41] <hashar>	 releng is quite busy with a bunch of other stuff, but we are already discussing a way to open it up 
[19:23:51] <hashar>	 the trick is to not make it discouraging for folks to join in
[19:24:38] <hashar>	 so we need a lightweight process, and make sure experimented people are around for a few months to level up everyone
[19:24:47] <hashar>	 then ideally, one day, everyone will be able to swat ;-}
[19:25:15] <mdholloway>	 hashar: bearND and i talked some with thcipriani about it at the Reading department offsite.  it sounds like nerves of steel are a requirement :) 
[19:26:08] <Krenair>	 experienced people?
[19:29:20] <hashar>	 Krenair: I meant : "people that already crashed the site once, and are used to monitor logs, rollback, and know who to ask to help" :d
[19:30:01] <hashar>	 mdholloway: yeah Tyler told me so this week. And he wrote a nice summary of floating ideas.   releng has weekly meeting on Monday, we will definitely talk about it
[19:30:36] <hashar>	 I myself deploy stuff barely knowing what the code is actually doing (if at all)
[19:30:48] <hashar>	 but in such a case, I will make sure I have a couple of others that knows
[19:31:02] <hashar>	 and take the responsibility of monitoring, babysitting until everything is green \ OK
[19:31:37] <hashar>	 I see myself as the guy that enter a heated room and stating "dont worry, I get your back" 
[19:33:05] <mdholloway>	 :)
[19:34:58] <mdholloway>	 dbrant|brb: good news: got your comments addressed pretty quickly; bad news: the asynctask threading issue seems to have resurfaced (it showed up while testing the revision)
[19:38:08] <mdholloway>	 dbrant|brb: (in the interest of avoiding rebasing a million times, i'm thinking i'll just import the icons for both static cards as part of the main page card patch)
[19:41:14] <mdholloway>	 bearND: i'm +1 on dbrant's outstanding patches from yesterday, do you want to look them over or are you ok with me bumping those up to +2 now?
[20:05:56] <bearND>	 mdholloway: you can +2 them if they are ready