[08:21:35] o/ [08:24:55] morning [08:31:30] o/ joakino [09:40:41] ugh [15:33:07] jdlrobson: is the meeting over? [15:33:39] jhobs, joakino, phuedx [15:33:40] ? [15:33:48] bmansurov: yep [15:33:48] bmansurov: yeah [15:33:55] we've finally merged it [15:34:08] oh ok [15:34:28] bmansurov 👍? we can block and change stuff if necessary [15:34:29] joakino: mail the list would ya [15:35:30] joakino: yes, sounds good [15:40:37] phuedx: devscript looks good besides the lack of error check like you mentioned. I'd be down to do a pairing session to see what was the difference between our machines like you described [16:03:15] dbrant: o/ thanks for the review! on the PNG vs SVG issue, i initially went for the SVGs but android studio was complaining about the format and refusing to import. have you run into this? [16:08:24] joakino: sprint planning [16:09:33] mdholloway: hmmm, yes indeed, AS can't seem to import these SVGs, and even the online tool that Stephen found isn't doing a good job of it. :( We'll have to ask Rita how she's exporting these things, and if there's some kind of compatibility options that can be applied. We'll have to resort to raster images for now, though. [16:09:53] these really aren't complex SVGs, either :( [17:17:46] maxbinder: standerp? [17:31:53] dbrant: whaddya say? work on the main page/random icons or start on the 'in the news' card? [17:32:35] heading off for lunch. Also have to move locations so I may be a bit long, but I'll be sticking around late today anyways for the SWAT deployment(s) [17:37:05] mdholloway: in the news [17:37:37] dbrant: ok! [19:22:20] dbrant: have you tried running the svgs through inkscape? (e.g. you can open, rotate and rotate back, save) [19:22:41] bearND|afk: yep, tried all of that :( [19:23:15] dbrant: that's strange. bummer [19:26:33] mdholloway: mind if I amend your patch (with new vector assets)? [19:26:45] dbrant: nope, go for it! [19:51:52] jhobs: are you around? [19:52:02] im having trouble working out what happened to descriptions [19:52:03] jdlrobson: what's up [19:52:11] Did you SWAT any changes recently to change config values? [19:52:11] jdlrobson: wanna hangout? [19:52:14] sure [19:52:27] in TI [20:51:41] lol England [20:59:33] jdlrobson: https://gerrit.wikimedia.org/r/#/c/296281/ [21:00:24] jhobs: looking [21:00:39] jdlrobson: also, I always forget how to do this; do you know how to make one patch depend on another in a different repo? I'll need to make the corresponding mw-config patch depend on this one [21:01:33] jhobs: i'd advise not renaming the existing config variables. That's a breaking change and there may be other extensions unexpectedly relying on it. [21:02:06] I'd suggest renaming them in a follow up [21:02:10] and only SWATing the new variable [21:02:13] jdlrobson: hmm... ok. We should make a follow up task tho [21:02:16] yeah, sounds good [21:02:25] best to minimise potential to go wrong in SWAT :) [21:02:27] because they're super confusing with the existing names [21:02:46] looks good though. I'll give it a test [21:03:02] jdlrobson: yeah I wasn't able to test it because vagrant won't provision so I can't add wikibase :/ [21:03:08] (by all means do it now... but I'm suggesting you may want to SWAT in 2 patches or leave the 2nd to a normal deploy) [21:04:20] right [21:04:35] jdlrobson: can you answer my question above (under your comment "looking")? [21:04:57] jhobs: just add the change id [21:05:01] doesn't matter if in different repo [21:05:14] ok great, thanks [21:07:42] and looks like it works :) [21:07:50] lemme know when it's split up and i'll review again [21:07:54] gonna grab a coffee [21:11:12] jdlrobson: reduced the first patch to just the new variable, working on the follow-up now [21:20:50] minor nitpick [21:20:56] "MFDisplayWikibaseDescriptionsAsTaglines" shouldn't that be Tagline singular? [21:21:42] I also think the commit message could be clearer. I would suggest "Introduce config variable to control tagline" [21:21:51] and then use the rest of the commit message on the follow up [21:21:59] ^ jhobs [21:22:26] bbiab [21:22:45] ok [21:24:17] jdlrobson: I'm not sure it should be singular. The config variable determines if wikibase descriptions should be used as taglines on an entire wiki, so multiple pages [21:24:37] I think the UI one should be plural as well [21:38:22] ok. Please change commit message though :) [21:49:01] jdlrobson: yeah, I did [21:51:38] jdlrobson: do you think it's enough to modify https://gerrit.wikimedia.org/r/#/c/296242/ to include the necessary changes and make it depend on the MF patch to reduce the necessary SWATs from 3 to 2? Or should I explicitly create a different patch? [21:52:11] jhobs: do them separately and linearly [21:52:19] never mix SWATs. you increase the probability of more failure [21:52:39] alright [21:52:41] change as little as possible per commit - just as you would in the codebase [21:52:42] it also makes it easier to revert [22:05:41] jdlrobson: just to confirm, I've properly made this patch (https://gerrit.wikimedia.org/r/#/c/296345/) depend on this one (https://gerrit.wikimedia.org/r/#/c/296281/)? [22:07:59] jhobs: taking a look [22:08:11] because it doesn't look like it... [22:10:52] jhobs: add Depends-On: Idb747699ebbba3e40100f697848cc10a980f1f0a to commit message [22:12:29] jhobs: ill be back at 4pm - just popping to dentist [22:12:50] jdlrobson: alright, have a good one [23:11:18] dr0ptp4kt: you around? urgent [23:21:18] jhobs: what's up? [23:21:34] jdlrobson: nvm, resolving [23:21:46] jdlrobson: i'll catch you up in a minute, but I gotta finish something real quick [23:22:20] k as long as you've got it under control :) here if you need [23:33:16] jdlrobson: yep under control, Dereckson is being a huge help over at -ops