[00:42:15] jdlrobson: to catch you up, the changes weren't merging into gerrit due to an abandoned change for some reason, but Dereckson got us all sorted out. I've confirmed the UBN fix working on production enwiki. The deploy of wikidata taglines to cawiki & plwiki is working as expected on cawiki, but plwiki is one branch behind due to a rollback and will catch up [00:42:15] on Thursday. I'm gonna send out an email/update the appropriate phab threads after I get some dinner [00:42:20] ^ dr0ptp4kt [08:20:48] o/ [08:58:27] moarning [15:27:19] jhobs: thx for dealing with it. after 6 pm central, please feel free to call me on my cell. [15:28:26] Ok thanks dr0ptp4kt [15:30:47] mdholloway bearND|afk joakino coreyfloyd leads in 3 mins [15:31:10] dr0ptp4kt: i'm not feeling very well, i'm writing my standup status email and I'm going to rest the rest of the day [15:31:37] joakino: sorry to hear that! get well soon! [15:33:36] * mdholloway acknowledges [17:02:15] jdlrobson: standup [17:02:47] nzr: able to make standup? [17:02:54] yeah [17:02:58] dr0ptp4kt: yeah [17:03:03] nzr: word [17:12:08] dbrant: reets: hello! i'm looking at the 'in the news' card in the current feed mock, and it looks like hyperlinked text for each story is boldfaced on the card, and the intention is for clicking that boldfaced text to open the linked page in the article view (PageFragment). is that correct? [17:18:49] mdholloway: yep, that would be correct. In your current endpoint implementation, do you return the text of the news item with the links intact? [17:19:24] nope, i was just about to say that if that's correct, i'll make a quick change to the mcs to stop stripping the html from the story text [17:23:18] mdholloway: yep, let's go with that [17:31:20] tgr: coming? [17:56:08] mdholloway: merging your change to not strip out HTML. When you get a chance please look at https://gerrit.wikimedia.org/r/#/c/296266/. [17:56:37] bearND: aha, thanks and will do! [18:11:00] hi mdholloway: ahh, yes the hyperlinked text is bolded on the card, however the intention is that each news item card is a single tapable object that opens up a full screen view of that news item with each hyperlinked article in a list [18:11:29] mdholloway: you can see this on a 4th screen called "In the news - full screen item" in the zeplin [18:13:44] reets: aha, i see. thanks for clarifying! [18:17:10] mdholloway: no worries, happy to jump on a hangout if you need more info &/ assets. Oh and dbrant: I am looking at a way to convert svgs to VectorDrawables; else can also export them to pngs in all the sizes. [18:35:23] dr0ptp4kt: omw [18:51:49] mdholloway dbrant bearND: o/ o/ o/ there's not anything i _shouldn't_ merge into the android app, right? (i'm catching up on code review.) everything not marked with a WIP in the android repo is mergeable? [18:52:13] niedzielski: correct! [18:53:50] dbrant: great :) thanks! [19:07:14] reets: i think, if we're going to squeeze 'in the news' into our mvp, we might have to forego the full-screen popup of the news item. How about navigating directly to the articles from the news item text, for now? [19:21:04] mdholloway: ^ [19:43:15] dbrant: 👍 [19:50:23] dbrant|brb: shall we discuss on hangout tomorrow? Great news that this can get into MVP but I would suggest going with a simpler single news item with list of article links below (similar to Kaity/Nirzar's original design) if the full-screen pop-up is not doable initially. [21:05:37] mdholloway & tgr would you please update https://etherpad.wikimedia.org/p/Scrum-of-Scrums ? [21:21:17] bearND mdholloway: are tests in the content service master broken? [21:22:53] niedzielski: not on my end -- try 'VCR_MODE=record npm test' [21:23:17] dr0ptp4kt: will update in a minute [21:23:58] mdholloway: works. thanks :) [21:24:17] niedzielski: np! [21:24:59] niedzielski: I usually remove the fixtures folder when I run into unexplainable test failures [21:25:29] bearND: yeah, i think i might need to be more mindful of the caching [21:32:52] reets: is there any way i can import the newspaper icon thingy from the in the news card mock? doesn't seem to be importable [21:40:28] reets: ...and i see an update! [21:40:28] mdholloway: I just updated the Zeplin with the "In the news" icon svg asset. Still investigating how to make VectorDrawables if these svgs are still glitchy... [21:41:16] mdholloway: hah yes! my last for the night though :) [21:41:55] reets_afk: thank you! [23:44:35] reets_afk: dbrant: the 'in the news' icon svg imported successfully!