[07:44:03] morning [08:20:35] yo [08:20:37] o/ joakino [08:22:37] i haven't heard from phedenskog recently [08:22:40] o/ phedenskog [08:48:48] :) [09:21:52] phuedx: for "Run browser tests on beta cluster from desktop domain" https://phabricator.wikimedia.org/T130429 [09:22:15] phuedx: the @ cucumber tags are still referencing the .m. mobile domain but the suite has been changed to point at the desktop domain [09:22:28] and cucumber happily filters out all tests as a result :( [09:40:24] hashar: i thought that might be the case [09:40:28] i did ask on the change [09:47:45] hashar: is it the change to this file? https://gerrit.wikimedia.org/r/#/c/296418/4/tests/browser/features/switch_views.feature,cm [09:47:53] i commented about the "en.m" but it was merged [09:55:31] hashar: this? https://gerrit.wikimedia.org/r/#/c/296703/ [10:05:15] phuedx: sorry was looking at something else [10:05:26] yeah something like that [10:05:55] then maybe some other browser environment might still use the .m. version [10:06:09] at least the job that triggers on patch proposal still runs some tests ( https://integration.wikimedia.org/ci/job/mwext-mw-selenium/7658/console ) [10:06:37] tough that job only rely on the @integration tag [10:08:03] phuedx: I am creating a dummy jenkins job [10:08:30] ah [10:08:31] https://integration.wikimedia.org/ci/job/selenium-MobileFrontend-T130429/ [10:08:31] T130429: Run browser tests on beta cluster from desktop domain - https://phabricator.wikimedia.org/T130429 [10:08:37] that is a copy paste [10:08:44] with a hack to fetch & checkout a Gerrit patch [10:11:31] phuedx: ideally we would want the job https://integration.wikimedia.org/ci/job/selenium-MobileFrontend/ to accept a change # / patchset [10:11:39] and magically fetch that if needed [10:11:51] https://integration.wikimedia.org/ci/job/selenium-MobileFrontend-T130429/4/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/console [10:11:52] T130429: Run browser tests on beta cluster from desktop domain - https://phabricator.wikimedia.org/T130429 [10:12:30] invalid cookie domain: invalid domain:"en.wikipedia.beta.wmflabs.org" [10:14:30] *sigh* [10:14:55] yeah that is never ending :/ [10:16:07] hashar: we've added a step that doesn't set a cookie but clicks the "mobile view" link [10:16:13] we could use that step rather than setting a cookie [10:16:26] (actually an acceptance test and less brittle) [10:55:44] hashar: hrrm. that's the log_in helper that's failing rather than an mf-defined step :/ [10:55:48] is that chrome-specific? [11:05:12] phuedx: https://integration.wikimedia.org/ci/job/selenium-MobileFrontend-T130429/4/ is the build and the firefox one has the same cookie error :( https://integration.wikimedia.org/ci/job/selenium-MobileFrontend-T130429/4/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/consoleFull [11:05:12] T130429: Run browser tests on beta cluster from desktop domain - https://phabricator.wikimedia.org/T130429 [11:27:00] phuedx: hey! [11:27:47] I'm here trying to finish up my things before vacation, let me know if there's something I can help with [11:29:20] no no [11:29:28] just making sure that you're still alive :D [11:32:09] hashar: that error message is really unhelpful [11:32:25] i'd like to know which domain the browser is on and which domain the cookie is being set on [11:32:37] user-friendly error messages! [12:37:11] lunch [14:32:10] mdholloway|biab: merged [14:32:31] mobrovac: thanks for the heads-up and thank you for merging! deploying now. [14:32:41] kk thnx for the quick response [15:54:49] nzr: would you please join the meeting in 10 minutes? [15:55:13] nzr: i suspect we'll have design questions. i started adding some stuff to phab for sprint 76 related lang switcher tasks already [16:05:25] dr0ptp4kt: jdlrobson jhobs joakino I'm in the hangout [16:05:29] maxbinder phuedx: joakino jdlrobson jhobs andy of you able to establish a connection to the hangout? [16:05:32] er [16:05:35] maxbinder: beat me to it [16:05:49] https://hangouts.google.com/hangouts/_/wikimedia.org/estimate-q1-web [16:05:53] coming [16:06:10] dr0ptp4kt, maxbinder: can't connect, probably due to http://mashable.com/2016/06/30/google-calendar-hangouts-down/#szdmpVOupgqo [16:06:19] jhobs: maybe [16:06:26] let me try to create a new hangout [16:06:29] dr0ptp4kt: do we have a static connection url? [16:06:33] ooop [16:06:41] hang on, now it looks like it may work [16:06:53] er, no maybe not [16:07:05] I'm still stuck [16:07:50] maxbinder: joakino phuedx jhobs bmansurov nzr jdlrobson please try tracy island [16:07:56] ok [16:08:15] dr0ptp4kt: need a link to that [16:08:36] maxbinder: see gchat [16:08:46] tarcy works [16:08:49] tracy [16:09:18] https://phabricator.wikimedia.org/T137932 [16:16:50] maxbinder: did y'all get my decline note? [16:16:55] i've only just got back from group [16:17:02] phuedx: yup, godspeed with dinner [16:17:11] and currently trying to feed a teething 1.5 year old [16:17:13] <3 <3 <3 [16:17:19] more use of the word "godspeed" plz [17:00:54] phuedx: we are in tracy island, join us there when you are done godspeeding [17:04:52] maxbinder: i can't access tracy island [17:05:13] phuedx: hangouts is experiencing issues today [17:05:19] but i can access the standerp hangout [17:05:36] wait wait [17:17:54] dbrant: good to meet in 10? [17:18:07] maxbinder: yep [17:29:34] phuedx: okay to adjust your browser test patch? [17:29:43] i want to fold in the reverted code [17:34:43] phuedx: did it anyway - https://gerrit.wikimedia.org/r/296703 - let me know if you want me to take over debugging today [17:41:19] so am i all lonely again today? :/ [17:51:29] jdlrobson: i'm here! [17:55:32] jdlrobson: on https://gerrit.wikimedia.org/r/#/c/296355/7, what's the reasoning for including unit tests in a separate patch and not in that one? [17:59:28] im less happy with it [18:01:26] niedzielski: o/ [18:01:41] niedzielski: the days are getting lonely in sf. I think I need to move. [18:01:53] jdlrobson: I'm not sure what you mean by that (if it was directed to me) [18:02:16] the, "im less happy with it" comment, that is [18:02:25] jdlrobson: what about those couches on the fifth (?) floor? you should instead just move your belongings into the office and live there [18:02:55] jhobs: im less happy with the unit test patch [18:02:57] i want to think it over some more [18:03:23] jdlrobson: ok, although I don't think the two should be exclusive. I'll comment on the patch [18:03:33] just wanted to hear your reasoning first [18:11:48] mdholloway: manual rebase plz https://gerrit.wikimedia.org/r/295970 [18:17:40] dbrant: on it [18:26:22] 'git review --force' -> 'No changes between HEAD and origin/master. Submitting for review would be pointless.' [18:26:43] is there a way to find the console output for the gate-and-submit job? [18:26:56] (that's after rebasing) [18:27:16] did you commit --amend ? [18:28:11] i haven't committed anything since last time, just git pull --rebase origin master [18:28:33] s/last time/PS8 [18:28:59] hmm, batcave? [18:29:07] dbrant: sure [18:30:56] dbrant: hold on, lemme try one more thing [18:43:24] jhobs: im confused. Are you wanting code review for https://phabricator.wikimedia.org/T138788 or still working on it? [18:43:53] (maybe i misunderstood you in standup) [18:44:42] jdlrobson: yeah I think you misunderstood, the next patch set will be drastically different, so no point in reviewing yet [18:44:52] k [18:44:54] I'll move it to code review when the new one is up [18:59:58] mdholloway: the news card looks freakin sick. [19:00:34] dbrant: thanks! :D [20:07:44] jdlrobson: gonna join us for grooming? [20:13:10] jhobs: will join now