[00:04:09] MaxSem: sad that I missed this one: http://www.theregencyballroom.com/events/detail/306311. It's already sold out. [00:14:23] kaldari, replace with http://www.oaklandmetro.org/event/250237 [00:16:22] that's a lot of metal :) [10:01:47] this is sick and insane at the same time singlediv.com [15:09:59] o/ does anyone know much about the MobileAppHooks class in the MobileApp repo? we have a volunteer contribution to enable the commons app and uploads but i'm not sure what the implications are /cc mdholloway bearND dbrant [15:10:02] https://gerrit.wikimedia.org/r/#/c/298458/1 [15:11:10] niedzielski: Yeah, I was going to look at that one over the weekend. [15:11:35] niedzielski: this is for automatically tagging edit revisions with a tag of "mobile app edit" [15:11:48] (based on user-agent) [15:12:20] I am not sure about implications but it looked reasonable, just that setting up to review it might take some time [15:13:26] You can find out more about MW hooks in the mediawiki docs, or from the web folks on this channel I'm sure [15:13:47] I'm no expert [15:16:12] dbrant mdholloway: hm, so maybe a good test is to change the user string of the app to Commons/* and make an edit locally. then verify the revision history shows "mobile app edit" [15:48:07] dbrant mdholloway: so the edit part checks out. i think upload might be a bit trickier to check [15:49:16] niedzielski: mdholloway: we'll definitely need additional input from (at least) mobile web devs to check the correctness / implications of this change [15:50:12] dbrant mdholloway: yeah. i think i'll just try using mw api directly rather than an app for the upload [15:52:40] niedzielski: dbrant: i just resuscitated my mw-vagrant instance yesterday, so i can play around with it too. but first, is there anything else that needs to be done on the app side for feeds, or are we just waiting for the public endpoints now? [15:53:09] aside from final design cleanup, just endpoints. [15:53:32] design cleanup = rita's email? [15:53:41] speaking of which, i'll whip up a couple phab tasks from Rita's email [15:53:43] ^^ [15:53:46] dbrant: cool [15:56:54] bmansurov: can you edit in piotr's task? [15:57:16] no [15:57:27] no UI [15:57:37] i was able to create new items though [15:57:43] using the browser's console [17:01:25] jdlrobson: hi :P Want to take a look at https://gerrit.wikimedia.org/r/#/c/298040/1 ? :D :P [17:01:57] FlorianSW: gimmee 15 mins - just in a standup :) [17:02:26] ok :) Have fun! :) [17:02:37] (you shouldn't write e-mails when in a stand up ;)) [17:02:43] * irc messages [17:02:45] phuedx: joakino stand-arp [17:02:52] FlorianSW: any interest in React.js btw? I'm rebuilding MobileFrontend in it for funz with some real time data to make it fun if you are interested in contributing :) http://trending.wmflabs.org https://github.com/jdlrobson/weekipedia [17:04:09] dr0ptp4kt: trying to joinโ€ฆ still trying [17:33:22] mdholloway: niedzielski: bearND: I made some phab tasks based on final design feedback, at the top of Product Backlog. Feel free to pull! [17:33:44] dbrant: sweet [17:33:46] ๐Ÿ‘ [17:36:58] Thanks [17:41:49] dbrant: niedzielski: bearND: have you noticed that it seems possible "outrun" card loading if you scroll down aggressively in the feed, and the content for one or more days can be skipped? [17:42:19] mdholloway: i've noticed it's easy to outrun the loading. i'm not sure about skipping days [17:42:22] o_O haven't seen that [17:43:05] i've replicated a couple of times now, thought there might be a deserialization error but it doesn't seem so [17:43:46] yep, i can reliably skip from today to July 11 :/ [17:43:47] mdholloway: iirc, some of the clients only allow one request in flight at a time [17:43:53] it's probably just cancelling the old request [17:44:41] niedzielski: yeah, i'd believe that. this doesn't strike me as a blocker or anything but in 2.0 it might be good to block subsequent requests while one is in flight [17:45:38] mdholloway: i agree. that'd be a good phab to have [17:45:53] * mdholloway goes off to write it up [17:46:35] ๐Ÿ‘ [17:50:01] dbrant: based on the latest round of feedback, i'm wondering if an unplanned mvp tag would be valuable. it might be interesting to track, when we cut some cards at the start of an epic, how many additional cards are spawned by the end [17:50:22] just a thought. obviously not a big deal right now and something we can always change later [17:51:48] dbrant: i'm going to move T137504 above T137573 on hte workboard. i forgot yesterday that it's a parent [17:51:49] T137573: [Dev] Authentication tests are failing - https://phabricator.wikimedia.org/T137573 [17:51:49] T137504: [Dev] Remove old AuthManager code - https://phabricator.wikimedia.org/T137504 [17:52:55] niedzielski: good idea! i'll make a note to bring up with Max when he gets back [17:56:59] niedzielski: dbrant: bearND: actually, i think it's a little worse than that -- content isn't being skipped but it's being tagged with incorrect dates because age is being incremented with each scroll [17:57:32] i'm trying to make a screen recording but i've never actually done that on my phone so trying to find the best way to do that [17:57:48] hmm, will try to repro [17:58:00] mdholloway: sounds like a concurrency issue to me [17:58:10] yeah [17:58:30] mdholloway: here's one way: adb shell screenrecord --bit-rate 8000000 /sdcard/foo.mp4 [17:58:50] there's also a free app from wharton called telecine in the play store [17:59:01] ah, nice, i figured there had to be a native way [17:59:32] i went for telecine but i've somehow failed at two attempts to use it so far [17:59:49] (naturally, i didn't bother R'ing TFM if there is one) [18:06:20] when rebasing a fat set of patches, the following command works well: git rebase -x 'gradlew checkstyle aDD' origin/master [18:08:37] niedzielski: nice :) [20:04:01] lol, that turned out to be easier to fix than to document [21:36:07] bearND: i just filled out the form and got access to the tools project -- would you mind seeing if 'mholloway' is available now (or whenever you get a chance)? thank you! [21:36:57] mdholloway: yes, I gor you in now. //cc: niedzielski [21:37:03] got* [21:37:16] bearND: cool, thanks! [21:38:39] bearND: i submit to you and the form [21:53:28] @mdholloway I'm looking at T140084 and checking your QA instructions, but I see no way to turn off location permissions for a particular app including Wikipedia Alpha, I checked this on both Samsung Galaxy SIII and ZTE phones [21:53:29] T140084: [CRASH] Nearby crashes after the user selects to deny or allow location permission - https://phabricator.wikimedia.org/T140084 [21:54:54] nicholas-tsg: oh, now that you mention it, permission adjustment is a feature added in the latest Android version (6.0 Marshmallow). do you have any Marshmallow devices for testing? [21:55:42] nicholas-tsg: sorry i gave you instructions that couldn't be followed on earlier versions [21:56:01] thanks I have Galaxy Express 3 which is a Marshmallow I'll try testing that [22:37:11] niedzielski: access granted [22:38:44] bearND: thanks :)