[12:53:36] is gerrit down? [12:54:03] yes [12:54:10] outage ongoing on the server hosting it [15:50:33] @mobile apps team :P Are you planning to work on https://phabricator.wikimedia.org/T130622 any time soon? :/ [16:06:18] joakino: coming to planning? [16:07:28] FlorianSW: internally we've discussed disabling installing on external storage altogether, and everyone seems in favor of it, we've just not made the change yet. /cc niedzielski dbrant|brb bearND [16:08:33] mdholloway: oha, that isn't a really great news :( What are the reasons? The fix for this task doesn't seem as complicated as I thought (currently I would start up my AndroidStudio again, after a long long time, and trying to fix this problem). [16:08:38] FlorianSW: the background is in https://developer.android.com/guide/topics/data/install-location.html#ShouldNot . we use accounts, sync adapter, widgets, services, and technically shouldn't allow the app to be installed on external storage. [16:08:47] We might be seeing weird bugs because of this. [16:09:48] FlorianSW: newer devices allow users to "adopt" an sd card which makes it appear as internal storage [16:10:08] niedzielski: i'm actually a little worried something is broken with logins, perhaps on the mediawiki side. were you testing against testwiki? [16:10:31] mdholloway: no, should i have been? [16:10:45] niedzielski: i ran into the same badtoken issue, i just don't think it's caused by the change in https://gerrit.wikimedia.org/r/#/c/299265/ [16:11:05] niedzielski: i'll try again on master, it's probably more important than what i'm working on now [16:11:22] niedzielski mdholloway but (maybe I misinterpret the storage thing), installing on the sd card or not, shouldn't prevent us from saving things (like saved pages, without any private data) to the sd card? [16:11:34] As this is boundled with a permission, not with the installation location? [16:12:38] niedzielski: i generally test against testwiki just because i don't want to pollute the production wiki user db, but it's probably not a huge issue [16:13:24] mdholloway: oh, i was just logging in [16:14:28] niedzielski: was the stack trace you pasted from a test? the resolution for that is in another patch [16:14:32] FlorianSW: hm, AFAIK we currently try to keep everything within the app folder so if you delete the app you delete the app files. I think you can request external storage for specific files though and still get an app folder on the SD card so maybe you're right that this is still doable. [16:14:34] "your princess is in another castle" [16:15:20] mdholloway: no that was actually just from logging in the normal way [16:15:30] niedzielski: using getExternalFilesDir() acts as getFilesDir(), except that the files are saved on an external memory, it get's removed if the app is uninstalled, too. [16:15:36] mdholloway: i tried our latest release and that seems to work [16:16:08] FlorianSW: then that sounds doable! :) [16:16:17] FlorianSW: yeah. it's probably possible to fix, just wanted to give you a heads-up just that the issue might be moot. [16:16:56] mdholloway: no worries :) thanks for the news :P [16:17:15] FlorianSW: i think i'll change the wording on the ticket to clarify this is more about controlling the location of saved pages via a _setting_ rather than where the app is installed since installing the app on sd may no longer be permitted [16:17:24] niedzielski: ok, I try to fix it (let's see what my android development knowledge can) :P [16:17:29] niedzielski: FlorianSW: it's probably worth creating a phab ticket for discussion about disabling installation on external media [16:17:47] mdholloway: yes, please do this!!! :) [16:17:49] thanks [16:17:59] niedzielski: FlorianSW: it's not obvious what the use case would be for installing to an SD card, but i don't know everything! [16:18:14] i'll create it now while i'm thinking of it [16:19:15] mdholloway: I think for "older" or "low-price" devies it's a critical possibility, as they probably don't have much internal storage and you take any possible way of reducing the used space on the internal space :) [16:19:39] FlorianSW: that makes sense [16:19:56] mdholloway FlorianSW: oh, i misread this ticket. I was thinking the app was installed on internal and external saving was wanted. this is the opposite. so i agree with mdholloway that this should be closed [16:21:38] niedzielski: the otrs ticket requests to save "saved pages" to an external storage (such as SD cards) no matter where the ap is installed. [16:25:36] niedzielski: so, was it enwiki that you tried and failed to log into? [16:28:13] mdholloway: that's right. i'm on enwiki [16:28:27] mdholloway: let me drop back to master and double check there isn't something else wonky going on [16:29:42] niedzielski: i'll be happy if logging in is still ok on master and just a flaw with that patch [16:29:58] niedzielski: i'm going to fire up master and do some logins/account creates as a sanity check [16:30:09] mdholloway: ok master works fine for me. going to double check the patch [16:30:19] niedzielski: ah, we're on the same page i see [16:32:01] mdholloway: hm, patch fails instantly for me. maybe we can try again after those auth patches get merged and it's rebased [16:32:57] FlorianSW: btw, thanks for your help! i updated that ticket [16:33:19] niedzielski: great, thanks :) [16:33:34] :) [16:34:14] niedzielski: ok, seems all's well with logins (on testwiki as well), any problem is with my patch alone, sorry for the scaremongering :) [16:34:21] *and account creation [16:36:20] mdholloway: np, tough, pervasive task. difficult to get right [16:54:41] o/ [16:55:07] despite being connected via 4g, i currently have a better internet connection than i do to my house via a landline [16:57:05] well, connection speed is relative. you add the speed of your auto to the speed of your connection [16:57:53] niedzielski: ... [16:58:00] i... must... not... respond [16:58:19] niedzielski: are you going to pop in and out of reading web's standup today? ;) [16:58:39] i might, i might not [16:59:08] depending on how fast you're going, right? [16:59:25] if i don't, just imagine someone delivering the shortest status ever [17:49:33] bearND mdholloway: i'm not sure if you guys run into this case much but i just uncovered some some draft in my inbox about testing a local content service instance in conjunction with a local vagrant instance. i think all that was needed was setting the restbase endpoint to "http://192.168.1.11:6927/192.168.1.11:8080/v1". now that we have the media [17:49:34] wiki endpoint app setting, i guess we would just need to change that to "http://192.168.1.11:8080" directly and disable the language supported setting. then the restbase endpoint can just use %2$s i think. if either of you poke in this area, it might be worth noting it on our wiki page. (i'll try to do the same next time around!) [21:20:55] jhobs: please submit whatever you have for the case insensitive support! Gerrit should be working again now. [22:15:41] jdlrobson: i think jhobs is normally wrapped for the day by this time [22:15:50] jdlrobson: although not sure about today specifically [22:15:59] looks like it [22:15:59] dr0ptp4kt: jdlrobson, normally, yes, but I'm fixing something I found last-minute [22:16:12] spoke too soon :) [22:16:13] sorry, I missed your message jdlrobson, i'll ping you when I push [22:16:18] please do! [22:16:27] yeah I just noticed something like right after grooming [22:16:35] so I wanted to get that fixed up first [22:43:25] jdlrobson: https://gerrit.wikimedia.org/r/#/c/300438/ Can you specifically check the EL part of the AC? It was working yesterday, but after a git-update today my EL dependencies wouldn't update which broke it locally [22:46:20] and I'll review your cards first thing tomorrow since you've updated the patch sets on them [22:59:04] jhobs: sure will have a little bandwidth in a bit [22:59:45] jhobs: dont worry too much about reviewing mine ive had some good feedback already. I'd focus on wrapping up your card and the last card in todo. [23:00:08] jdlrobson: alright. I'm out for the night o/ [23:26:52] jdlrobson: dr0ptp4kt are you seeing wikidata descriptions on beta? i cant [23:27:02] nzr: i raised a bug about it [23:27:12] https://phabricator.wikimedia.org/T141067 [23:27:17] ship it plz [23:27:48] :( [23:27:53] unless enabled in stable < how can you even do that [23:28:07] i mean how can user [23:28:17] anyways, i agree. we should just ship it :-S [23:29:02] what are we waiting for? Anyway it's been hella confusing trying to contain wikidata descriptions in only certain parts of ui [23:29:50] they wanted a way to indicate where is coming from on UI. I think i'm going to decline it. it's just not possible. we can add it in editing somehow