[08:08:56] <phuedx>	 morning
[08:08:58] <phuedx>	 o/
[08:18:58] <bmansurov>	 yo
[09:11:54] <joakino>	 moarning
[11:14:11] <phuedx>	 out for lunch
[16:30:53] * niedzielski accidentally types "git" into gerrit browser window with keyboard shortcuts enabled. who knows what i +2d
[16:43:03] <phuedx>	 lol
[16:43:13] <phuedx>	 dr0ptp4kt: currently enabling gadgets on reading-web-staging
[17:01:26] <jhobs>	 joakino: standerp
[17:35:42] <jdlrobson>	 phuedx|zzZ: im tackling the search input bugs
[17:40:08] <nzr>	 dbrant: https://phabricator.wikimedia.org/T141162 is this helpful?
[17:42:41] <dbrant>	 nzr: definitely; thanks for that! In previous quarters, we had a "master" phab task that represented the main Epic for the quarter, whereas now we use a phabricator "project" to track our progress.
[17:43:00] <dbrant>	 nzr: but this is definitely still useful.
[17:43:10] <nzr>	 dbrant: cool
[17:50:21] <jdlrobson>	 phuedx|zzZ: the patches are up and ready for review. Not sure if you are actually Zzzz or just away given the standup commitment. Otherwise i guess we'll be waiting till tomorrow.
[18:01:34] <nzr>	 dbrant: where can i find the playstore screen dimensions 
[18:03:08] <dbrant>	 nzr: ah yes, here are the official guidelines: https://support.google.com/googleplay/android-developer/answer/1078870
[18:03:42] <dbrant>	 nzr: it doesn't look like they actually care about aspect ratio, except "The maximum dimension of your screenshot can't be more than twice as long as the minimum dimension"
[18:05:01] <nzr>	 ahh okay
[18:05:20] <nzr>	 so weird.. just give me hxw
[18:05:21] <nzr>	 :P 
[18:05:33] <dbrant>	 yep, i know!
[18:15:16] <gwicke>	 bearND, mdholloway: we noticed that you stopped returning the pageid in feed responses yesterday; was this on purpose?
[18:16:03] <mdholloway>	 gwicke: caused by T141307, i believe
[18:16:04] <stashbot>	 T141307: [BUG] News links can be duplicated and/or lack expected metadata - https://phabricator.wikimedia.org/T141307
[18:16:25] <mdholloway>	 gwicke: patch up for review here: https://gerrit.wikimedia.org/r/#/c/300985/
[18:16:56] <gwicke>	 what's your ETA on that?
[18:17:07] <gwicke>	 (reason for asking is that our tests are currently failing because of this)
[18:18:25] <mdholloway>	 niedzielski: ^ i've just added tests since yesterday, so can we consider you a +1?
[18:19:06] <mdholloway>	 gwicke: we were close to merging yesterday, but you'd probably know the answer to this: is there any wikipedia for which '#' is a legal character in an article title?
[18:19:48] <niedzielski>	 mdholloway: yep
[18:19:54] <mdholloway>	 niedzielski: cool, thx
[18:20:36] <gwicke>	 mdholloway: if it was, then it would be percent-escaped
[18:20:46] <gwicke>	 so not an issue for section anchors
[18:21:13] <mdholloway>	 gwicke: ok, that's what i'd expected/hoped
[18:21:30] <mdholloway>	 gwicke: if bearND is OK with the patch as updated, i can try to squeeze in a deployment after the MW train
[18:21:53] <gwicke>	 mdholloway: great, thanks!
[18:22:04] <gwicke>	 I'll hold off on changing the spec, then
[18:22:10] <mdholloway>	 gwicke: you're welcome, sorry about breaking your tests!
[18:22:49] <gwicke>	 yay for automated API tests
[19:39:02] <maxbinder>	 dr0ptp4kt: en route?
[20:10:33] <niedzielski>	 bearND dbrant_ mdholloway: just a heads up that gerrit is regularly not adding all reviewers. here's three recent: https://gerrit.wikimedia.org/r/#/c/301012/ https://gerrit.wikimedia.org/r/#/c/301012/ https://gerrit.wikimedia.org/r/#/c/300992/
[20:10:53] <niedzielski>	 bearND dbrant_ mdholloway: if you see me missing on a review, please add me! :)
[20:13:06] <mdholloway>	 niedzielski: sorry about that, and thanks for the heads-up!  i forgot to manually add reviewers on the last couple from last night and today -- just added to you my latest :)
[20:14:05] <niedzielski>	 mdholloway: it's all good! just wanted to mention it
[20:25:13] <bearND>	 niedzielski: mdholloway : I guess this is due to the new Gerrit version
[20:26:31] <niedzielski>	 bearND: it happened on the old version but i thought only when two patches were pushed to the same patchset before the first was verified. seems to be happening a lot lately
[20:57:40] <mdholloway>	 bearND: dbrant: niedzielski: in the news cards now live in de, ru, he :)
[20:57:57] <dbrant>	 :)))
[20:59:00] <niedzielski>	 mdholloway: nice!
[20:59:06] <niedzielski>	 now that's what i call news!
[21:00:20] <niedzielski>	 just got myselfa freeze pop. why oh why didn't i take the blue pop?
[21:00:39] * niedzielski is sad that kids these days don't get his great matrix references
[22:03:16] <nzr>	 lol
[22:19:10] <jdlrobson>	 niedzielski: dbrant where do the docs for the rest apis live again? 
[22:19:17] <jdlrobson>	 https://en.wikipedia.org/api/rest_v1/?docs failing
[22:19:54] <gwicke>	 try ?doc
[22:19:56] <Pchelolo>	 jdlrobson: https://en.wikipedia.org/api/rest_v1/?doc
[22:21:01] <jdlrobson>	 thanks Pchelolo/gwicke just found it in an email 
[22:21:05] <jdlrobson>	 have raised a bug -> https://phabricator.wikimedia.org/T141402
[22:21:13] <niedzielski>	 jdlrobson: also some other docs here: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/RESTBase_services_for_apps
[22:21:15] <jdlrobson>	 i think this could be made more discoerable
[22:21:38] <jdlrobson>	 Just wanted to report https://phabricator.wikimedia.org/T141403
[22:23:11] <Pchelolo>	 jdlrobson: I think it's a MCS issue, RB is not mangling MCS output in any way
[22:23:29] <jdlrobson>	 https://en.wikipedia.org/api/rest_v1/page/html/Amar'e_Stoudemire < Pchelolo 
[22:23:31] <jdlrobson>	 seems to be a problem there too
[22:23:40] <jdlrobson>	 Warning: Page using Template:Infobox basketball biography with unknown parameter "1 = team5- ??New York Knicks ..." (this message is shown only in preview).
[22:23:51] <jdlrobson>	 fine if Parsoid is exclusively for editing but it shouldnt be that way right?
[22:26:02] <gwicke>	 jdlrobson: please report this as a parsoid bug
[22:26:19] <jdlrobson>	 gwicke: it has the Parsoid tag on it
[22:27:21] <gwicke>	 this is an instance of scribunto exposing stuff that it probably shouldn't
[22:27:44] <gwicke>	 and editors using that for "interesting" preview functionality
[22:28:04] <gwicke>	 see https://phabricator.wikimedia.org/T137900
[22:29:58] <gwicke>	 to be fair, the cat on that info is out of the bag in any case (via the revid magic word), but hopefully providing a better means of reporting errors will avoid it being used the way it does in that page
[22:33:21] <gwicke>	 added a link & screenshot to that page