[14:20:00] jdlrobson: sorry i missed your message. one of us can surely help today [15:10:50] jdlrobson: what's your question? btw, I've put some documentation about the mobilcontentservice role on https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/RESTBase_services_for_apps#MW_Vagrant [15:48:07] phuedx: has the browser test failure patch just not hit beta yet, or are these failures we're getting genuine? [16:02:02] nzr: phuedx jdlrobson retro [16:03:42] bearND: niedzielski im struggling getting vagrant up and running with the mcs [16:05:11] jdlrobson: i haven't had to use mcs with vagrant much yet. when i did, i used them separately. i.e., i ran vagrant as perusual and then just ran the content service in a separate repo [16:06:35] my use case was the android app, so i just updated the uris to point at the local instances [16:07:10] jdlrobson: is the puppet repo in your vagrant recent? mobrovac had to update it to make it work [16:08:45] jdlrobson: you need to have at least this change "2016-07-15 60cff75 Parsoid: Move to service::node" [16:23:28] bearND: sorry in a retro right now but you will have my attention soon :) [17:30:05] phuedx, jdlrobson, bmansurov: latest build is still failing https://integration.wikimedia.org/ci/view/Mobile/job/selenium-MobileFrontend/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/lastCompletedBuild/testReport/ [18:00:12] HaeB: jkatz and i will be there pretty soon [18:16:01] dbrant: hey i created a card for horizontal scroll [18:16:22] nzr: yep, saw it come in; thanks [18:16:31] cool [18:16:43] :) [18:36:38] dbrant: so... i've got the service running but can't find it [18:37:24] dbrant http://localhost:8888/dev.wiki.local.wmftest.net/v1/page/mobile-sections-lead/Headings and http://localhost:8080/dev.wiki.local.wmftest.net/v1/page/mobile-sections-lead/Headings give a 404 [18:37:58] bearND: ^ [18:38:23] (sorry i got confused and thought dbrant had replied but he was talking to nirzar :) [18:40:21] jdlrobson: I'm running a vagrant update right now. I'll try it on my end once that is done. I assume you have a page called Headings. Does the Parsoid version work (in the URI replace mobile-sections-lead with html)? [18:40:39] ah i think it's using 8888 [18:40:43] which im using for somethign else [18:41:05] so question becomes.. how can i change the port [18:45:35] worked it out [18:47:01] jdlrobson: ok, just found it, too in puppet/hieradata/common.yaml:mobilecontentservice::port: 8888 [18:47:20] jdlrobson: which other module uses 8888? I think that's a popular port number [18:49:23] jdlrobson: since I got you on the line. I've got a question about action=mobileview. Where can I find the code which modifies any links? Is there any special handling in MFE or is that all coming from core? [18:49:46] I use 8888 for MAMP [18:49:53] 8142 is a common node port [18:50:06] modifying links? We don't touch them from what i know [18:50:20] unless it's in MobileFormatter [18:51:52] jdlrobson: the links in Parsoid output are different from mobileview. I would like them to look the same. Compare https://en.wikipedia.org/api/rest_v1/page/html/User%3ABSitzmann_(WMF)%2FMCS%2FTest%2FTitleLinkEncoding with [18:51:52] https://en.m.wikipedia.org/w/api.php?action=mobileview&format=json&formatversion=2&prop=text%7Csections%7Clanguagecount%7Cthumb%7Cimage%7Cid%7Crevision%7Cdescription%7Clastmodified%7Cnormalizedtitle%7Cdisplaytitle%7Cprotection%7Ceditable&onlyrequestedsections=1§ions=all§ionprop=toclevel%7Cline%7Canchor&noheadings=true&page=User:BSitzmann_%28WMF%29%2F [18:51:52] Try%2FTitleLinkEncoding&thumbsize=1024 [18:52:08] That's because Parsoid attempts to make MediaWiki semantic [18:52:12] and changes the markup [18:52:20] (same for figure instead of thumbnail for example) [18:53:43] jdlrobson: So, if it's not in MobileFormatter then it should be all from core? [20:00:51] jdlrobson: dr0ptp4kt I'm in the hangout [20:05:03] jdlrobson: lost you [20:29:17] bearND: yep sorry for late reply [20:31:59] jdlrobson: retro notes mostly just refer to email dustup [20:45:05] bearND: ttps://gerrit.wikimedia.org/r/302588 and parents! [20:45:15] hoping to submit a few more now I have a reason to use it [20:52:49] bearND: what do you mean aadd to the tests? [20:53:32] jdlrobson: test/features/mobile-sections-lead/pagecontent.js [20:53:46] https://gerrit.wikimedia.org/r/#/c/302567/2/test/features/mobile-sections-lead/pagecontent.js < bearND ? [20:53:59] yep [20:55:07] jdlrobson: maybe you could add one with a non-0 namespace, too? [20:55:33] jdlrobson: sorry, I didn't see your test earlier [20:56:21] i guess my gerrit screen was stuck at ps 1 [20:56:53] bearND: strangely i cant get tests to work locally [20:56:57] do i need to stub anywhere? [20:57:08] in vagrant? [20:57:10] or run some compile test? [20:57:16] outside vagrant [20:57:21] am running via npm test [20:57:33] seems i shouldnt need vagrant? [20:57:44] the fixtures are cached by default. you may have to blow away the fixtures folder [20:58:07] ahh [20:58:27] would be great to add that to README [20:58:47] oh i see it's there now :) [20:59:29] it's a bit hidden [21:00:59] i usually don't work inside vagrant. Just a local clone of the mobileapps repo. I think most tests would probably fail in Vagrant since you'd have to make sure you've got the correct pages inserted to your vagrant installation [21:16:38] bearND: hi there, i guess you know in the new alpha if you press overhaul it crashes the app [21:17:07] matanya: no, that's news to me. /cc:niedzielski mdholloway [21:17:40] matanya: thanks for the report. it isn't intended to show the overhaul in alpha builds :/ [21:17:59] matanya bearND: i'll put in in a patch in a bit [21:17:59] it is there since wedensday build [21:18:55] niedzielski: also, the explore link in the sidebar is gone, but i think that one is intentional, though i found it extreamly useful [21:20:03] matanya: the fate of the explore / read link is in discussion with design. i'll fix it for the alpha builds in the same patch [21:20:15] thanks! [21:20:25] who is the lead desinger ? [21:20:46] niedzielski: thanks [21:22:07] matanya: thanks :) i think you'd probably want to work with dbrant who's working on the requirements [21:22:41] whatever helps [21:26:05] niedzielski: if you are open to more feedback, i have some other comments [21:27:05] matanya: of course! [21:27:12] so here is comes: [21:27:41] when adding an article to the reading list, you can add by clicking the icon [21:27:55] that opens the dialog to which reading list to add the article [21:28:13] but removing an article is a whole other flow. [21:28:33] you go to the reading list( the correct one, go find it;)) [21:28:43] and swipe the article away [21:29:17] wouldn't it be much more intuitive to just unmark the reading list icon, and just ask for verification [21:29:29] removing it from the right list without bugging the user ? [21:29:50] second point is: [21:30:17] matanya: the remove flow is to allow for multi-list membership [21:30:35] yes, i figured that [21:31:01] but it only allows saving, not removing [21:31:53] so if i have an article already in a reading list, and i click the icon again, i would expect a question if i want it to be added to a new list, or removed [21:32:01] since it is already checked [21:32:07] matanya: oh i see [21:32:26] matanya: i'll make a phab to explore that flow a little more [21:32:35] (starting with that sugesstion) [21:32:48] ok [21:32:56] matanya: cool, next? [21:34:25] in image file when you click the pencil, you get : no network connection [21:34:47] i guess it is due to the fact it is not locally available, but didn't it test it too much [21:35:21] e.g click on an image, and choose to go to the file page [21:35:35] matanya: is this when the device is offline or even when you have internet access? [21:35:40] trying editing on that page with the pencil [21:35:44] every time [21:39:07] matanya: would you mind pointing to a specific article's image? i'm not seeing any edit pencils on the File pages for the ones i tried [21:39:39] I can reproduce on hewbrew, with latest alpha: [21:39:46] go to the article בית רימון [21:40:14] click the map in the info box [21:40:23] see pencil [21:40:31] click it [21:40:33] ah, i see [21:40:47] i'll file a bug for this. good find [21:40:59] third [21:43:07] when there is an link in image description and you click it, you get a preview, if the preview has an image and you click it you go to the image file [21:43:28] instead of the article, which i think is the expected behavier [21:43:39] but arguable [21:44:07] matanya: do you happen to have an example image handy for this one too? :] [21:44:13] correction, it is true for any link [21:44:53] try brasil in english [21:45:11] click south america at the begining of the article [21:45:21] click one of the images in the preview [21:46:15] fourth: RTL bug :) you didn't think you would get away with what, right ? [21:46:22] *with that [21:47:38] when you change a language from RTL to LTR the context menu shown when clicking a link for several seconds pops up, but with flipped sides [21:47:48] matanya: so you're saying that you expect that when you click on "Iguazu Falls" link in the description, you expect a link preview, right? [21:48:23] matanya: are you changing RTL in the app or in the system settings? [21:49:07] to the first q: where is Iguazu Falls? [21:49:22] to the second q: not changing RTL, change article language [21:49:50] matanya: so i click on south america and then tap the first image (a big waterfall). the gallery pops up and that's where i see the iguazu falls link [21:50:21] ah, before that [21:50:38] i meant when you click the image itself, you are taken to the gallery [21:50:48] i thought you would be taken to the article [21:50:58] it is an article preview, isn't it ? [21:50:59] matanya: ohh, i get it [21:51:40] matanya: that's definitely intended behavior but i can open a ticket for that if you'd like to engage in further discussion [21:51:55] right, article preview = link preview [21:52:21] and your second comment is valid too, if it is a link, in the Iguazu Falls, you should be taken to the article, not download the file in that page [21:52:27] it is about consistency [21:52:48] you expect links to take you to article, not galleries, or downloding files [21:53:32] matanya: for the second comment, i think agree. i think we just haven't done it because it was some older code and not an easy win. i can open a phab for the gallery and a separate one for the link preview carousel [21:53:55] the only way i think clicking images should take you to the image page is in articles [21:55:01] and only now i found out it is a carousel! cool! [21:55:07] matanya: i don't think i personally agree with that for the current carousel design but i can open a ticket [21:55:25] fair enough [21:55:39] should we move to the RTL issue? [21:58:40] matanya: almost. so while we were chatting i looked at our git history and remember that replacing the explore / today menu entry with the feed entry was intentional. replacing the feed entry with overhaul in alpha was not. so i can fix the latter one but adding the explore entry back would be a separate discussion [21:59:16] I guess i can live with that, tough i really liked it :) [22:00:19] matanya: were hoping to move more of the portal page into feed cards and then we're trying to figure out whether to have a dedicated tab for general reading (including the portal) in the overhaul [22:00:23] feed is good too, if you refer to the page when you open the app and get the new, recent articles and featured one [22:00:38] (the overhaul is just a tabbed design instead of the menu) [22:00:58] oh, i am looking forward to that [22:02:12] matanya: it's far from baked yet but you can check it out on the dev builds. if you're interested but don't like building locally i can probably promote it to alpha instead of removing the overhaul entry [22:02:38] whenever you are ready [22:03:23] matanya: alright i'll take a look at bumping it up. maybe other folks are interested too [22:03:56] matanya: ok back to rtl land. so you're saying that if you view the obama article in english, switch the article language to hebrew, and long press to highlight some text, that the context menu isn't proper? [22:04:01] ok, while we were talking i found two new bugs, so we have RTL and two location bugs :) [22:04:18] niedzielski: the other way around [22:04:21] start in Hebrew [22:05:46] matanya: what android version is this on and what is your system and app language again? [22:06:13] further testing shows it is not linked to changing languages [22:06:24] I have 6.0 Hebrew, Hebrew [22:06:40] refined reproduce: [22:07:12] open an article in english, click a link, click the three dots, if your lang is RTL the menu is flipped [22:08:54] or to be accurate: not flipped, left aligned [22:09:30] matanya: hm. so my 3 dot overflow menu icon is on the right hand side with system and app language set to hebrew and article language set to english [22:09:54] matanya: in the article preview that is [22:10:00] that is true and correct [22:10:22] but the text itself in the menu is wrong aligned [22:10:41] matanya: ah, i see your point [22:11:27] matanya: so long term i think we want to fully localize the app based on app and article language. right now that menu is being picked from system. there are a number of other places with similar issues in the app [22:11:39] indeed [22:12:05] matanya: i can't remember if we have a formal phab task for tracking this longer term goal or not. but i'll make sure we do and add this example either way [22:12:20] thanks, location bugs now ? [22:16:05] matanya: so here's what i've noted as the high level issues we talked about so far: [22:16:07] Localize app based on app and article language, not system language [22:16:08] Dedicated reading tab is desirable [22:16:08] Promote overhaul to alpha build and don't hide the Feed entry [22:16:08] Article preview carousel images should lead to article, not image [22:16:08] Gallery should offer article previews [22:16:09] Edit pencil shown on File pages for non-English languages [22:16:10] Toggling a Reading List article should be streamlined for removal [22:16:29] (i'll add details when i make the tasks) [22:16:49] yes, great summery [22:16:50] matanya: if this is correct, let's talk about the location bugs [22:17:15] minor one or severe one first? :) [22:17:35] give me the severe one [22:17:56] go to location with location services off [22:18:05] click the blue icon [22:18:21] go to your home screen and enter another app [22:18:31] go back to the wikipedia app [22:18:34] get a crash [22:19:19] (in step one: location menu in the bar, under reading list) [22:23:06] matanya: hm, i am missing a step i think. so i go to the mount everest article in hebrew wikipedia. i tap the article navigation button which is right under the lead image and allow it to open in some other app like google maps. then i tap the home button and relaunch the wikipedia app? [22:23:33] no, the around buttong [22:23:43] i am not sure how it is called in english [22:23:52] nearby? [22:23:57] yes, that [22:23:59] that fancy map view in the app? [22:24:03] yes [22:24:12] click that, with no location services [22:24:21] and continue from there [22:26:56] matanya: ah ok. so i have location services turned off. i launch the app fresh and go to the nearby screen. i get a really zoomed out view of things. i tap the marker, Mirdif 35, and am taken to the article. i press home. i launch google calendar and press home again. then i tap wikipedia to relaunch the app? [22:27:17] (google calendar is just some other app) [22:27:47] i'll upload a short video [22:28:11] :] [22:28:42] niedzielski: hey are you around? [22:28:46] does this happen on production for your device? [22:28:53] mhurd: yep :] [22:29:07] have a minute for quick hangout? [22:30:07] mhurd: i'm trying to wrap up i htink the last two issue with matanya. would it be possible to convene then? i think we're getting close [22:30:28] niedzielski: checking [22:31:02] niedzielski: oh no prob! just had a TWN question. mostly about where the scripts which pull from/push to our strings files lives [22:31:32] doesn't happen on prod [22:31:59] mhurd: i'll ping you shortly :] [22:32:10] niedzielski: perfect thx! [22:32:15] matanya: thanks. i'm trying a couple things over here [22:36:23] matanya: hm. i don't think i can repro that one at the moment but i don't doubt that it exists [22:36:42] upload a video niedzielski [22:38:22] niedzielski: https://foss.co.il/owncloud/index.php/s/nGHSEJYoiKKs2WV [22:38:29] can you download that ? [22:40:18] matanya: nice! yeah that came through fine [22:40:55] is it clear now ? [22:43:57] matanya: your repro steps are clear but i still can't repro. does this happen 100% of the time for you? [22:44:03] yes [22:44:08] geez [22:44:11] each and every time [22:44:39] did you set all to Hebrew? i don't think it is related, but you never know [22:45:04] can i see the stack trace loaclly by any chance, maybe with adb ? [22:45:55] matanya: i did try in hebrew and english but that didn't seem to do anything. a stack trace would be amazing. we do print one whenever the app crashes [22:46:06] where? [22:46:43] on your alpha build, our app package ID is org.wikipedia.alpha. you would need to connect to logcat through ADB to see it [22:47:18] it should be fairly large. at least 25 lines i think but probably a bit more [22:47:45] made it work [22:47:49] pasting [22:47:53] niceee [22:48:16] https://dpaste.de/Yf9P [22:48:26] my first time debugging android :) [22:50:10] matanya: well great job! [22:50:20] heh, thanks [22:50:57] matanya: this just what i needed. i _think_ this is an issue in the mapbox sdk, so i will report it in there repo. if you have github account i can CC you [22:51:14] yes, it is mat_mo [22:52:13] matanya: ok, i'll write that up too. i've added it to our list [22:52:19] so now to minor ones: [22:52:34] ✔ [22:53:00] when location services are off, the apps doesn't tell you, and you wonder why nothing happens when you hit nearby, but put somewhere in alaska [22:53:21] (unless you are nearby alaska) [22:54:04] matanya: hm, so if you refuse location permission we show a "snackbar message" at the bottom of the screen but you're right, i don't see anything for when location is turned off [22:54:45] matanya: ok, added it [22:54:58] next [22:55:02] still location [22:55:37] why aren't we use maps.wikimedia.org and use a third party [22:56:18] you mean when you tap get directions? [22:56:26] yes [22:56:32] it takes me to google [22:56:41] moreover, i see we use mapbox [22:56:52] our map support is kind of barebones right now. there's lot of work we could do to improve it [22:57:01] we can use maps.wm for that too, can't we ? [22:57:17] ok, so feature request, not a bug report :D [22:57:21] matanya: you mean the website? [22:57:52] instead of calling mapbox to draw the world when clicking location [22:58:11] get the map from maps.wm if possible [22:58:26] matanya: yeah, i personally have kind of mixed feelings about the map stuff. it makes our app huge and i see it as more of a peripheral experience than core functionality (and should be prioritized as such). however, lots of folks _love_ it so i'm sure we'll be adding more and more to it [22:58:49] matanya: we do use the maps.wikimedia server for the tiles and styles [22:58:56] didn't check it, at all, but i really don't like sharing my location, more over with third party services [22:58:58] matanya: the sdk is open source and from mapbox [22:59:13] but i see your point [22:59:15] matanya: we try to disable the mapbox telemetry service [22:59:43] it is my lower on the list anyway, as i have location turned off like 99.999% of the time [23:00:19] am i wasting lots of your time ? [23:00:39] matanya: if we did anything drastic with the sdk, i think we would fork the mapbox version but i don't think it's likely we'll have bandwidth to maintain right now [23:01:00] casue i still have multimedia issues on my list (short though) [23:01:17] of course not! lots of good bugs and suggestions. i would like to encourage you to also check out task board so you can get a sense of what we're thinking about. it's over here: https://phabricator.wikimedia.org/tag/wikipedia-android-app-backlog/ [23:01:34] it is open in front of me :) [23:01:44] i check it before i come with bugs and suggestions [23:02:31] matanya: so we try to establish some quarterly goals. they have our priority for what we're currently working on but the upcoming goals is where we try to figure what we should work on next (this would be where new features are most likely to come in) [23:03:11] matanya: this quarter we're really to make the app look a lot better, primarly with changing the menu to a tabbed design and a number of small improvements [23:03:23] yes, sprints, story points, etc, I am managing a team, know all this :) [23:04:10] so multimedia issues ? [23:04:49] matanya: ok cool, i hope that came across fine :] [23:04:56] sure [23:05:42] so lets go to the fifth simphony of bethoven [23:06:19] Symphony_No._5_(Beethoven) [23:06:50] on mobile web and desktop you can play the Symphony [23:07:10] by clicking the media [23:07:16] on the app you can't [23:07:36] you could in the past, but it broke at some point, and i noticed it only recently [23:07:52] matanya: we recently switched over our backend and i think some of these aren't quite working right. i'll file a ticket if we don't already have it [23:08:06] matanya: so i can see that this ogg file opens a link preview for example [23:08:35] yes, it used to be a player in the past [23:09:02] ok i've got that down [23:09:03] in the production one it works [23:09:25] hm, i wouldn't have expected that if it's broken in dev. we'll figure it out [23:10:32] broken in beta too, if the helps biscet [23:11:19] matanya: i'm pretty sure this is backend induced issue. actually, i can repro in prod if i force it to use the new backend [23:11:19] next is gif [23:11:32] i'll make sure it's reported, thanks :] [23:12:12] I think the gif one never worked, but i can't recall reporting it [23:12:47] when you say gifs don't work, where in the app are you looking? i thought this should actually work [23:12:51] for example, go to the article פיניאטה [23:13:16] you can only see a thumb, not the file in the file page [23:13:46] you see kacie harold hitting a pinita [23:14:05] you can use english too, if you prefer it [23:14:09] that file bug is more than just gifs. it's any image [23:14:14] and we do have a ticket for that [23:14:25] i'll make a note to CC you on that [23:14:25] what do you mean any image ? [23:14:54] if you go to any image's File page, you don't see the image using the new backend [23:15:03] I can see jpg's and pngs [23:15:27] if you click on the jpg in pinita, you see it in the file page [23:16:28] i think your app is just falling back to the old backend for unrelated reasons (if the new backend has errors, the app will try to use the old backend which actually works for file pages) [23:16:41] ah [23:16:42] that same jpg doesn't show on the File page for me [23:17:02] i'm pretty sure on this one and will CC you on the appropriate ticket [23:18:16] for video i remember there is a ticket [23:19:25] matanya: sorry, this is what's i'm thinking it is: https://phabricator.wikimedia.org/T135242 [23:19:57] matanya: oh, and here's the corresponding new backend (called the "Content Service" or "Mobile Content Service") board: https://phabricator.wikimedia.org/project/view/1323/ [23:19:57] likely [23:22:02] yes, here it is https://phabricator.wikimedia.org/T105643 niedzielski [23:22:51] matanya: ah, ok i misunderstood. yeah, that'd be cool to have [23:23:25] I think i said it all. Thank you so much! [23:25:40] matanya: thanks for all the reports! lots of good stuff! i'd like to also encourage you to feel free to report bugs and crashes on our board directly: https://phabricator.wikimedia.org/tag/wikipedia-android-app-backlog/. there's a link on the side with template that i always use. for new features and other discussions, i normally just write a plain [23:25:40] ticket. we try to keep up with the triage column at least to make sure tickets are properly prioritized. this has been really great! [23:26:09] matanya: otherwise, i'll see you on irc! [23:26:32] sure thing! many thanks [23:27:07] mhurd: o///// <-- me waving very fast but recorded with a slomo camera. can we talk in like 15 minutes? i need to grab a drink and dig around for that code [23:27:23] niedzielski: haha sure! [23:37:12] mhurd: sorry for the wait. i think i am ready for batcavery when you are [23:38:03] niedzielski: cool in there now https://hangouts.google.com/hangouts/_/event/c5p2pudvb8s6ckluqf56v791em4