[08:21:36] g'morning y'all [08:24:01] phuedx: o/ [08:25:12] mdholloway: where are you again? [08:25:28] (it's funny to actually have a couple of folk to talk to at this hour0 [08:25:29] *) [08:25:57] phuedx: i'm in karachi, visiting my wife's family [08:26:04] (long stays are customary :)) [08:26:40] finally adjusted to the time difference (9 hours later than back home) [08:28:09] ouch [08:32:19] * mdholloway -> lunch [08:49:05] joakino: yt? [16:01:16] maxbinder: hey we have the terrible room [16:01:36] Going to be late for retro [16:01:46] Train troubles [16:02:37] jdlrobson: moved you to diderot [16:02:47] jdR35 [16:02:52] jdlrobson: R35 [16:03:13] thx [16:06:58] niedzielski: bearND: niedzielski: o/ are we on sprint 88 or 89 now? it looks like we've somehow got both boards going [16:07:40] mdholloway: I thought we're at 89. I saw dbrant|brb copy tasks from 88 to 89 [16:07:46] mdholloway: o/ no idea. i just got back :) [16:07:58] niedzielski: welcome back! :) [16:08:19] thanks [16:09:27] just wondering for the purposes of the scrum of scrums etherpad, which i'm about to fill out then peace outta here for the night [16:09:57] i'm calling 88 current and 89 next [16:10:28] (there's no 90 board yet) [16:12:18] ok, i'll be back for standup, later [16:20:15] niedzielski: bearND: mdholloway|afk: o/ 89 is the current sprint [16:20:24] (started this week) [16:39:13] kaldari: Looks like you recently changed an abusefilter on testwiki which we use in the Android app to test abusefilter functionality. Do you remember what it was set to before and why the change was needed? (See id=2 in [16:39:13] https://test.wikipedia.org/wiki/Special:ApiSandbox#action=query&format=json&list=abusefilters&abfshow=&abfprop=id%7Chits%7Cactions%7Clasteditor%7Clastedittime%7Cstatus%7Cdescription%7Cpattern%7Cprivate) [16:39:46] bearND: lemme check... [16:39:47] kaldari: our CI tests are failing since then [16:43:04] kaldari: the test expects the abusefilter to return an error but now it only returns a warning [16:43:04] bearND: id 2 was the poop filter. I deleted that one since it is now a global filter. It can be undeleted if you need it. [16:45:05] kaldari: would you undelete it on testwiki and add a comment saying something about the Android app automated tests there? [16:48:13] bearND: Could you tell me a little more about what is failing exactly? It seems odd that the tests would be dependent on a specific filter (rather than the underlying filter behavior which should be covered by the global filter) [16:52:13] bearND: I've undeleted and re-enabled the filter and added a note about the automated tests for Android. [17:03:25] kaldari: thank you. https://integration.wikimedia.org/ci/job/apps-android-wikipedia-periodic-test/715/testReport/junit/junit/org.wikipedia.test/EditTaskTest/testAbuseFilterTriggerStop/ is an example of the failure. (2 means error, 1 means warning in this case) [17:05:20] Here's the test code: https://phabricator.wikimedia.org/diffusion/APAW/browse/master/app/src/androidTest/java/org/wikipedia/test/EditTaskTest.java;abb85047c5936cea890ce5ac704ef9feb0f4de23$92 [17:08:31] hey tgr|away you have anything for bearND for scrum of scrums today? he's the one attending on behalf of reading [17:16:53] dbrant: jooooiiin uuuuussss [17:27:14] mdholloway|afk: email standup? [17:27:28] maxbinder: yep, writing it up now [17:27:37] 👍 [18:15:18] dbrant: niedzielski-afk mdholloway|afk : https://gerrit.wikimedia.org/r/#/c/303942/ got +1'd, need one of you to +2, then we can start beta [19:29:13] dbrant: can't make grooming, save yourselves [19:29:31] no worries! [19:41:13] bmansurov: around? YOur comment about the ul confused me https://gerrit.wikimedia.org/r/#/c/305083/ [19:41:26] the ul tag is the old footer HTML it's not used in the new footer [19:41:32] jdlrobson: let me check [19:41:40] thanks [19:45:04] jdlrobson: https://phabricator.wikimedia.org/T143252 see how the site image is wrapped in a 'ul'? [19:45:34] jdlrobson: i was wondering if we could get rid of the enclosing 'ul' and 'li' and just have a `h2` [19:46:00] oh i see. Well.. this is the safest way right now to maintain the two footers without hitting cached HTML issues [19:46:12] i can explore removing the enclosing list in a follow up [19:46:18] ok [19:46:24] im not sure if there is a good reason it's done that way [19:46:47] maybe it made sense when every item in the footer was on one line, but now the site name is on it's own line [19:52:24] bmansurov: sure .. but remember other extensions populate that footer too [19:52:54] jdlrobson: they do so in mobile too? [19:53:33] There's a hook so anything possible. [19:53:47] for instance we put a developer link in on mediawiki.org (although that seems broken on mobile for the time being so not the best example :)) [19:54:03] but bmansurov_ to be clear i agree with you it's not needed and i will explore making it unnecessary [19:54:09] but i will do that in a follow up [19:55:13] jdlrobson: are you also going to submit a follow up patch to match the design in mock-up? [19:55:29] jdlrobson: or would you like to do so in this patch? [19:55:38] bmansurov_: yup i'm working on that. I need that meeting this afternoon with Nirzar though [19:55:53] ok [19:56:00] i'd have to check with nirzar about whether he's okay with intermediate states :) [19:56:10] bmansurov_: you can try out the new design here if you like https://github.com/jdlrobson/weekipedia/tree/footerReorg [19:56:19] would also be interested if it's easy for you to get it up and running :) [19:57:02] jdlrobson: ok, i'll try it [19:57:18] bmansurov_: if you get it working should be clear what my icon issue is :) [19:58:48] jdlrobson: the line under "Contribute" doesn't look right: "npm install npm run dev " [20:02:50] jdlrobson: couldn't get it running locally. This is the error message: Error: Cannot find module 'passport' [20:06:22] did you npm install ? [20:06:40] bmansurov_: looks like i missed that dependency - npm install passport [20:09:54] it's complaining about something something grunt something something, can you remove node_modules and reinstall from package.json on your end? [20:12:32] bmansurov_: : npm install grunt -g [20:14:27] jdlrobson: https://phabricator.wikimedia.org/T143252#2562083 [20:16:02] bmansurov_: interesting. Lemme see if I can work out what'sgoing on [20:19:37] bmansurov_: try checking it out again [20:20:18] bmansurov_: i suspect what is happening though is you have a global install of grunt which is brand spanking new [20:21:24] bmansurov_: what npm version are you? [20:21:28] (npm -v) [20:21:43] 2.14.7 [20:25:50] jdlrobson: now complaining about this: Error: Cannot find module 'oauth' [20:25:57] jdlrobson: i guess i'll try it some other time [20:26:01] upgrade npm bmansurov_ [20:26:08] it's old [20:26:10] i'm on 3.10.6 [20:29:33] jdlrobson: that did the trick [20:29:43] and i see icons are top aligned [20:31:02] :) [20:35:13] jdlrobson, bmansurov_ : I've been checking documentation and I can't seem to get a straight answer: do you know if there's a config key for deploying to all wikipedias? I remember there being one, but I haven't found any documentation on one [20:35:22] I thought it was just 'wikipedia' [20:35:24] jhobs: 'wikipedia' [20:35:29] or 'wiki' [20:35:30] i forget [20:35:35] default? [20:35:40] default is all wikis, no? [20:35:46] and jon, that's exactly my problem [20:35:48] jhobs: i'd just deploy everywhere [20:35:59] i think it's an error to deploy just to wikipedia's [20:36:00] bmansurov jdlrobson: maybe npm should be added as a devdependency? this would give a version requirement [20:36:03] you can check with adam though [20:36:03] task says wikipedias, and I remember dr0ptp4kt banging that factor in... [20:36:33] niedzielski: good idea [20:37:14] jhobs: i'd look at how others are doing in the config file [20:37:19] niedzielski: yeh that's "engines" right [20:37:22] dr0ptp4kt: can you read the last convo and give a call? [20:37:46] Other wikis have images so to just do on wikipedia's seems to be a case of favouring one project over others [20:37:48] jdlrobson: i use engine in my personal projects but i don't that does anything functionally when running npm install [20:38:02] jdlrobson: i guess i never tested it [20:38:11] niedzielski: you can use engine-strict [20:38:49] bmansurov_: yeah that's what I was doing, but we use the words "wiki" and "wikipedia" fairly often in our files ;) I'm PRETTY SURE it's 'wikipedia', but I couldn't corroborate with documentation, so that's why I was asking you guys [20:38:58] jdlrobson: woah [20:39:03] jdlrobson: hm... some devs might not like that :) [20:39:17] documentation says to check all.dblist, which has neither 'wikipedia' nor 'wiki' [20:39:54] but InitialiseSettings.php would imply 'wikipedia' is the correct one [20:41:04] jhobs: i'm pretty sure it's wiki but you can check in operations for a quick answer. I'd suggest getting clarification from Adam first however about the all vs wikipedia [20:41:49] jdlrobson: I pinged him here, and I'll ping him on the task, but I definitely remember the question popping up in one or more meetings and Adam specifically clarifying wikipedias [20:42:58] jhobs: i was in those meetings with Adam. Yes Wikipedia's is what we need to do our analysis but there is no harm in doing all wikis. [20:43:20] but you can check in #wikimedia-operations about whether it's `wiki` or `wikipedia` [20:44:00] yeah I just messaged in there [20:51:21] bmansurov_, jdlrobson: fyi, got confirmation that it is in fact `wikipedia` [20:51:51] jhobs: is it documented anywhere? if not, a good opportunity to do so. [20:52:14] bmansurov_: I missed it initially because it's in the codeblock, but it is actually on this page https://wikitech.wikimedia.org/wiki/Configuration_files#InitialiseSettings.php [20:53:19] The text beneath it is a bit misleading, as it makes it seem that the key must appear in all.dblist, when in fact the dblist filenames themselves are also keys [21:00:17] hey bmansurov_ we are just grabbing coffee see you in 15, [21:00:23] ok [21:02:49] jhobs: fwiw, the usual way of deploying to all projects is default: true, private: false, fishbowl: false [21:03:08] or just default: true if you want to deploy to officewiki and whatnot [21:03:11] tgr: thanks, although this isn't for all projects at the moment [21:03:21] tgr: I'll keep that in mind for when it is though! [21:14:10] bmansurov_: ping [22:39:54] dbrant bearND: release notes are up in the usual place. sorry the lateness of the release but i was chasing a weird issue where article images sometimes wouldn't load on one device with don't keep activities on. i believe it's memory related [22:43:33] everything else looks good though [23:09:20] dbrant bearND: looks like everyone's had a chance to review. i'll post the apk in a bit if i don't hear any objections [23:09:29] +1 [23:09:52] +1 [23:14:02] the beta passed 300k active installs last month and is moving towards 350k. we might see it with this release [23:15:09] prod's still moving the other way though :/ [23:32:44] bmansurov: https://phabricator.wikimedia.org/T95224