[08:11:01] g'morning y'all [08:19:03] mornin' pheudx [08:19:13] er, phuedx [08:19:26] mdholloway: you'll need tab completion to type my name [08:19:27] ;) [08:19:42] yeah, i'm not even sure how that happened... :) [15:30:29] joakino, phuedx: where can I test infinite scrolling? I haven't worked on that module before and I'm not sure where we use it [15:34:35] So far everything looks good, but that's the last thing I have to test to signoff T124870 [15:34:35] T124870: Consolidate scroll and resize event listeners - https://phabricator.wikimedia.org/T124870 [16:00:23] jhobs: seems like it is used in mobile.watchlist and mobile.gallery/PhotoList [16:00:31] not sure whre you can see those right now though [16:55:43] joakino: you wrote a javascript thing to add hundreds of non-existent articles to watchlists/gather lists, right? [16:55:45] ^ jhobs [16:56:22] phuedx: I've already tested it and signed-off, but that would be useful to have for the future! [17:23:46] woops unexpectedly closed haha [17:23:52] jhobs: jdlrobson ^ [17:24:10] joakino: haha that's fine, I'm gonna try to grab food in the 5min before the next meeting anyways [17:24:17] yep [17:51:07] how have i been living with the gradle daemon disabled all this time [18:10:43] lol [18:10:55] mdholloway|afk: actually i read that they're turning it on by default soon! [18:13:03] https://docs.gradle.org/3.0/release-notes [18:13:11] ^^^ next upgrade for us i think! [18:13:45] fwiw, here's the sum of my gradle config: [18:13:50] org.gradle.daemon=true [18:13:50] org.gradle.parallel=true [18:13:50] org.gradle.configureondemand=true [18:13:50] org.gradle.jvmargs=-Xmx3072m [18:14:29] i don't think you'll notice any gains from configureondemand in our project but i used to work in a project with many submodules where it was quite a bit faster [19:11:07] bearND dbrant mdholloway: o/ i'm going to publish beta round 2 if there aren't any objections [19:11:20] +1 [19:53:15] +1 [20:07:14] bearND: you available? [20:13:11] coreyfloyd: in a bit [20:13:23] bearND: ok - just ping me when you are [20:15:31] niedzielski: have a sec for an interesting bug in the new alpha ? [20:16:21] matanya: sure thing [20:16:33] דאגלס_אנגלברט on hebrew wiki [20:16:40] compare to https://he.m.wikipedia.org/wiki/%D7%93%D7%90%D7%92%D7%9C%D7%A1_%D7%90%D7%A0%D7%92%D7%9C%D7%91%D7%A8%D7%98 [20:17:15] jdlrobson: hey do you remember the purpose of introducing the 'content-unstyled' class to special pages? [20:17:47] bmansurov: nope. take a look at git blame. [20:17:58] also check with nzr whether that is indeed actually a bug [20:18:07] ok [20:18:28] what is content-unstyled? [20:18:35] matanya: geez completely mangled [20:19:36] yeah niedzielski want me to biscket backwords ? [20:20:12] matanya: you mean git bisect in the android repo? [20:20:45] niedzielski: kinda - no, i mean install previous version and see when it started [20:20:53] matanya: oh! [20:21:06] matanya: i think this is actually a content service vs mediawiki api issue [20:21:51] matanya: if you go to the app settings, tap on about, tap on the logo seven times it enables dev settings. in dev settings, you can force the mediawiki backend to be used and when i refresh after that the page appears correctly [20:21:58] nzr: it's one of the classess on the page list on special:watchlist [20:22:11] nzr: i pinged you on the task, can you reply? [20:23:50] cool thank niedzielski i will test that [20:25:11] bmansurov: i'll reply [20:55:53] niedzielski: i agree. wow, i guess that's the lead paragraph shift transform [20:56:41] bearND: i took some notes here T143358 [20:56:42] T143358: [BUG] Lead section contains all content on some pages - https://phabricator.wikimedia.org/T143358 [20:57:09] niedzielski: thanks, just noticed it on the MCS board [20:57:20] 👍 [21:11:32] hey mobile ppl, are you still using http://staging2.wmflabs.org/wiki/Main_Page ? [21:14:35] jdlrobson ^ you know? [21:15:07] mdholloway|afk: coreyfloyd ^^ in case apps consume it for some purpose [21:16:09] doesn't look like: http://staging2.wmflabs.org/w/index.php?title=Special:RecentChanges&days=3000&from=&limit=500 [21:16:11] i don't know. phuedx will. I think we are using reading-web-staging though no and not using that [21:16:58] MaxSem: i don't think we use it anywhere in androidland [21:17:01] it's running precise and needs to die. I'll stop it as a first step, and delete later if nobody complains [21:17:53] thanks [21:18:58] MaxSem: sounds like a plan [21:18:59] thanks [21:40:01] yeah, not in the Android app nor MCS [22:30:53] if anyone has time to review this task and see if it's estimatable that would be great https://phabricator.wikimedia.org/T122212 [22:31:01] will help me prepare for monday [22:33:25] jhobs: dr0ptp4kt ^ [22:47:26] bmansurov: are you running memcached ? [22:48:17] just want to check you read commit message in https://gerrit.wikimedia.org/r/#/c/305082/4 [22:50:56] jdlrobson, what's your strategy of deploying that? [22:51:37] MaxSem: hmm? [22:52:20] if it requires a cache reset on developers' machines, it tends to require the same in prod [22:52:42] you can't restart memcached in prod [22:53:55] MaxSem: i'm checking this is the case. If it is, I can invalidate the parent template. [22:54:23] there's an open bug about partials [22:54:37] https://phabricator.wikimedia.org/T113095 < this one [22:55:13] MaxSem, jdlrobson: we're using reading-web-staging, i wasn't aware of staging2 [22:55:22] read: DESTROY IT [22:57:48] jdlrobson: i'm not using memcached [22:58:02] bmansurov: are you using any kind of caching? [22:58:15] jdlrobson: yeah, i think default php one [22:58:17] the footer renders fine for me so there's something odd with your installation [22:58:22] try rebooting? [22:58:40] jdlrobson: restarting apache should fix it right? [22:58:51] it didn't [23:16:02] bmansurov: can you paste the html your seeing? [23:16:29]

[23:22:05] hmm can you debug some more? [23:22:17] for some reason the template data is not getting passed [23:22:35] also try my new patch which should remove the cache validation problems [23:22:39] bmansurov: ^ [23:23:05] ok [23:26:49] jdlrobson: the latest patch fixes the issue [23:27:27] ok so it was template caching fyi [23:34:57] jdlrobson: do you want to updated the commit message and remove the memcached bit? [23:35:03] jdlrobson: i'll merge after that