[06:50:09] niedzielski-afk: since very nearl all patches that we submit to gerrit are to do with some in-progress task, i.e. they have a Bug: stanza, then we don't usually manually add folk to patches [06:50:13] *nearly [08:16:12] morning o/ [08:18:54] joakino: ping pong [08:18:58] eat yer damned breakfast [08:19:09] (ice cream sandwich probs) [08:22:18] phuedx: joakino: good morning :-} [08:22:26] hey hashar [08:22:27] we had the first European SWAT yesterday at 3pm CEST and it all went well! [08:23:22] so if you happen to have patches, feel free to add them and we can deploy them together :} [08:24:40] ! [08:25:05] hashar: <3 <3 <3 i'll be available more and more in the coming weeks [08:25:10] * phuedx is still working part time [09:09:03] nice hashar, congrats! [10:50:56] out for early lunch [14:57:58] mdholloway: o/ hope you're feeling better. by the byte, do you happen to know where we're sticking the theme changer these days? do we have plans to put that somewhere? [14:59:46] niedzielski: yes, feeling better, thanks! i don't know what's ultimately planned for the theme changer. i don't think we have any immediate plans to change the toolbar action menu, though. [15:01:22] mdholloway: ok cool. i'll ping design and product on it. i suspect that if you didn't know it existed, you wouldn't miss it. and if you did, you probably already changed the theme to your taste. [15:02:38] reets nzr dbrant: o/ hello! i think we talked about possible places to put the android theme setting but i don't remember where we landed. are we planning to continue to offer the setting and if so, where? [15:24:25] hey niedzielski: afaik we are still keeping "Font and theme" as an overflow menu item in articles pages... We may also wish to add it to 'Settings', but I would say this would only make sense once we are able to apply font-size across the entire app (rather than at the moment only when reading articles) [15:24:45] ^ disclaimer: Nzr to confirm :p [15:25:23] reets: cool, i'm definitely for moving it to app settings or in with the font settings [16:21:40] joakino: there? [16:21:55] dr0ptp4kt: yarp [16:22:06] joakino: yo. so for the navigator.sendBeacon thing: [16:22:28] joakino: are you saying that the issue is isolated to hovercards? [16:22:48] joakino: or are you saying that you have DNT enabled, and thus navigator.sendBeacon is undefined? [16:23:01] i also noticed it says navigation.sendBeacon...did you mean navigator.sendBeacon? [16:25:26] dr0ptp4kt: yea, navigator [16:25:46] dr0ptp4kt: i think some extension is reoving sendBeacon [16:25:51] ublock origin or one of those [16:26:02] i don't think it is a problem with the code [16:26:47] joakino: ok, thanks. yeah, in my browser navigator.sendBeacon is always truthy, that is it's a function type not undefined [16:27:45] yeah [17:00:52] anyone else having trouble connecting to TI? [17:01:07] nvm, there it goes [18:01:59] maxbinder: omw [19:20:35] nick dbrant|brb [19:20:42] :( [20:36:01] jdlrobson: [20:36:06] https://phabricator.wikimedia.org/T140102 [20:36:29] jdlrobson: bearND ticket is updated with the JSON from the feed API -let me know if that looks good [21:42:17] coreyfloyd: that looks good to me [21:42:48] bearND: thanks [21:42:55] jdlrobson: is that good for you? [21:43:04] the rank is optional btw. Not sure if we really need it [21:43:27] I don't think the Android app actually uses it.