[05:10:25] nice words about the android feed :) https://twitter.com/Lambo/status/771424105488912384 [05:10:55] .... https://twitter.com/luis_in_140/status/769173311016185860 [06:27:35] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(proposals)#Add_selected_anniversaries_to_mobile_view [14:46:03] :] [15:52:50] phuedx, joakino bmansurov i'll get you access in the w0 config system. use with care [15:54:21] ok [16:03:11] thanks dr0ptp4kt! [17:31:05] massive confidence boost when i deliver my standup status with the law and order music playing in my headphones. makes me feel like everyone is thinking, "guys, this sounds pretty serious and also probably entertaining. let's pay close attention." [17:52:42] phuedx: hey still there? [17:53:01] https://wikitech.wikimedia.org/wiki/Nova_Resource:Reading-web-staging - can I drop reading-web-staging-2.reading-web-staging.eqiad.wmflabs ??I don't think we use it right. [17:53:04] ^ bmansurov [17:53:54] i think so [18:08:42] phuedx: bmansurov it appears to be up on http://login-reading-web-staging-3.wmflabs.org/wiki/Special:RecentChanges [18:08:44] weird [18:08:59] are we maybe using it for wikidata descriptions? [18:51:07] jdlrobson: i don't see .read-more-container in master, do you? [18:52:08] bmansurov: I don't follow. If you grep for `read-more-container` in master it's there [18:52:34] the in resources/ext.relatedArticles.readMore/index.js [18:52:35] jdlrobson: i'm inspecting the html code, and don't see it there [18:53:15] bmansurov: are you on a page with related articles? [18:53:48] and on desktop? [18:53:56] yep, i see, so since footer-content is present read-more-container won't be inserted according to the file [18:54:03] on mobile because i'm testing the minerva change you did [18:54:10] So the change from Jeff adds the read-more-container on mobile as well [18:54:23] then an existing style kicks in that's in the minerva stylesheet [18:54:59] It previously existed in an older version of mobile [18:55:06] ok i see [18:55:07] which we don't need to care about anymore [18:55:11] So the change I made I think we can safely do in master now if you prefer [18:55:16] and then merge Jeff's change [18:55:19] what would you prefer? [18:55:36] i'm happy to split out [18:55:45] since it's caused confusion it probably needs its own patchset [18:55:48] i can merge as is [18:56:05] do you think the style key without the file will cause any problems with RL? [18:56:54] jdlrobson: ^ [18:56:55] bmansurov: the only issue is if we want to turn on related pages in stable before we push the new footer [18:57:03] but i'm guessing that won't happen [18:57:13] jdlrobson: maybe we should delete the rule but keep the file? [18:57:16] just to be safe [18:57:26] why is that safe? [18:57:45] unforeseen issues when the file is missing [18:58:23] jdlrobson: or we should be explicit about not wanting the default style by overriding it [18:58:27] by setting the margin to 0 [18:58:45] we are being explicit by saying don't load the default styles for this skin [18:58:51] we do that in other places in MobileFrontend [18:59:09] ok, if that's the convention that good [18:59:15] than* [18:59:18] then* [18:59:29] https://gerrit.wikimedia.org/r/308221 < bmansurov [18:59:40] might be easier to keep in a separate patch in case we want to revisit that decision [18:59:59] e.g. if we decide to push read more before new footer we can just revert it :) [19:00:02] jdlrobson: do you want to update the other patch too? [19:00:14] i can cherry pick on top of it yes [19:00:28] cool [19:00:33] i'll +2 once you're done [19:01:55] bmansurov: done [19:01:57] i've +2ed jeff's [19:02:18] bmansurov: with the position fixed stuff did you test on some real devices? [19:02:43] jdlrobson: no, I don't have old reald devices [19:02:49] i vaguely remember some issues [19:03:20] do you have an old ios device? [19:03:26] jdlrobson: iOS 3 or 4? [19:03:40] i don't have one [19:03:43] i'll leave a note on ticket [19:37:39] In combination with MW 1.27.1, I've just installed the current MobileFrontend and which is working brilliantly! [19:38:00] And so I have a question: ... [19:38:49] Is there a special CSS file to apply changes? [19:39:56] And another question: [19:40:44] I would like to present a banner at the end of content page of a wiki, but only when Mobile view is in effect. [19:42:28] Can I check the existence of a certain JS variable, or maybe reading a cookie. I guess users state is remembered by a cookie when switching between Mobile view and Desktop. [19:42:58] Tuxedo: hey, you can try /User:[username]/common.css [19:43:03] [username] is your username [19:44:05] Tuxedo: for the banner you can check the existence of the 'minerva' class on body [19:44:16] that's the skin name used in mobile frontend for now [19:45:52] Ok. Thanks, the 'minerva' class should be a good way check and then display the banner or not by JS. [19:46:53] instead of common.css you could also use minerva.css [19:50:36] Do you mean I can create a MediaWiki:Minerva.css and apply styles there to override styles for the skin? [19:51:08] Exactly, where is the Minerva CSS stored? [19:51:54] Tuxedo: you'd visit /User:Tuxedo/minerva.css in your browser [19:52:07] and edit the page and add your styles there [19:52:10] style rules [19:52:48] Do you mean user styles that are specific to logged in users themselves? [19:54:19] Tuxedo: i think so [19:55:29] Tuxedo: you could also edit [MobileFrontendInstallDir]/resources/skins.minerva.base.styles/common.css [19:55:47] that would enable the rules for everyone [19:58:33] Ok. Thanks. Found it. The file is 'common.less'. I was searching the directories for a .css file, which was why I couldn't find it before. At least I now know where to make little changes if needed. [19:59:20] Again, it's a great extension! Perhaps the most important one there is right now! [20:03:00] Tuxedo: yup sorry, it's a LESS file [20:03:05] glad you like the extension [20:04:02] feel free to create tickets at https://phabricator.wikimedia.org/ if you find any issues with the extension [20:04:17] I tested a few mobile extension and there's no comparison! [20:04:59] Nothing I don't like about it so far but I'll create tickets when I think of something. [20:05:25] cool, thanks [20:09:40] Observing some first time users it wasn't instinctively apparent to them that the top field is actually an input field although it's written, because it doesn't look like a search field. But that's only a small graphic detail that can be changed with CSS. In any case, anyone who's been on Wikipedia mobile more than once would surely know. [20:36:06] bmansurov, or anyone still there, I have another small question: [20:36:46] I don't need a "Privacy policy" link on a certain wiki and in a regular Desktop-only implementation I would add #footer-paces{display:none;} in Common.css on a p/wiki basis to remove the part. [20:39:02] Now this gets a bit more complicated, because it needs to be done in footer.less, somehow in the "ul li, &.footer-places li { ..." block. [20:39:09] I guess. [20:41:06] Also, as I use the same MW-install for more than one wiki, and some may need a Privacy policy, which would make it necessary to check the domain host in an if-block. Then when upgrading, other things may go wrong, because the code has changed in the upgraded version. [20:42:17] All above said, are there any plans to allow for a MediaWiki:Minerva.css or MobileFrontend.css file that override existing CSS? [20:53:02] I meant I would apply a display:none; rule to #footer-places-privacy only and not #footer-places which would hide other things too. [21:46:46] Tuxedo: yeah, there is an alternative search bar in the beta mode, which you can enable in the settings