[08:07:55] morning [08:13:44] morning [08:13:45] o/ joakino [08:19:58] hi phuedx [08:29:18] how're you joakino? [08:30:53] everything is good :) [09:14:06] joakino: don't mind me, i'm just updating mwv [09:14:08] :/ [09:14:21] 💤 [10:09:17] phuedx: should i kill reading-web-staging-2 or should we wait for jdlrobson to check in [10:09:23] kill it [10:09:25] just do it [10:09:27] i'm not sure if we have anything special there [10:09:34] reading-web-staging-2 is inaccessible afaik [10:09:47] https://www.youtube.com/watch?v=ZXsQAXx_ao0 [10:10:01] yeah we haven't touched it since we moved to 3 [10:11:00] i'm setting up a test for T143334 [10:11:00] T143334: [SPIKE: 2hrs] Should we remove supportsPositionFixed and Skin#setupPositionFixedEmulation? - https://phabricator.wikimedia.org/T143334 [10:11:08] joakino: [10:11:14] what exactly should i be removing [10:15:20] this is awesome http://media1.giphy.com/media/jANPR3sjYUDWU/giphy.gif [10:15:25] phuedx: let me have a look [10:18:02] phuedx: are we testing on a real device or just executing the result [10:18:19] joakino: i've got an iphone and ipod 2 [10:18:35] i'm going to deploy a change to staging and test there [10:18:40] on a physical device [10:20:28] awesome, thanks [10:22:37] joakino: i'm in tracy, 5 minute chat to clarify details? [10:23:08] sure [11:43:53] yo again joakino [12:02:10] the old iphones take forever to boot 😡 [15:31:05] joakino coreyfloyd mdholloway bearND reading eng leads meet in 3 mins [15:32:22] yup [16:55:47] tgr|away: when you get in would you be able to approve my OAuth app? I need some new permissions. [16:57:14] jdlrobson: I can approve it now if you give me a link [16:59:14] https://meta.wikimedia.org/wiki/Special:OAuthConsumerRegistration/update/34d337ce3fa86ee258fa0583ed89f9c3 < tgr [16:59:21] assuming i can't edit the existing one to add permissions [17:33:38] tgr|away: was that all you need ? ^ [17:42:56] joakino: coming? [17:43:28] dr0ptp4kt: yep sorry [17:56:21] jdlrobson: d[4~one [17:56:40] ...done.... [17:56:50] sorry, missed the previous ping [18:18:53] tgr: whooops.. lost my secret [19:16:22] mhurd: https://www.youtube.com/watch?v=O61wJPNJgZQ [19:36:43] jdlrobson: you can generate a new secret without having to get the consumer approved again, just go to the page you linked, check "Reset..." and don't change anything else [20:15:23] niedzielski-afk: reported all the things we spoke about [20:15:41] matanya: thanks :) [22:14:27] jdlrobson: yt? [22:14:34] dr0ptp4kt: yip [22:14:40] jdlrobson: coming? [22:14:53] arggg for some reason i thought it was 3.30pm [23:08:48] bmansurov: i already fixed it :) [23:14:20] i -1'ed patchset 4, and gerrit decided to apply my change to patchset 5 [23:16:25] bmansurov: https://phabricator.wikimedia.org/T143425#2596618 [23:16:33] if that's true we should remove entire block no? [23:17:24] i'm not sure, i'm being cautious here [23:17:34] adam's last statement [23:27:22] bmansurov: that's not unrelated :) [23:27:40] How is the upload icon related to the edit pencil? [23:27:48] it shares the same code [23:27:57] sure it does [23:29:03] so why wouldnt you clean it up while there given it's trivial and makes your patch better and our code better? [23:29:42] because the patch is associated with a task and I want to fix the issue mentioned in the task [23:29:52] patches should be specific [23:29:55] that's very short sighted [23:29:59] not really [23:30:07] i should not mix concerns here [23:30:15] it just strikes me as lazy tbh as someone else has to do that [23:30:29] i'm not lazy, i'm trying to separate concerns [23:30:31] it strikes me that the bug is "Zero has a bunch of outdated code that breaks rendering for users" [23:30:38] this falls into the same category [23:31:05] as everything else you need to create a ticket first [23:31:09] and we've now spent as much time speaking about this as it would take you to amend [23:31:20] i won't amend it [23:31:32] because it's against our rules