[01:03:32] mobrovac: thanks! i'll give it another look first thing tomorrow and send. [02:58:52] jdlrobson: thanks for all the patches. You've been busy. :) [04:44:50] motivational piece regarding work on enabling mobile contributions ;) https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Contact_us_-_Press&oldid=738169448 [04:44:57] "Hi i am Rony from Bangladesh. I have some picture of chanchra siva mandir,Jessore,Khulna,Bangladesh and also articles. I want to give it to you but i am using a mobile phone and having problem" [16:02:53] bearND mdholloway: o/ so assuming jdlrobson's hatnote changes break the android app, are we versioning the api to rest_v2 or what's the plan for api breaking changes? [16:03:44] coreyfloyd jdlrobson coming to services sync? [17:03:09] maxbinder: [17:03:16] nzr: [17:03:20] STANDERP [17:03:28] phuedx: coming [17:21:41] jdlrobson: you coming back? [17:21:45] i've got about a minute [17:45:30] phuedx: i was wrong - width+height are in the style attribute [17:46:07] expressed in ex units [17:47:01] jdlrobson: of the maths images? [17:47:04] yeh [17:47:12] example: [17:47:13] [17:47:37] would it still make sense for it to have width/height attribues for performance reasons? I can't remember if css is sufficient [17:49:16] that might be one for the perf guys [17:49:29] iirc, it's better to provide attributes [17:49:38] but inline styles might be a thing [17:52:41] phuedx: i'm gonna do a follow up to https://gerrit.wikimedia.org/r/#/c/308909/ that digs around in the style attribute. Wish me luck. [17:52:50] godspeed! [17:55:42] nzr: bearND mdholloway so yeh... versioning / new endpoint ? [17:56:02] too scary? :) [17:56:17] jdlrobson: ? [17:56:26] sorry nzr that should have been niedzielski-afk [17:56:29] fwiw i dont consider the hatnote patch a breaking change [17:59:47] i saw the series of patches (exciting!) but haven't had a chance to look yet. i'll look now. i'm skeptical that any of them would warrant an api version bump. [18:00:12] mdholloway: they will bloat API response though [18:00:49] (until this happens > https://gerrit.wikimedia.org/r/#/c/309219/) [18:01:47] jdlrobson: yeah, that commit message stuck out to me as i watched the patches come in yesterday, what's your overall vision for the lead section? [18:01:58] i might be out of the loop from being on vacation [18:02:08] mdholloway: i just dont see why it's bundled in with the other sections in the array [18:02:10] given it's special [18:02:46] I think since it has so many key article concepts it could be broken up. [18:03:07] that said moving it is not a big deal [18:03:17] it was mostly motivated out of maintaining backwards compatiblity [18:03:46] it's just a minor inconvenience when parsing the api response [18:04:47] jdlrobson bearND mdholloway: i thought that removing the hatnote section from the lead section would cause us to display no sections in old versions of the app. so breaking in the sense of a loss of functionality, not in the crash sense i suppose [18:07:48] niedzielski: i'm not quite following -- how would removing the hatnote from the lead section cause us to display no sections? [18:08:08] mdholloway: sorry-- i meant no hatnotes [18:08:17] hmm, i guess these changes are looking a little more fundamental than they appeared at first glance [18:08:43] niedzielski: ok, that makes sense [18:08:54] and that would actually be a pretty substantial change for older clients [18:09:16] mdholloway: for example, check out disambig.js in the app. i don't _think_ that logic would work any more [18:09:48] good day [18:10:36] \o [18:11:13] niedzielski: yeah, it seems like that would be affected [18:11:16] lbertolotti_: hi there [18:11:28] hi [18:11:38] do you know someone who can solves this https://webchat.freenode.net/?channels=#wikimedia-tech ? [18:13:36] lbertolotti_: i'm not sure i understand. what's the problem? [18:22:57] mdholloway, compare the screenshots from my phone with the ones from your browser [18:24:21] lbertolotti_: i think you might have pasted the wrong link [18:24:59] https://phabricator.wikimedia.org/T137669#2483384 [18:25:13] aha, thank you [18:49:50] lbertolotti_: responded on-ticket [18:52:19] jdlrobson: are we working on the skeleton thing? [18:52:34] nzr: you should come to grooming :) [18:52:36] we're talkign bout it now [18:52:43] coming [18:53:05] niedzielski: needs rebase? https://gerrit.wikimedia.org/r/309376 [18:53:08] (not sure why) [18:53:27] whoops [18:53:56] dbrant_: done, thanks [18:54:35] mdholloway, I've answered you [19:09:53] Now, something else about the portals [19:10:00] Can someone solve this https://phabricator.wikimedia.org/T120238 ? [19:24:17] mdholloway, are you still there? [19:25:59] in a meeting, lbertolotti_ [19:29:14] pardon me, but has anyone seen FlorianSW recently? [19:34:38] pardon me, but has anyone seen FlorianSW recently? [19:34:43] oops sorry [19:38:17] lbertolotti_: regarding T120238 , it looks like there is work in progress on template styling that relates to this issue. but it's complex so it is taking some time. [19:38:17] T120238: Bug: Text/Alignment issues in certain portal pages - https://phabricator.wikimedia.org/T120238 [19:38:44] lbertolotti_: in any case it's not really an issue that the app or MobileFrontent can really address directly [19:40:18] s/MobileFrontent/MobileFrontend [19:40:25] mdholloway, ok so what is the best place for discussing this? [19:44:49] lbertolotti_: on irc, i suppose #mediawiki or #mediawiki-core would be appropriate. but rest assured there is lots of interest in seeing this happen. [19:46:17] JOIN #mediawiki [19:46:33] what's the command? [19:46:40] \help? [19:46:51] \help [19:46:56] help [19:47:12] lbertolotti_: you probably want /join [19:47:22] (use a forward slash / ) [22:19:28] hello does anyone template editing?