[15:11:21] <jhobs>	 how's everyone's Friday?
[15:34:18] <dr0ptp4kt>	 legoktm yurik i just sent an email re: zero portal. would you please take a look? there seems to be some breakage somewhere, i think related to the content model
[15:34:47] <dr0ptp4kt>	 jhobs: i'd say i can't wait for the weekend, but not yet :)
[15:43:33] <jhobs>	 bmansurov: anything worrying you that stopped a +2 on https://gerrit.wikimedia.org/r/#/c/309586/ ?
[15:46:25] <bmansurov>	 nope
[15:52:42] <legoktm>	 hello
[15:53:47] <legoktm>	 dr0ptp4kt: is there a bug filed for this? or only in email?
[15:54:04] <dr0ptp4kt>	 legoktm: i don't think so. lemme do that real quick...
[15:54:11] <dr0ptp4kt>	 i mean, there's only the email chain
[15:54:19] <dr0ptp4kt>	 i'll file a phabricator task
[15:55:21] <legoktm>	 ok
[15:55:40] <legoktm>	 dr0ptp4kt: how long do you think this could have been broken without no one noticing? a day? or a week? / when do you know it was last working?
[15:56:02] <legoktm>	 my change hasn't actually been deployed yet, so it can't be that
[15:57:23] <yurik>	 legoktm, hi
[15:57:31] <yurik>	 seems like jsonconfig hasn't loaded any models at all
[15:57:31] <legoktm>	 I suspect it was caused by https://gerrit.wikimedia.org/r/#/c/304306/
[15:57:34] <legoktm>	 yeah
[15:57:39] <yurik>	 https://zero.wikimedia.org/w/api.php?action=jsonconfig&format=jsonfm
[15:57:42] <dr0ptp4kt>	 legoktm: i want to say about two days ago or so i had observed zero-rating chrome, but i don't know
[15:57:53] <legoktm>	 makes sense, it would have gone out tues-wed
[15:58:29] <dr0ptp4kt>	 legoktm: yurik nice spot
[15:58:31] <legoktm>	 patch incoming
[15:58:32] <yurik>	 legoktm, do you know if anything depends on that patch?
[15:58:42] <yurik>	 if not, we can simply revert it
[15:58:59] <dr0ptp4kt>	 yurik: legoktm will the fix roll forward gracefully without corrupting data?
[15:59:10] <legoktm>	 revert will also break stuff
[15:59:15] <yurik>	 bummer
[15:59:21] <yurik>	 ok, i will try to repo it locally
[16:02:26] <legoktm>	 hrm hrm https://gerrit.wikimedia.org/r/#/c/303379/ Reedy are you around?
[16:05:53] <legoktm>	 yurik: [09:05:38] <grrrit-wm> (PS1) Legoktm: Check globals in addition to attributes [extensions/JsonConfig] - https://gerrit.wikimedia.org/r/309598 
[16:06:17] <legoktm>	 yurik: were you able to reproduce it locally?
[16:06:23] <yurik>	 legoktm, not yet
[16:06:30] <jhobs>	 phuedx|ooo: you around?
[16:06:35] <yurik>	 legoktm, my vagrant is having a field day :(
[16:06:44] <jhobs>	 he asks before reading the auto-completed IRC nick...
[16:06:47] <legoktm>	 dr0ptp4kt: do you have the X-Wikimedia-Debug extension installed?
[16:08:39] <dr0ptp4kt>	 legoktm: you talking about the browser extension? no, i don't. should i install that? also, do you need access to zerowiki?
[16:08:40] <jhobs>	 bmansurov: I'm getting ratelimited on local selenium tests of the talk feature. Have you ever run those tests locally and/or any idea on how to fix it? I assume it must be some config option for my vagrant instance
[16:09:32] <legoktm>	 dr0ptp4kt: well I was going to have you test it for me...
[16:09:46] <legoktm>	 if you could install it that would be nice
[16:10:03] <dr0ptp4kt>	 legoktm: will do. nice, bd808 wrote that hmm?
[16:10:34] <jhobs>	 bmansurov: right now my assumption is I need to put localhost in https://www.mediawiki.org/wiki/Manual:$wgRateLimitsExcludedIPs, but I figured I'd see if anyone else ran into this before
[16:10:43] <legoktm>	 see https://wikitech.wikimedia.org/wiki/X-Wikimedia-Debug
[16:12:06] <dr0ptp4kt>	 legoktm: installed it
[16:14:26] <yurik>	 legoktm, for some reason \ExtensionRegistry::getInstance()->getAttribute() returns nothing
[16:14:41] <yurik>	 for JsonConfigs
[16:15:46] <legoktm>	 dr0ptp4kt: okay, can you set it to use mw1017, and then see if things are better (won't be entirely fixed yet) on zerowiki?
[16:16:00] <yurik>	 still digging
[16:16:14] <legoktm>	 yurik: did you read my commit message?
[16:16:27] <yurik>	 legoktm, which?
[16:16:37] <legoktm>	 [09:05:38] <grrrit-wm> (PS1) Legoktm: Check globals in addition to attributes [extensions/JsonConfig] - https://gerrit.wikimedia.org/r/309598 
[16:16:53] <legoktm>	 I just deployed that to mw1017
[16:16:55] <yurik>	 legoktm, ah, yes, looking
[16:18:14] <dr0ptp4kt>	 legoktm: i see that https://zero.wikimedia.org/wiki/Zero:TEST1 is now rendering its content in the html-ized json
[16:18:22] <legoktm>	 ok
[16:18:28] <dr0ptp4kt>	 to logstash i go now
[16:18:41] <yurik>	 legoktm, the portal page is up again
[16:18:44] <yurik>	 on mw1017
[16:18:47] <legoktm>	 so my patch fixed it
[16:19:06] <yurik>	 legoktm, yes, the https://zero.wikimedia.org/w/api.php?action=jsonconfig&format=jsonfm seems to be good
[16:21:33] * legoktm twiddles thumbs waiting for CI
[16:21:41] <phuedx|ooo>	 jhobs: back
[16:22:15] <yurik>	 legoktm, +1ed
[16:22:21] <legoktm>	 not +2?
[16:22:27] <phuedx>	 jhobs: what can i do for you?
[16:22:31] <legoktm>	 I'll just self-merge it then I suppose
[16:22:34] <yurik>	 done
[16:22:36] <legoktm>	 thanks
[16:22:41] <yurik>	 i am slow today :)
[16:23:12] <phuedx>	 jhobs: want to hangout in tracy?
[16:23:51] <dr0ptp4kt>	 legoktm: yurik thx. i'll set a timer for 30 mins to check that action=zeroconfig and the other zero trappings come back for the end user experience. basically the set of json configs gets pulled via a linux job that lands in a database that varnish reads to enrich headers. "simple!"
[16:23:51] <phuedx>	 well, if you're around then lmk
[16:24:22] <legoktm>	 dr0ptp4kt: oh, I still haven't finished deploying it yet, it's only on mw1017. Should be everywhere in a few minutes
[16:25:09] <dr0ptp4kt>	 legoktm: thx. that job runs every 1-15 minutes or something like that, so it will be post deploy plus 15 minutes
[16:25:26] <dr0ptp4kt>	 legoktm: yurik i'll hop over to #wikimedia-operations now in case there's additional logging chatter
[16:29:40] <jhobs>	 phuedx: yes, i'll hop in tracy
[16:37:22] <legoktm>	 dr0ptp4kt: is that your home/cell phone? I typically don't pick up numbers that I don't know but I saw Minnesota so I thought it might have been subbu and picked up :P
[16:38:40] <dr0ptp4kt>	 legoktm: yeah, that's my cell, please do add it and feel free to double call and wake me up sometime if needed :)
[16:38:52] <dr0ptp4kt>	 (but do double call from your phone so dnd is suppressed :) )
[16:39:47] <legoktm>	 heh ;)
[17:28:09] <jdlrobson>	 bmansurov: okay if i write a phab task for the infobox work based on your analysis?
[17:28:12] <jdlrobson>	 i want to sign that off.
[17:28:23] <bmansurov>	 jdlrobson: sure
[17:28:27] <jdlrobson>	 ill ping you when done in case you want to make any edits :)
[17:39:55] <phuedx>	 jdlrobson: it might be more of an epic
[17:40:06] <phuedx>	 but that'll come after refinement
[17:40:09] <phuedx>	 anywho
[17:40:10] <phuedx>	 <3!
[17:41:13] <jdlrobson>	 bmansurov phuedx|ooo  https://phabricator.wikimedia.org/T145216
[17:41:20] <jdlrobson>	 and https://phabricator.wikimedia.org/T145219
[17:41:30] <phuedx|ooo>	 ta
[17:41:45] * phuedx|ooo disappears into the cloud
[17:50:09] <jhobs>	 see ya o/
[17:55:24] <bmansurov>	 jdlrobson: looks good
[18:44:24] <jhobs>	 jdlrobson: care to leave a comment on https://gerrit.wikimedia.org/r/#/c/309586/ so I know what to fix?
[18:49:32] <jdlrobson>	 jhobs: Sorry. My command line tool doesn't like '-' symbols arpparently. 
[18:49:46] <jdlrobson>	 done "It seems no-position-fixed can be removed now."
[18:49:54] <jhobs>	 I figured it was something like that
[18:56:20] <jdlrobson>	 bmansurov: in your spike testing removing positionFixed did you test drawers and toasts?
[18:59:11] <bmansurov>	 jdlrobson: i tested scrolling as it was the only thing happening there i think
[18:59:18] <jdlrobson>	 bmansurov: for references too?
[18:59:32] <bmansurov>	 no i did not test references
[18:59:49] <jdlrobson>	 we should probably test those quickly before merging @jhob's patch.
[19:09:44] <bmansurov>	 https://phabricator.wikimedia.org/T143334#2624054 jdlrobson
[20:00:35] <maxbinder>	 dbrant: et al 2 min
[20:13:36] <jhobs>	 jdlrobson: given the comments on the spike, are we all good to merge https://gerrit.wikimedia.org/r/#/c/309586/ then? The jenkins failures appear to be unrelated
[20:14:09] <jhobs>	 wanna make sure there's nothing you need me to iterate on before I wrap up for the weekend
[20:14:54] <jdlrobson>	 it's not going to merge until the jenkins failures are fixed (https://phabricator.wikimedia.org/T145227), but yes it looks fine.
[20:15:06] <jhobs>	 ok yeah, that's what i meant. Thanks!
[21:55:04] <JoshM_>	 hey just FYI we got a report on OTRS that the english mobile main page had been vandalized with a prono pic. it looks fine now, but you might hear about it from your users
[21:55:53] <Tuxedo>	 Near line 29 of menu.mustache on my version of MobileFrontend someone advised me is a place I can drop in for example a logo for it to appear just below in the Log in or log out button, as placing an image here is not a builtin option as far as I know.
[21:56:50] <Tuxedo>	 Ideally I would like to add the option of a logo here in LocalSettings as the wiki installation (1.27.1) along with MobileFrontend skin is used for more than one wiki.
[21:57:29] <Tuxedo>	 Alternatively, somewhere in the skin's PHP code I would add the site specific logo option depending on a $_SERVER["SERVER_NAME"] variable.
[21:58:48] <Tuxedo>	 Does anyone happen to have some advise on how and where this may best be done?
[22:00:53] <Tuxedo>	 Including any advise on what dimensions the image used should not be exceed in this particular place?
[22:09:57] <dr0ptp4kt>	 hi Tuxedo. you may want to ask on the mobile-l mailing list. you can sign up for that list at lists.wikimedia.org if you're not on it already.
[22:12:24] <Tuxedo>	 Ok. Thanks dr0ptp4kt