[07:58:35] o/ [08:45:43] vagrant destroying for fun and profit [15:50:45] * niedzielski is mr. fancy github ios contributor [16:00:53] joakino: i'll be a few mins late. please proceed without me [16:01:24] if anyone from the Reading Team might be interested in mentoring https://phabricator.wikimedia.org/T258 It'd be great, we can have it featured for Outreachy-13 then [16:02:02] it looks like an interesting one and *some* support is already there from Collab team [16:05:33] olliv: joakino bmansurov story prioritization :) [16:05:54] maxbinder: i'll be a little late [16:05:55] sorry [16:34:25] I got kicked out by hangouts [17:02:02] olliv: standup [17:02:10] ah ^ :) [17:13:01] dr0ptp4kt: thanks for your comments on https://phabricator.wikimedia.org/T136746#2648835 [17:13:03] you're righte [17:13:14] the setting is saved only on interaction with those dialogs [17:23:09] i'm going to have to re-evaluate the child task [18:28:02] @dbrant is the color task merged? [18:28:04] :) [18:28:13] nzr: sending you a build now... [18:28:26] that's awesome [18:34:26] bearND: r4r [19:46:10] dbrant: looking good! one more thing if we can pull it off. it's actually just 3 character change in a css file [19:46:27] a { color: #36c; } :P [19:46:44] blue links in articles should use the same blue as accent-color-50 [19:46:54] sorry for piling on [19:46:58] :-S [19:47:14] we can do it later if you want [19:50:22] nzr: we're currently inheriting the link color from MobileFrontend. It will take some nontrivial changes to override it (correctly). [19:51:01] oh wow.. i just wrote wrote that line in override.css in ios.. maybe i should tell them to do it properly now [19:51:40] nzr: if we're standardizing colors across WMF, we'd rather wait for MobileFrontend to get that color, then we'd inherit it automatically. [19:52:25] mobilefrontend will take time due to consultations :) thought mobilefrontend will be using new colors very soon. [19:52:45] but i was thinking of adding override and removing override when mobilefrontend switches to new color [19:53:13] that's basically like all the other alterations we do. things like lead images, hatnotes. [19:53:22] lead paragraph [19:55:44] though* [19:56:06] oh i meant will be using new colors except for article links* [19:57:19] nzr: did you just @mention someone on irc? [19:57:23] MONSTER [19:57:36] @phuedx why not? [19:57:56] nzr: and what about visited links? and external links? [19:58:19] dbrant: they stay the same. just the default anchor [20:00:00] niedzielski: mdholloway: bearND: are we go for Beta? [20:00:31] dbrant: nothing to block it on my end [20:00:31] dbrant: i found a small crash bug i think i have a pointed fix for. i should have it out momentarily [20:17:17] dbrant: nevermind. the bug is legit but the patch has to go deeper than i thought. i will make a fix but i think it'll have to wait until the second beta [20:26:26] niedzielski: is there a Phab ticket for the bug? [20:27:06] bearND: not yet. i don't think it's regression. it has to do with the feed making service requests and then not nulling out the callbacks. i'll post a bug in a bit [20:27:39] bearND: you should be able to repro it by enabled "don't keep activities" and tapping random quickly [20:29:36] bearND: i also learned something new about the fragment lifecycle which is that getContext(), not just getActivity(), has a limited lifecycle which i guess makes sense, although i'm not clear yet on how they differ [20:30:00] d'oh [20:32:00] * niedzielski one day i will fully understand the android fragment and activity lifecycles and maybe bash quoting [20:41:31] niedzielski: I don't know how to click on random quickly in a repeated fashion. You'd have to go up (back to) the explore feed and scroll down to the randomizer card to get another random article, which is suboptimal for people who want to look at several random articles BTW. [20:42:03] bearND: just tap it quickly [20:42:12] That part is a navigation regression, I think [20:42:45] niedzielski: ok, got it. You mean just tap the same card many times repeatetly [20:42:45] bearND: with regards to placement, that's tracked here T144850 [20:42:46] T144850: [Design] Random is missing from tab bar - https://phabricator.wikimedia.org/T144850 [20:43:52] thanks for the link [20:45:38] bearND: and i just made the one for the quick tapper: T146086 [20:45:38] T146086: [CRASH] Tapping random quickly can crash - https://phabricator.wikimedia.org/T146086 [20:46:40] niedzielski: i agree that the quick tapper bug is not a blocker for this release [21:11:21] melodykramer: o/ would you have time for a quick chat before EOD? [21:26:33] anyone remember's Tilman's IRC nick? [21:27:03] HaeB: ^ [21:27:24] thanks [21:27:50] HaeB: can you share a link where I can read up on the definition of "session depth"? [21:28:00] HaeB: I'm working on https://phabricator.wikimedia.org/T145388, fyi [21:33:14] niedzielski: is your nearby patch still a wip? Would be keen to help you wrap that up https://gerrit.wikimedia.org/r/309811 [21:35:56] jdlrobson: i'm afraid so. i had to skip 10% time for the beta [21:36:10] jdlrobson: i'm very keen to complete it as well [21:36:47] er the android beta we're working on, that is. so close! [21:39:12] niedzielski: for what it's worth it looks good and close to completion :) will be nice to get that logic out of the client! [21:40:19] jdlrobson: thanks, i appreciate the support! it was sparked by a fortunate overlap with another project. i hope to get it done soon [21:41:17] bmansurov: there's actually no canonical definition (yet), but in https://phabricator.wikimedia.org/T139319 we used the term both for the number of link interaction events during one pageview session, and for the number of pageview sessions (more precisely, distinct pageTokens) per browser session [21:43:33] ok, thanks HaeB [21:45:17] bmansurov: cool - btw which part of https://phabricator.wikimedia.org/T145388 are you going to focus on? [21:46:10] HaeB: I'm still evaluating the options as it's a spike. [21:47:54] bearND dbrant mdholloway|afk: ok, i think things are looking good. release notes are cooking in the usual place [21:54:30] looks good to me [21:58:51] niedzielski: finished with my tweaks [21:59:38] bearND dbrant mdholloway|afk: sweet. any objections to publishing? i'm just waiting on the results from the play console tests [22:17:42] bearND dbrant mdholloway|afk: since we're planning on a follow-up beta and this build won't be exercised by tsg, i recommend we hold off on an announcement email [22:25:20] niedzielski: quite sensible, i think [22:26:18] dbrant: cool. everything is set except the google test results [22:27:52] let's go for it! [22:29:26] dbrant: oh did you want to skip it? [22:29:56] niedzielski: i mean, go for it pending test results [22:30:20] dbrant: sounds good! [22:38:41] bearND dbrant mdholloway|afk: hm. the overflow menu in the first batch of screenshots looks off (i think it's in konkani). i can't repro locally unfortunately [22:39:12] bearND dbrant mdholloway|afk: false alarm. it's one of the list item menus and is correct [22:44:10] bearND dbrant mdholloway|afk: ok here goes [22:45:05] dbrant: hey! Could you point me at the phab task for private collection storage? [22:49:26] jdlrobson: you're likely referring to this: https://phabricator.wikimedia.org/T128602 [22:56:19] w00t. Yeah for beta release