[08:03:43] good morning y'all [09:31:25] morning [09:42:22] olliv: i've manually checked in staging master, and as anon that gets bucketed, when you log in and have hovercardsbetafeature off, you can get hovercards on because only the hovercardsbetafeature on case is respected, when it is false we fall through to normal bucketing [10:13:37] joakino: what do you mean by you can get hovercards on? [10:14:02] olliv: i'm writing detailed steps, we can discuss afterwards, give me a few minutes [10:19:14] olliv: here's the comment, lmk if it makes sense https://phabricator.wikimedia.org/T146017#2651782 [10:20:18] yup, makes sense [10:22:30] do we have a workaround? [10:25:40] olliv: my previous attempt seems too involved and was confused from other things, so I'm going to abandon it [10:25:59] we should define the exact behaviors that are happening that we don't want, like my last comment, and open those as bugs [10:28:51] ok, let's discuss during the meeting later - if we have 2 open as bugs, it makes sense, if there's more, I'd say we should just forget the whole thing, post a message to the community, and turn it on for logged-in users as original. (thing is, even in that case we'd have to fix the case you mentioned in the comments) [10:29:08] oki [10:29:23] should I rename that bug to be about my last QA test? [10:29:28] olliv: ^ [10:29:45] I'll do some testing in staging through the scenarios from https://phabricator.wikimedia.org/T136746 and note the ones that aren't functioning correctly before [10:29:54] cool [10:30:03] joakino re: renaming - sure [10:34:53] joakino, olliv: just restarting staging [10:34:57] also o/ [10:37:10] olliv: i've rewritten https://phabricator.wikimedia.org/T146017 with more detail and a test case, and changed the title, have a look when you can [11:04:30] joakino: nice write up [11:26:22] joakino: indeed :) also, tested both cases and commented - this happens both when hovercards are off by default and when you explicitly turn them off (by turning them on and off again) [16:05:24] joakino: tsg meeting [16:05:35] olliv: random test failure https://gerrit.wikimedia.org/r/#/c/311727/ 💩 [16:05:44] i shouldn't have edited the commit message [16:06:06] :(( [16:19:13] olliv: randomly passed this time \o/ https://gerrit.wikimedia.org/r/#/c/311727/ [16:34:53] niedzielski: thanks for the comments [no worries about getting on my case!] [16:34:59] niedzielski: how about I split off the lint fixes into a separate patch, and make a task for upgrading gradle (to be done after this release)? [16:35:07] (and rebase the crash fix unto master [16:35:19] dbrant: thanks, i appreciate you reaching out over irc! it's very kind of you! [16:35:26] dbrant: that'd be really great! [16:35:28] ;) [16:37:14] joakino: chaos! how often are we getting failures? (they seem sporadic) [16:38:28] olliv: it's really random, the other day it failed more than 5 patchsets in a row [16:38:40] olliv: this last patch is very lucky ;) [16:39:40] btw olliv i've mentioned in https://phabricator.wikimedia.org/T146035 which is a blocker to this last one task and is about the random test failures which are probably signaling random hovercards failures too [16:39:50] i think that one is high prio too [16:44:03] going to break for 10 [16:45:53] joakino: re: https://phabricator.wikimedia.org/T146035 sounds good, let's discuss during standup [17:01:45] joakino: phuedx standup [17:02:01] maxbinder: just finishing up my 1:1 w/ dr0ptp4kt [17:02:33] maxbinder: hangouts just kicked me out, one sec [17:02:54] not letting me back in... [17:03:05] gonna try a browser restart and/or different browser [17:03:59] weird... it's kicking me out as soon as I connect now :/ [17:04:12] you guys should start, I'll try restarting my computer and see if that helps [17:04:15] maxbinder: ^ [17:04:54] jhobs: k keep trying and email if you can't get in? [17:05:05] maxbinder: will do [17:23:08] phuedx: no deployment next week? so we won't see redirect changes next week? [18:49:11] dbrant: sent you the illustrations [18:49:26] nzr: got them, thanks! [18:49:39] will try to mock it up soon [18:50:35] (y)