[09:19:22] morning [11:19:43] hello! [11:31:09] hi olliv [11:31:42] olliv: the deployment train is on hold right now so the fix for the prod hovercard errors hasn't been backported or swatted [11:32:21] aaargh, any chance we can still get it in today? [11:35:23] ^ joakino? [11:38:15] olliv: will see, depends on what the normal train does [11:38:27] if it resumes normally there's a chance we can do a swat in SF time [11:39:17] olliv: no swats on fridays so either today or not at all [11:39:38] joakino: is the eurotrain halted? [11:39:42] ^ hashar [11:39:44] joakino: yeah, I know. Okay, let's see [11:39:55] euro train ? [11:40:00] mibad [11:40:05] olliv: i'm also wary of rushing the tests without having deployed the changes to prod for some days and tested, and at the end of the week before the no-deployments week [11:40:09] i mistook swats and trains for a second [11:40:18] that said, eurotrain sounds pretty good, non? :D [11:40:25] just a headsup [11:40:33] gotta check the status of wmf deply [11:40:41] i think we are going to skip wmf.19 entirely [11:40:46] wowzers [11:40:49] https://tools.wmflabs.org/versions/ [11:40:49] yeah [11:40:54] group0 is on wmf.20 [11:41:08] hashar: we've ported a fix to wmf.20 [11:41:30] are we responsible for submodule updates? [11:41:51] (i haven't done ^ this bit in a while) [11:46:36] joakino, phuedx: what would you suggest? [11:46:50] waiting a week [11:46:57] * phuedx always opts for caution [11:47:50] joakino, phuedx - any chance you guys are free to do a quick hangout? [11:50:34] sure, 1 sec [11:51:33] olliv: omw [11:52:14] olliv, joakino: tracy? [11:52:26] 👍 [11:52:32] sounds good [11:57:54] phuedx: wanna pair it over hangouts ? :) [11:58:11] I dont mind training you on deployment :D or just add it to swat [12:00:14] hashar: sure! sec! [12:05:51] hashar: got a hangout ready? [12:06:02] let me find headphones [12:06:12] ^ classic remote worker [12:06:17] ah [12:06:22] my kids are awesome [12:06:31] conveniently placed next to my desktop computer [12:06:36] <3 [12:06:47] my kids currently steal my headphones while i'm wearing them [12:07:12] phuedx: https://hangouts.google.com/hangouts/_/wikimedia.org/letsbreakmobile [12:07:19] ^ joakino [12:07:28] they have played with the webcam though [12:10:58] https://tools.wmflabs.org/versions/ [12:17:06] joakino: for firefox https://addons.mozilla.org/en-US/firefox/addon/wikimedia-debug-header/ [12:50:20] sorry hashar phuedx I was on the phone [12:50:26] gonna go for lunch now, it is getting late [12:51:33] later [12:51:35] o/ [13:50:51] phuedx: so if I'm understanding the tasks correctly, the hovercards A/B test config change is ready to be deployed, but only to wmf.20? [14:05:24] jhobs: that's a call for olliv to make, but yes, the config should be deployable [14:07:15] brb [14:07:55] @phuedx, @jhobs - let's wait till standup. we raised some concerns this morning on how sure we are that chaos won't ensue once we deploy, given that we won't be able to deploy any fixes next week. I'd like to get a few more opinions on whether it's a good idea or not [14:08:08] don't know what's up with the @...been on phab too long today [14:09:02] Cool ok, thanks for the info phuedx and olliv [15:34:27] did the phab ui move the scrollbar from the window to the column or has it always been that way? [15:40:16] dbrant: o/ hello! i'm kind of following up on some reviews at the moment but once i'm done with that, the beta is just pending merges. as part of the toolbar tweaks, do you want me to pursue T144318? (discussion here https://gerrit.wikimedia.org/r/#/c/312059/ ) [15:40:16] T144318: [Dev] Upgrade Android Support Library to v24.2.1 - https://phabricator.wikimedia.org/T144318 [17:30:14] phuedx: can you remove your -2 from https://gerrit.wikimedia.org/r/#/c/310483/ before you head out for the day? It's no longer blocked [18:02:27] maxbinder: i know this guy. goes around sending people broken jpegs. you know anything about that? [18:07:08] niedzielski: there's no jpegs here: https://media.giphy.com/media/l2JJKs3I69qfaQleE/giphy.gif [18:07:23] maxbinder: phew! i can breathe again! [18:08:34] maxbinder: i'm glad you resent it. it's pretty funny :] [18:09:48] maxbinder: https://phabricator.wikimedia.org/T139210#2658567 [18:09:54] "No more logging in T103700." [18:09:54] T103700: LOG: Phabricator project creation - https://phabricator.wikimedia.org/T103700 [18:09:59] i guess it's only a proposal at this point [18:10:42] jdlrobson: far out thx [18:36:49] niedzielski-afk: maxbinder: it was doubly funny for me because i disable auto-image downloading in gmail, so it went from broken to broken [18:36:55] excellent trolling, had it been intentional [18:37:17] it went from broken to broken *after i selected to download images [18:38:24] mdholloway: your life sounds complicated [18:38:46] maxbinder: nah [18:38:54] maxbinder: simplicity through complexity [19:09:16] jhobs: so https://gerrit.wikimedia.org/r/#/c/311148/ is not needed? Is the sampling rate already set in config? [19:09:35] also phuedx can you remove your -2 on https://gerrit.wikimedia.org/r/#/c/310483/ ? [19:10:05] jdlrobson: 311148 just sets the default sampling in extension.json to 0 [19:10:17] the config patch makes the default for all wikis 0.1 [19:10:38] and then the appropriate numbers for the new wikis [19:10:53] Well I'm only comfortable swatting a config patch today [19:11:04] to minimise things that can go wrong [19:11:34] but are we okay with the sampling rate being 0 on Hungarian Wikipedia and other wikis in the mean time - I'm not sure if this matters ? (cc olliv ) [19:11:46] (actually won't this turn off sampling for everyone in beta too?) [19:12:06] mdholloway: lol! [19:12:17] "simplicity through complexity" [19:12:49] jdlrobson you mean just for hovercards, right? if so, yeah, that's fine [19:12:55] jhobs: wait ignore [19:13:00] gerrit was hiding patchset 2 from me :) [19:13:13] that makes much more sense [19:13:33] so yeh looks like we're good to go for today's SWAT -> https://wikitech.wikimedia.org/wiki/Deployments#Week_of_September_19th [19:13:47] jdlrobson: gotcha. Yeah the MF patch can just ride the next available train [19:14:09] jdlrobson: just wanted to be clear that it should get a +2 after the deployment and before resolving the task [19:14:27] sure np i'm just interested in what to SWAT right now [19:24:28] jdlrobson: so everything makes sense? (re sampling rates) [19:37:18] @dbrant latest beta? [19:54:01] olliv: correct [19:56:12] niedzielski: https://phabricator.wikimedia.org/T146411 found one more fix we can do to visually make the tabs light [19:57:21] nzr: nice [19:57:32] nzr: actually i was wondering if the padding is right on those guys too [19:57:50] yeah.. let me verify that [19:57:53] nzr: there's some variation in the material design spec [19:58:05] nzr: i was looking at this: https://material.google.com/components/tabs.html#tabs-specs [19:58:22] yep.. let me put it on top of our tabs and see [19:58:26] we need to get it right :D [19:58:31] nzr: i mean, it's fine to deviate, of course. as long as we're doing it consciously [20:06:25] jhobs: are you grooming today? [20:08:58] @niedzielski seems to be correct. it's the font weight. it should be regular. not bold https://usercontent.irccloud-cdn.com/file/ONzhamYd/ [20:15:33] nzr: well geez! it looks on my device, i swear! i'm working on the same overlay right now [20:16:23] oh really? let me use another device to test [20:19:44] nzr: i think i have these overlaid right: https://sli.mg/7DF1K4 [20:21:08] oo look at the smaller wikipedia wordmark. fits perfectly? [20:21:53] nzr: i suppose so! this is on top of dbrant's patch from earlier [20:22:37] nzr: and i hope you like the settled upon background in the feed. fwiw, i think it looks great (i also like the last one, as i mentioned in that email) [20:23:28] yaeh.. i told @dbrant bottom bar is mor eimportant right now. so let's change our focus inlight of new information :) [20:25:39] nzr: i really liked that lighter weight globe you had in one of the mocks. i hope that makes its way into the app [20:26:05] niedzielski: yeah i know. we are trying to unify explore into a brand. so we can have a consistent explore branding across platforms [20:49:43] maxbinder: sorry max, had my head down and missed your message [22:00:29] maxbinder: hey, how do I search for tasks that are marked with all tags in the search query at https://phabricator.wikimedia.org/search/query/advanced/? Something like MobileFrontend and Easy. [22:01:00] bmansurov: fun fact - Phab has 2 Advanced Search modes [22:01:07] tell me more [22:01:19] bmansurov: this is the one you want: https://phabricator.wikimedia.org/maniphest/query/advanced/ [22:01:46] maxbinder: cool, how can I navigate to that page from the home page? [22:02:19] On phabricator.wikimedia.org, unless you have changed your menu, you click "Maniphest" and then "Advanced Search" [22:02:29] maxbinder: great, thanks! [22:02:45] can anyone pass me the latest beta :) @niedzielski :) [22:03:09] nzr: sure. you just want what's been merged so far? [22:03:17] yep [22:05:36] nzr: it's on the way :] [22:06:07] 🔥🔥🔥 [22:06:16] straight from the oven [22:07:27] hot and fresh out the kitchen [23:07:54] hey olliv been having irc issues due to netsplit [23:08:06] but we are deploying in #wikimedia-operations within next hour if you want to join [23:13:55] and im back yay [23:28:30] jdlrobson: welcome back! I'm still awake [23:54:18] olliv: looks like we are okay [23:54:29] i was seeing some weirdness where i was seeing hovercards all the time [23:54:37] but that looks like it was probably a caching issue [23:54:53] yeh, just saw, I can't seem to see them at all... [23:55:08] but I think I might not be getting bucketed and should try more times [23:55:11] well.. remember the sampling rate is 1% :) [23:55:17] so you've got a 1/100 chance [23:55:52] olliv: also there's caching at play here [23:55:56] ....I tried many times [23:55:58] i'll write this all down in the ticket for you tomorrow [23:56:01] just got one though [23:56:12] I think we're okay [23:56:13] yeh that will be cache related [23:57:22] hmm, okay [23:57:23] localStorage.setItem( "PopupsExperimentID", "966facd00261c8e4" ) [23:57:34] olliv: you can run that JavaScript in your browser console on Italian to see hovercards