[08:07:26] morning [10:34:11] morning! [15:07:00] matanya: o/ sorry for the late response. if you mean T146044, it's in our current sprint which ends a week from friday. hopefully soon :] [15:07:04] T146044: [BUG] Alpha builds are not being published - https://phabricator.wikimedia.org/T146044 [16:00:48] jdlrobson: joakino kickoff [17:16:52] bearND_: JoshM_ coreyfloyd reets standup [17:17:12] dbrant|brb: ^ [17:17:28] maxbinder: i'm already here [17:52:05] olliv: heads up, I reorg'd the backlog to reflect transition to new quarter and current sprint, sprint +1 etc [17:52:29] ah! perfect, thank you! I was gonna do that [17:52:35] also, I'll make 83 [17:52:41] and can tag sprint+1 with that [18:12:12] olliv: cool. The column with Q2 in it is fresh. The old Current Sprint/Q1 column is archived as a record of all the work done in Q1 [18:19:26] cool, got it [18:29:19] @niedzielski @mdholloway @dbrant|brb do you know if it’s possible to pass Chinese language variants to api.php for search? even with the accept-language header set, the results are always traditional (for more context, check out the last two comments here: https://phabricator.wikimedia.org/T134967) [18:33:26] niedzielski: apart from the bugs the bottom bar behavior looks good [18:34:42] joewalsh: o/ i think we specify an Accept-Language header in androidland [18:34:45] nzr: sweet [18:35:06] joewalsh: (looking now) [18:35:38] joewalsh: honestly i don't remember off the top of my head how we handle that, looking now as well [18:42:01] joewalsh: i think this is working in the android app. when i search for 冰淇淋 (ice cream), with zh-hant i get the traditional page and zh-hans gives simplified. i'll start digging into the requests a little to provide more insight [18:42:22] https://zh.wikipedia.org/zh-hans/%E5%86%B0%E6%B7%87%E6%B7%8B https://zh.wikipedia.org/zh-hant/%E5%86%B0%E6%B7%87%E6%B7%8B [18:43:09] joewalsh: it might be good to ask the reporter for a very precise example or two [18:48:33] @niedzielski on the iOS app I fixed the article display - the accept-header works for that. the problem is with search results from api.php - they still show up as traditional. [18:48:34] joewalsh: ah, i see the hair example in the comments [18:48:45] joewalsh: hm [18:49:00] joewalsh: if you look at the simplified page url, it's also in traditional [18:49:22] joewalsh: 头发 redirects to 頭髮 [18:50:59] niedzielski: joewalsh: can confirm in the android app i'm getting search results in simplified chinese when simplified chinese is the app language. from the debugger it looks like we're just using accept-language as stephen mentioned. [18:51:32] mdholloway: for the specific hair example, i think we're having the same problem though? [18:52:07] for example, searching 中国 produces all simplified results (except that the first result is the traditional version of 中国, which is a little weird, though it indicates as much) [18:52:17] it indicates it's a redirect, that is [18:52:22] i'll try the hair example [18:53:00] ^ what i mean to say is the first result is a redirect to traditional version of 中国, if it wasn't clear [18:54:59] https://usercontent.irccloud-cdn.com/file/2T3FcMuo/hant.png https://usercontent.irccloud-cdn.com/file/A13FQTF5/hans.png [18:55:37] mdholloway: hm, i guess hair is... working correctly? [18:55:58] mdholloway: ^ there’s what I get for 中国 on hant vs hans - the titles are the same but the descriptions are different. On the Android app, are the titles different as well? [18:56:05] mdholloway: sorry, i'm don't r/w chinese, "simplified" or otherwise :) [18:57:36] joewalsh: niedzielski: it seems like we might just need to further refine how we handle redirect results in the special case where we're dealing with zh variants. i don't think we're doing anything unexpected from technical perspective now [18:57:47] joewalsh: one sec, i'll check both ways [18:58:59] joewalsh: so you want 中国 (simplified query) to give traditional results when the language is set to traditional? [18:59:36] joewalsh: or i guess you're just highlighting that the results are always traditional [19:01:04] I think the desired behavior is that regardless of the query, the results match the preferred language variant. But it seems in actuality, the titles are all traditional, so it might not be supported. [19:01:38] yeah i think i'm seeing the same thing for the zh-hans/t test of 中国 [19:01:42] on android [19:02:00] the description is "Redirected from 中国" [19:02:10] and the title is traditional [19:02:20] (even though the app language is hans [19:05:15] joewalsh mdholloway: https://sli.mg/esFGLa [19:05:16] joewalsh: the titles aren't all traditional, though, in your screenshots; only the first one (the redirect) is. otherwise they're all traditional (even for hant) [19:06:08] joewalsh: (do you have the image filenames reversed, btw? oddly, it looks like the descriptions are using traditinal in hans.png and simplified in hant.png) [19:06:37] niedzielski: joewalsh: i know barely any chinese, btw, just enough to know what the differences are for some of the super simple characters [19:07:08] mdholloway: does my screenshot jive with what you're seeing? [19:07:37] niedzielski: yep [19:08:00] joewalsh: whoops, at 3:05 i meant "otherwise they're all simplified" [19:08:38] mdholloway: good catch - on closer inspection there are differences in the titles. the screenshot names may be reversed, i’ll re-run the test to tell. [19:08:46] which makes sense (i think) if the search is keying off the prefix of those specific chars. [19:10:13] i'm not sure but i think either (1) zhwiki has separate entries for both the simplified and traditional versions of the same word or (2) it varies the content based on accept-language header in a way that the api treats as equivalent to (1) [19:10:31] zhwiki is kind of a strange and complicated beast [19:13:01] mdholloway: you were right, the screenshot names were switched [19:13:15] mdholloway & niedzielski: thanks for all your help! [19:13:58] 👍 [19:16:33] joewalsh: no problem! [23:08:02] @niedzielski new beta? wanted to sign off on the close button on articles [23:08:35] nzr: sure, i can send you the latest merged code as an alpha [23:08:43] (y) [23:08:45] cool [23:16:04] @niedzielski hey this open article in new tab, it's doing this animation which is really scary :O [23:16:32] everytime i open new article. i was confused but it looks like it's doing the animation when opening in new tab [23:16:53] nzr: hm, what's the expected behavior? [23:17:13] it should just open the way it used to. but should be a new tab behind the screen [23:18:17] nzr: so i believe this is the way it used to open new _tabs_. you want it to behave identical to the old behavior of opening new _pages_? [23:19:20] in terms of the animation, i mean [23:26:46] yes. we can't show the animation but it's very confusing what's happening. i knew what was happening still i didn't know what was happening. i thought i broke it :P [23:26:56] @niedzielski talked to dmitry too [23:29:10] nzr dbrant: cool, i'll file a ticket it and it to the current sprint [23:29:23] niedzielski: yeah. it's super imp. thanks! [23:29:35] super imp because it affects everyone. tab users and non tab users [23:35:21] nzr: T146721 [23:35:22] T146721: [BUG] Opening a new page should have a simpler animation - https://phabricator.wikimedia.org/T146721 [23:35:32] thanks [23:35:36] np [23:54:28] @niedzielski hiding tabbar went away in alpha you gave :( [23:54:29] i liked it [23:54:40] nzr: that patch isn't merged yet [23:54:43] nzr: still wip [23:54:52] i guessed