[01:25:45] jdlrobson: i guess we can fix it this sprint, if we don't i am 100% sure we will never get back to it [10:33:08] nzr, jdlrobson: I think it makes sense to keep in the sprint only if it's a trivial fix, otherwise let's throw it out. nzr: we can up the priority and pull it into next sprint if necessary [14:17:06] dbrant: yo, just getting in from a.m. dr's appt, i'll get on those patches [15:36:08] mdholloway: coreyfloyd tech leads sync [15:40:33] dr0ptp4kt: I’m not feeling well… going to take a sick day… sorry for the late notice. Will fill out the etherpad [15:42:17] thx coreyfloyd, sorry to hear it [15:43:09] olliv: you mean 82? [15:46:20] nzr: this sprint = 82, next sprint = 83 [15:52:32] @olliv sorry. android is on 92 hence the 2-3 confusion :) [16:04:40] i'm not sure about autohiding the nav bar in general but for landscape it's heaven sent! [16:06:50] olliv: joakino jhobs jdlrobson grooming? optional [16:07:04] tgr|away: i marked 'no updates' for reading infra on scrum of scrums. that said, any newer updates? [16:07:09] maxbinder: i'm watching the new readers meeting [16:10:30] dr0ptp4kt: I was thinking we could add a last call for comments about the new APIs [16:10:44] tgr: great, would you please add that? [16:11:22] sure [16:28:07] dbrant mdholloway|afk bearND: i did some prelim testing and the app looks pretty good to me. i'm going to move forward with the release now if that's cool [16:28:41] i'm excited about real folks trying out all these design changes in particular [16:36:29] +1 [16:37:24] niedzielski: maxbinder : I'll have to skip standup today. I've sent in my status via email. [16:38:37] niedzielski: thanks. good luck at the doc. as an adult, i'm grateful for the countless visits my parents my parents made with me [17:01:41] bmansurov: standerp [18:09:53] jhobs: how are you getting on with the footer work. Any difficulties that I can help with? [18:10:36] jdlrobson: no I think I've figured it out. I'll let you know if I run into anything. [18:10:57] i was careful when i made it to make this as smooth as possible [18:11:12] In theory all you need to do is drop the isBeta flag [18:11:35] (in includes/MobileFrontend.hooks.php) [18:12:01] sorry not that one [18:12:53] In SkinMinervaBeta getSkinStyles [18:13:08] the if statement isFooterV2() should be moved to SkinMinerva [18:13:10] and it then should just work [18:13:18] backwards compatibility as well [18:14:02] jhobs so if you're finding it a bit more tough - please do reach out - you might be doing more than you need to [18:22:16] jdlrobson: thanks, the problem was a browser test though that was failing for unrelated reasons and took some time to diagnose. Now it's the testing due diligence [18:24:37] joakino: yt? [18:50:49] nzr: The last modified bar in Minerva is currently using a green when active [18:51:42] nzr: (green background, pretty much in your face) Is that like you want it to be? [19:02:35] @Volker_E not really. the ideal was to have it background #fff and text #36c. but that requires icon color change when recent change is new vs old [19:06:22] nzr: great, I thought so :) [19:06:54] @Volker_E there are two variations of that banner. one is subdued into the background because the change is pretty old. [19:06:59] nzr: which icon, in my local install I don't see what you're pointing at [19:07:10] you can turn on beta to get new footer [19:07:18] or try it on english wikipedia [19:07:24] turn on beta [19:08:48] nzr: aaah [19:09:33] nzr: well, even when it's set to active the icon doesn't adapt [19:09:54] nzr: so a color change wouldn't really make anything worse [19:10:07] @Volker_E wait.. it does.. it's a backend change. it won't adapt just by adding a class [19:10:11] it changes to white [19:11:02] @Volker_E visit a popular page which has been recently changed. [19:12:49] https://usercontent.irccloud-cdn.com/file/c88fkRQC/Last%20modified%20bar%20-%20Wikipedia%2C%20the%20free%20encyclopedia%202016-09-28.png [19:13:08] that's what I'm looking at when just changing the class to active [19:20:39] nzr: ah, ok [19:20:50] nzr: got the server implication [19:21:26] nzr: nasty, but doable [19:23:10] It's done. Not doable :) just need to change the hex. I will send you zeplin in a while [20:22:52] niedzielski: finished with my notes [20:23:37] Volker_E: that's not true [20:23:52] the active class only gets added by JS and the icons should also change when that class is added [20:24:21] Volker_E: see https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/9657a061bedda3cdf0e40c87f55952d75065b790/resources/skins.minerva.scripts/init.js#L339 [20:24:39] (so dont manually add the class 'active' and expect it to work) [20:26:20] dr0ptp4kt: 5 min late, need bio break [20:26:56] maxbinder: word. health first [20:31:42] dbrant nzr mdholloway bearND: release notes look good to me [20:32:19] +1 [20:38:01] ++ [20:39:26] niedzielski: dbrant: bearND: by the way, that was actually me who sent that email with the APK and i'm not trying any funny business... :/ [20:39:58] (bearND said gmail is giving it a big red id theft warning) [20:39:58] lol [20:40:05] for me too :] [20:40:06] lol yeah, don't know what was up with that [20:40:13] can you *really* trust mdholloway's cloak? ;) [20:40:34] send us a photo of you holding up the apk [20:41:57] lol [20:49:37] dbrant nzr mdholloway bearND: starting google alpha tests (which have never failed). will publish when test results come back \o/ [21:05:40] jdlrobson: I saw that and understood what nzr was pointing out to me after looking at a popular page [21:06:01] jdlrobson: changed my response with “got the server implication” above [21:09:48] bearND: https://phabricator.wikimedia.org/T145003 [21:09:58] Volker_E: sounds good! [21:16:47] dbrant nzr mdholloway bearND: publishing :] [21:16:57] \o/ [21:24:38] jdlrobson: responded [21:24:55] niedzielski: \o/ [21:29:01] dbrant: i've updated the "upcoming" amazon apk as per usual. i know mapbox has been failing on their emulators but i recommend giving it another go, in light of the faketouch problem, once the candidate is promoted. if it fails again, hopefully T146776 will fix it [21:29:02] T146776: Upgrade Mapbox SDK to v4.2.0 - https://phabricator.wikimedia.org/T146776 [21:29:29] niedzielski: cool! let's do that [21:50:01] thanks bearND . So I had this thought around versioning - https://gerrit.wikimedia.org/r/309165 [21:50:24] it allows me to tinker with things and show you want I would like the service to become without releasing it into the wild [21:50:39] lemme know your thoughts on that approach [21:53:44] how do I add site notice to bottom of page in mobile view? [21:54:02] or any kind of notice whatsoever [22:00:05] niedzielski: dbrant mdholloway|afk bearND yay! [22:00:40] nzr: indeed! [22:01:44] i think the overhaul ended up being a perfect follow up to the feed work last quarter. i am excited to see how next quarter goes! [23:12:52] @niedzielski-afk @dbrant https://usercontent.irccloud-cdn.com/file/OPWnQVow/%20sorry%20for%20fixing%20bugs%3F%20%3A)%20hehe [23:20:36] oh wow.. he edited the review :) gave 5 stars