[08:45:40] <phuedx>	 o/
[16:43:08] <jhobs>	 anyone else experiencing issues with mw-vagrant after a git pull?
[16:43:43] <jhobs>	 I'll explain more at standup bmansurov, jdlrobson, phuedx, joakino, but if any of you have also been having issues (and have resolved them) please let me know
[16:43:52] <jhobs>	 Getting a class not found error in core
[16:48:52] <dbrant>	 niedzielski: mdholloway: bearND|afk:  crashes seem under control \o/
[16:49:05] <niedzielski>	 dbrant: that's what i've been seeing as well
[16:49:12] <niedzielski>	 dbrant: much relieved!
[16:50:01] <mdholloway>	 dbrant: niedzielski: excellent.
[16:52:21] <bearND>	 very good
[17:22:31] <mdholloway>	 jhobs: not sure if you got this worked out yet but i had to ssh into vagrant and do a composer update this morning
[17:23:03] <jhobs>	 mdholloway: in the middle of re-provisioning for the millionth time, but if it's still not resolved that'll probably be very helpful, thanks!
[18:12:20] <jdlrobson>	 bearND|afk: https://gerrit.wikimedia.org/r/313445
[18:12:28] <jdlrobson>	 your code styling woes are over
[18:27:22] <niedzielski>	 jdlrobson: i saw you used jscs. just curious if there is any reason to prefer it over eslint (there is some precedence for it: https://github.com/wikimedia/eslint-config-wikimedia)? i've been using eslint and some plugins in personal projects and loving it
[18:27:40] <jdlrobson>	 jscs came before eslint
[18:27:47] <jdlrobson>	 and it's what we're using on all our other projects
[18:27:52] <jdlrobson>	 eslint and jscs have both merged now
[18:28:01] <jdlrobson>	 but eslint hasn't got all the coverage jscs has.. yet
[18:28:16] <jdlrobson>	 so more to keep consistency with other projects and style guides
[18:28:56] <niedzielski>	 jdlrobson: hm neat about the merging. it's really great to see the projects working together
[18:30:02] <jdlrobson>	 niedzielski: fyi https://phabricator.wikimedia.org/T118941
[18:30:25] <niedzielski>	 jdlrobson: neat! thanks :]
[18:40:58] <jhobs>	 jdlrobson: thanks for the review. Re-provisioning vagrant right now but I'll implement your changes after it's done (and will hopefully be able to actually test it this time). Question though: are we certain .hlist-separated isn't being used anywhere else where it shouldn't have the styling like the footer?
[18:47:36] <jdlrobson>	 yup cos i invented it :)
[18:47:53] <jdlrobson>	 but i saw certain places we could refactor and reuse
[18:48:08] <jdlrobson>	 jhobs the diff and possibly the main menu and tabs
[18:48:19] <jdlrobson>	 so that's what i meant by my vague comment about moving it
[18:48:24] <jhobs>	 jdlrobson: ok cool, just double checking
[19:36:53] <bearND>	 jdlrobson: Yeah. Thanks! I like getting more eyes from some JS pros on this.
[19:48:25] <Deskana>	 dbrant: You may like this one: https://phabricator.wikimedia.org/T147021
[19:48:40] <Deskana>	 dbrant: I've been trying to take a look at fixing it myself, but I'm kind of lost where to start.
[19:48:54] <Deskana>	 JoshM_: ^
[19:50:28] <Deskana>	 There don't seem to be friendly methods for this kind of stuff in PHP.
[19:53:53] <mdholloway>	 Deskana: I think there's already a task out there for that...
[19:54:04] <Deskana>	 mdholloway: Oh! I tried looking for it briefly but couldn't find it.
[19:54:19] * mdholloway digs
[19:54:23] <Deskana>	 mdholloway: I only checked the TextExtracts component though...
[19:54:32] <Deskana>	 mdholloway: If it's not tagged against TextExtracts then I would've missed it.
[19:55:39] <mdholloway>	 Deskana: https://phabricator.wikimedia.org/T126331
[19:56:19] <mdholloway>	 yeah, not tagged with TextExtracts
[19:56:31] <Deskana>	 mdholloway: I'll merge them.
[19:56:50] <mdholloway>	 although to be fair it seems to me less a bug in TextExtracts than a template problem and a case of garbage in, garbage out
[19:56:51] <Deskana>	 mdholloway: Thanks!
[19:57:15] <mdholloway>	 Deskana: np!
[19:57:29] <Deskana>	 mdholloway: Yes, I think there's truth to that. That said, TextExtracts showing hidden content does seem to be an error...
[19:57:45] <Deskana>	 mdholloway: It shouldn't be there in the first place, but given that it is, TextExtracts shouldn't show it.
[19:57:54] <mdholloway>	 Deskana: yeah, probably true.
[20:02:25] <mhurd>	 mdholloway: dbrant: niedzielski: bearND: hey quick question - are you guys only using "m." domain for "action=zeroconfig" or are you using it for other requests too?
[20:02:48] <mdholloway>	 mhurd: just for zeroconfig requests at this point
[20:03:38] <mhurd>	 mdholloway: cool thanks!
[20:03:56] <mdholloway>	 mhurd: no problem! 
[20:07:20] <maxbinder>	 bmansurov: jhobs jdlrobson grooming today? olliv is sick, but always something to groom
[20:08:23] <jhobs>	 maxbinder: I can join
[20:58:23] <jdlrobson>	 coreyfloyd: welsh dragon huh?
[20:58:25] <jdlrobson>	 i like it
[20:58:32] <jdlrobson>	 (as a half welshman)
[20:58:51] <coreyfloyd>	 jdlrobson: we like to be inclusive 😉
[20:58:59] <jdlrobson>	 the welsh are the best
[20:59:49] <jdlrobson>	 nzr: im trying to find the mock for empty state (e.g. if a feed is empty / nearby is empty etc..) do you have it handy?
[21:00:06] <nzr>	 @jdlrobson on zeplin
[21:00:33] <nzr>	 zpl.io/18uyNn
[21:00:45] <coreyfloyd>	 jdlrobson: I feel like the scots may have a different opinion. But I’m not trying to start a fight.
[21:04:39] <jdlrobson>	 haha
[21:05:23] <jdlrobson>	 nzr: https://app.zeplin.io/project.html#pid=57a120dbaa97eeab3c8805ae&sid=57a123b513fe9fb411498870 so is there alternative graphics for pages other than nearby?
[21:06:02] <jdlrobson>	 e.g. trending
[21:06:10] <jdlrobson>	 i think we have one for watchlist .. maybe
[21:19:35] <jhobs>	 jdlrobson: I'd like to get https://gerrit.wikimedia.org/r/#/c/313426/ wrapped up before I leave today, if you have a minute can you check the questions I have on it?
[21:20:34] <niedzielski>	 geez, i know there are threads on gerrit but seriously, how do you build a webpage that doesn't fit on a 1440 display? the only time i can remember having to scroll horizontally elsewhere is for experimental sequential art sites
[21:22:19] <jhobs>	 gerrit ¯\_(ツ)_/¯
[21:22:58] <niedzielski>	 jhobs: i think you mean¯\________________(ツ)________________/¯
[21:23:31] <jhobs>	 I try to pretend my arms aren't that long to be considerate of those shorter than me ;)
[21:24:17] <niedzielski>	 jhobs: lol. i just meant that gerrit is soo bigg
[21:24:31] <jhobs>	 niedzielski: haha I knew what you meant
[21:26:01] <niedzielski>	 jhobs: btw, i think you mentioned aquatic ambiance in that music email thread going around. i'm going to follow up on that thread one sweet day, but i'll just mention now that i was surprised you didn't like to the snes version
[21:26:30] <jhobs>	 niedzielski: I do, I just like the remastered version even more. They're both David Wise
[21:26:36] <niedzielski>	 jhobs: i was going to say it's pretty good but i guess i should say... it's super
[21:26:39] <jhobs>	 he came back to do the Tropical Freeze soundtrack
[21:26:57] <jhobs>	 :D
[21:27:17] <niedzielski>	 jhobs: that's pretty cool. i think i played the predecessor on the wii? it was a lot of fun. i really enjoyed the over the top animations
[21:28:18] <mdholloway>	 niedzielski: jhobs: i was getting ready to necrobump that thread with a response, too
[21:28:20] <jhobs>	 niedzielski: yeah, returns isn't bad, but it has the problem of poor controls (like shaking). The successor is fantastic and has a great speedrun too
[21:28:22] <mdholloway>	 just not today
[21:28:29] <mdholloway>	 or probably tomorrow :)
[21:28:40] <jhobs>	 I really enjoy that thread, so please do!
[21:28:51] <jhobs>	 I'm sure phuedx will be happy too :)
[21:29:14] <mdholloway>	 jhobs: ha, ok, now one of these days i have to for real :)
[21:29:15] <niedzielski>	 mdholloway: well, i was gonna say there's this #wikimedia-music channel. it's just me and one other guy and we don't talk
[21:29:48] <niedzielski>	 one day we will though
[21:29:55] <mdholloway>	 joined
[21:30:04] <niedzielski>	 yayyyy :]
[21:30:04] <mdholloway>	 kind of like wikimedia-reading, then, eh
[21:30:15] <niedzielski>	 mdholloway: yeah i enjoyed that for one moment and then left
[21:30:21] <niedzielski>	 mdholloway: i think it's just you and adam in there?
[21:30:36] <mdholloway>	 niedzielski: we've got about a dozen atm actually
[21:30:42] <mdholloway>	 sitting in silence
[21:30:49] <niedzielski>	 oh nice
[21:30:52] <niedzielski>	 building critical mass
[21:31:15] <niedzielski>	 we should rename mobile content service to reading content service and #wikimedia-mobile to #wikimedia-reading
[21:31:33] <niedzielski>	 well, i guess that's a bad name for the content service
[21:32:14] <mdholloway>	 niedzielski: yeah, it always kind of bugs me that -mobile is the de facto reading team channel when there's an actual -reading channel
[21:32:47] <jhobs>	 mdholloway: niedzielski there was talk of switching it at one point, but i think there wasn't a graceful way to do so or something