[08:10:17] morning [08:33:36] morning joakino o/ [09:37:52] lol [09:38:05] i'd never looked at the phabricator splash page [09:38:08] https://www.phacility.com/phabricator/ [09:38:12] it gets better as you go down [09:38:22] "Written in PHP so literally anyone can contribute, even if they have no idea how to program." [09:38:31] "Like Slack, but no where near as good." [14:55:15] lol [14:55:37] for a moment i thought it "phallacy" not "phacility" [15:27:00] mdholloway: i was thinking about finally filing a formal ticket to increase the number of feed items requested per request. however, i guess too few items per request won't be an issue once we start adding more cards to the aggregated endpoint, right? [15:29:38] niedzielski: maybe not, but i'm not sure how far out that work is so if you're feeling like we could be getting more content per fetch, maybe it's worth filing. shouldn't be a big or difficult change... [15:30:52] mdholloway: tablet users probably see the end of the feed pretty easily but maybe i only see it so often on a phone because i'm frequently flinging for development. [15:31:24] mdholloway: i guess i'll file the ticket and see what happens [15:32:06] niedzielski: yeah, now that you mention it, it seems like your typical feed app fetches more than we do per request, maybe like 2x at least [15:32:59] mdholloway: i was thinking double the items would be good :] [15:37:53] niedzielski: while we're talking, about the unmarshalling field checking, do you know offhand whether it's possible to override the retention policy for @NonNull? i can't find a clear answer in the docs and haven't tested it but i have a feeling it won't work and we'll end up just having to define a custom @Required annotation or something. [15:39:03] mdholloway: i do not know :| [15:40:59] mdholloway: it looks like there's an interesting related thread of discussion here (you probably already saw it though): https://github.com/google/gson/issues/61 [15:42:57] niedzielski: oh, i hadn't seen that one actually. (+1'd!) [16:10:18] phuedx: that phabricator page is fantastic. I thought it must be a satire site at first but I guess they just take their work with a heavy dose of levity [16:20:49] jhobs: phuedx: yeah, i thought at first you were embellishing, but no :) [16:58:10] jhobs, mdholloway: i like how it gets funnier as you scroll down [16:58:20] so the above the fold stuff is serious marketing stuff [16:58:44] but the endearing, genuinely funny stuff is hidden away for folk who read pages [16:58:48] jdlrobson: yt? [16:59:12] https://gerrit.wikimedia.org/r/#/c/313070/ needs a docblock update in the associated test case [16:59:45] SkinMinervaPageActionsTest#test_switch_language_page_action [17:00:02] (for some reason i chose to duplicate docblocks between the code under test and the test cases) [17:16:18] dbrant: standup [19:54:39] niedzielski: mdholloway: bearND: nzr: all in favor of production? say aye? [19:54:48] ayeaye [19:54:55] aye [19:55:07] brion: aye [19:55:14] brion: sorry, meant for dbrant [19:55:25] no worries [19:55:34] i do get beeps on 4 devices though ;) [19:56:40] brion: that's a lot of power in hands of strangers [19:56:58] haha [20:17:16] yippie aye yeah [20:31:45] wut wutw ut.. congratulations everyone. [20:31:55] quarterly goal - check [20:32:00] on last day lol [20:32:46] nzr: we planned it that way :] [20:33:03] why plan too much work or too little? ;] [20:33:21] oh it's by design [20:33:29] by design i mean. not the team. [20:33:33] the classic meaning [20:34:52] :]