[08:29:29] <phuedx>	 o/
[15:43:37] <jhobs>	 maxbinder: I may be late to prio. Fell free to start without me if I am
[15:44:14] <jhobs>	 Feel*
[15:54:55] <maxbinder>	 k
[16:06:56] <maxbinder>	 jdlrobson: nzr bmansuro_ meetin' time 
[16:11:39] <nzr>	 maxbinder: my wifi just dropped
[16:11:47] <nzr>	 Trying
[17:01:38] <maxbinder>	 jhobs: join usss
[17:19:45] <jdlrobson>	 jhobs: hey so i'm just catchig up with what's going on with your card
[17:19:56] <jdlrobson>	 when is a good time to sync in tracy island?
[17:20:27] <jhobs>	 jdlrobson: lemme fix up Baha's points first. I didn't notice v1 was being specifically set to false before, so I'm hoping maybe that'll help the issue I'm having
[17:20:59] <jdlrobson>	 okay how about you fix those up and then ping me and we jump in a hangout to review the new patch together
[17:21:00] <jhobs>	 jdlrobson: i'll ping you when I've got an idea of what timeframe; probably right before or after your lunch
[17:21:11] <jhobs>	 jdlrobson: that works too
[17:21:21] <jdlrobson>	 'cause there's very little for me to do until that patch is done :)
[17:22:06] <jdlrobson>	 but v1 is set to $this->getSkin()->isFooterV2()
[17:22:19] <jdlrobson>	 it may make sense to pair on this
[17:22:31] <jdlrobson>	 i wrote the code and i worry you might be going down a rabbit hole
[17:23:06] <jhobs>	 it's set to that in the old version. I simply made it true for v1 and omitted it for v2 in the new version
[17:23:24] <jhobs>	 fixing up baha's stuff should be quick; i'll do that and ping you
[17:24:43] <jdlrobson>	 jhobs: that's what im worried about. the v1 is only used for one specific purpose
[17:30:07] <jhobs>	 jdlrobson: new patch is up. I'll be in Tracy in a second but first I gotta cycle my router
[17:30:13] <jdlrobson>	 k
[17:31:22] <jdlrobson>	 jhobs: Can you reconsider the commit message? It doesn't match with what the patch actually does.
[17:33:06] <jdlrobson>	 jhobs: and it's still broken for me
[17:34:05] <jhobs>	 jdlrobson: it's still broken for me as well. Getting in Tracy
[18:17:40] <jdlrobson>	 jhobs: ping
[18:17:46] <jdlrobson>	 jenkins php linting errors
[18:17:51] <jdlrobson>	 https://integration.wikimedia.org/ci/job/composer-php55/5778/console
[18:17:53] <jhobs>	 jdlrobson: yeah I just swa, already fixing up
[18:17:56] <jhobs>	 saw*
[18:19:08] <jhobs>	 jdlrobson: is there a way for me to run the linter locally? Do I need to install phpcs?
[18:19:24] <jhobs>	 this one is an obvious fix, but for the future
[18:19:48] <jhobs>	 I know how to for the frontend linters, but not backend
[18:20:05] <jdlrobson>	 PHP codesniffer i believe
[19:02:00] <jhobs>	 bmansurov: left a question for you on https://gerrit.wikimedia.org/r/#/c/313426/4
[19:03:53] <bmansurov>	 jhobs: are you saying an FOUC happens if we don't move the style to the other file?
[19:04:03] <jhobs>	 bmansurov: correct
[19:04:11] <bmansurov>	 jhobs: ok, then let's move it
[19:04:21] <jhobs>	 bmansurov: it also fixes one on diff pages IIRC
[19:06:40] <jhobs>	 bmansurov: great. It should be good to go for +1 or +2. /cc jdlrobson 
[19:37:57] <mdholloway>	 bearND: would you like to deploy today or should i?
[20:00:30] <mdholloway>	 niedzielski: mobileapps unit tests will pass for you once this is merged: https://gerrit.wikimedia.org/r/#/c/313880/
[20:00:57] <niedzielski>	 mdholloway: thanks. i was trying to fix that myself
[20:03:18] <niedzielski>	 mdholloway: what was the actual problem? i see that you creating distinct date instances now but it seemed like it should have worked
[20:03:39] <mdholloway>	 niedzielski: it just wasn't flipping the month over
[20:03:47] <niedzielski>	 mdholloway: i was getting 2016-09-07 locally for some reason
[20:03:54] <niedzielski>	 mdholloway: right, but why wasn't it?
[20:04:27] <mdholloway>	 not sure yet, i was just trying to get a fix in by deploy time (now)
[20:04:31] <niedzielski>	 mdholloway: i wasn't sure if this was an issue in our date util or whatnot
[20:04:45] <niedzielski>	 mdholloway: ah :)
[20:05:06] <bearND>	 mdholloway: I'll do it. Going to check out your test fix patch first
[20:05:22] <mdholloway>	 bearND: ok, sounds god
[20:05:23] <mdholloway>	 good
[20:25:42] <bearND>	 mdholloway: it failed again
[20:26:02] <mdholloway>	 bearND: yeah, i left a bunch of testing code in, sorry :(
[20:26:47] <bearND>	 mdholloway:  and the 'only'
[20:27:16] <jdlrobson>	 jhobs: you there?
[20:27:23] <jhobs>	 jdlrobson: yeah
[20:27:25] <jdlrobson>	 bad news. 
[20:27:28] <jhobs>	 ?
[20:27:33] <jdlrobson>	 turns out hlist-separated introduced a pseudo element into the old footer
[20:27:44] <jdlrobson>	 so we should revert and remove it like Baha said
[20:27:48] <jdlrobson>	 and tackle that separately :(
[20:27:58] <jdlrobson>	 I'm seeing it on http://localhost:8888/w/index.php/Special:MobileDiff/1608 in stable
[20:28:27] <jhobs>	 jdlrobson: got a link that works on beta labs?
[20:28:42] <jdlrobson>	 jhobs: will find one for you
[20:29:03] <jdlrobson>	 https://en.m.wikipedia.beta.wmflabs.org/wiki/Headings?mobileaction=stable
[20:29:10] <jdlrobson>	 look to the right of the desktop link
[20:29:10] <jdlrobson>	 :/
[20:29:23] <jhobs>	 jdlrobson: thanks. Go ahead and revert. I'll modify the patch
[20:29:30] <jdlrobson>	 you could also add a rule #footer :before { display: none; }
[20:29:39] <jdlrobson>	 i'm happy with that if you prefer
[20:29:41] <jhobs>	 Do I need to use a new change-id, or can I continue with the same patch?
[20:29:44] <jdlrobson>	 it is a minor ui regression
[20:29:47] <jhobs>	 yeah, that's fine by me
[20:30:00] <jdlrobson>	 yeh let's do that then
[20:30:48] <jhobs>	 jdlrobson: wait, are you saying no revert, just new patch adding #footer, or revert, add #footer, merge again?
[20:31:00] <jdlrobson>	 jhobs: tracy island
[20:31:03] <jhobs>	 k
[21:00:02] <jdlrobson>	 bmansurov: olliv is https://phabricator.wikimedia.org/T143533 blocking pushing wikidata descriptions live today?
[21:00:21] <jdlrobson>	 I see the patch is +2ed but the dependent patches are not
[21:01:27] <olliv>	 I don't think it's a blocker.  Since they're already live on most wikipedias, this can be something we fix after the fact as well
[21:01:34] <jdlrobson>	 okay cool
[21:06:15] <bmansurov>	 i've merged the remaining unmerged patch