[09:07:51] o/ [16:03:07] jdlrobson: nzr kickoff [16:03:15] we are not allowed in the hangout [16:03:25] maxbinder: fixing hangouts [16:03:37] maxbinder we've been in the hangout for 5 mins. we just refreshed and now we are not allowed in [16:03:55] can you add diderot@wikimedia.org ? [17:08:08] mobrovac: mdholloway: going to do an MCS deploy [17:09:17] bearND_:thumbsup: [17:09:21] er [17:09:28] bearND_: 👍 [17:09:32] ;) [17:26:26] phuedx: I read your response to my comment on https://gerrit.wikimedia.org/r/#/c/313381/6. Thanks for the explanation. I left one more comment about a minor part, however. [17:26:43] Also, how do you do quotes in gerrit?? I would've thought ">", but that was incorrect. [18:50:07] jhobs: i think if you add a space or two at the beginning of a line in a gerrit comment it'll monospace the rest [18:50:16] jhobs: (not exactly intuitive!) [18:51:10] *the rest of the line, that is [18:52:55] mdholloway: yeah, I know how to monospace but apparently there's a way to quote like in an email too [18:53:09] jhobs: oh, interesting [19:17:37] https://usercontent.irccloud-cdn.com/file/XO7IVZNB/TOC.png [19:17:46] ^ bmansurov when testing your table of contents patch I'm seeing that. Is that expected? [19:18:35] jdlrobson: numbering? [19:19:28] if so, then yes, I'm not chaning the TOC from the core. I didn't think it was necessary for the prototype [19:19:35] if you mean something else, please clarify [19:22:21] just the fact it's rendered twice [19:22:27] at top of page and in overlay [19:23:09] some pages have long table of contents - you may want to test on Trump - it takes up 2 scrolls on a mobile device [19:23:13] * jdlrobson lunch [19:37:22] jdlrobson: yes, that's intended [20:59:54] bmansurov: hey sorry to bother you, but i have a SWAT at 4pm and I just discovered a bug. Talking to Nirzar he's keen for me to SWAT this too => https://gerrit.wikimedia.org/r/315414 [21:00:17] without it, the main page will lose the language button when MinervaBottomLanguageButton becomes false [21:00:25] ok [21:00:43] then the idea is to check the event logs to make sure that removing the language button from the bottom doesn't lead to less clicks in the language overlay [21:00:59] and we'll throw away the code sometimes next week when we're sure that's the case [21:02:11] thanks bmansurov [21:17:53] bearND mdholloway dbrant: o/ would one of you mind checking simplified chinese language support on master? i think it's broken as compared to beta / prod. when i go to the 中国 page (https://zh.wikipedia.org/zh-hans/%E4%B8%AD%E5%9C%8B) in app, i get the traditional spelling [21:18:27] niedzielski: i'll take a look [21:18:39] mdholloway: thanks! :] [21:19:08] mdholloway: i'm trying to fix some new language issues and i think the problem wasn't original [21:20:03] mdholloway: i even built a beta locally and refreshed the page and saw my simplified spelling go to 中國 [21:21:46] mdholloway: if you're seeing it, maybe this is an issue with the okhttp singleton? we had a couple related changes but nothing jumps out at me [21:22:39] niedzielski: i'm firing it up now on the rarely used samsung galaxy tab (so i can review dmitry's samsung specific fix as well) [21:22:55] mdholloway: nice [21:23:14] niedzielski: yeah, seems like it would have to be a change in header handling somewhere (implying the okhttp singleton) [21:34:16] mdholloway: if you can confirm the issue on your end, i think i see where the problem would be [21:34:18] niedzielski: yep, confirmed [21:34:27] works in beta, not master [21:34:33] mdholloway: yay, not crazy :] [21:34:38] mdholloway: thanks!