[08:32:59] o/ [08:33:01] howdy [09:16:50] hello! [11:36:59] woo [13:35:18] phuedx: I thought my eyes were deceiving me while reviewing the jscs patch because when I started reviewing it I thought you put a +1 on it [13:35:26] turns out you were changing it at the same time :D [15:21:09] niedzielski: thx! all set for beta, from my end. [15:22:01] dbrant: i think https://gerrit.wikimedia.org/r/#/c/303942/ was really close. was going to give it a spin [15:22:10] sure [15:52:29] olliv: product meeting moved? [15:53:13] nzr: yup, due to offsite, moved to next thursday [15:54:27] olliv: hmm... i ran to office :P but now i have gift of time [16:35:16] jdlrobson: coming to the mobile meeting? [16:35:25] and there you are lol [16:36:23] joakino: same question ^ [16:36:40] anyone else seeing a certificate revoked error when connecting to wikipedia.org? [16:37:33] joewalsh: yep, known issue (seems specific to macOS sierra + win1-) [16:37:36] *win10 [16:37:51] are you on sierra? [16:38:37] they're discussing in -operations, see also T148045 [16:38:38] T148045: Windows 10 & MacOS Sierra Cert errors - https://phabricator.wikimedia.org/T148045 [16:39:20] you can use firefox to work around for now [16:39:34] it's unaffected [16:41:01] @mdholloway yeah - I’m on sierra. Thanks for the info! [16:57:06] i think http://test.wikipedia.org/ is down or very slow. the app tests are failing [17:05:03] dbrant bearND mdholloway: well, there seem to be some known larger problems at work right now in ops. beta will have to stay on hold until they're resolved [17:05:53] niedzielski: hmm, i didn't think the app was affected :( [17:06:02] so you're seeing problems in all browsers in debian? [17:06:37] debian and all android devices are timing out [17:07:08] ಠ_ಠ [17:07:18] testwiki working fine with ff on macOS sierra [17:08:18] but yeah, we have issues and it's not a bad idea to put the release on hold for a bit probably :) [17:34:50] I have a question for folks who know about Android. I'm investigating why we get a disproportionate volume of pageviews to Wikipedia.org portal page from Android. the UA with the most pageviews is "Dalvik/2.1.0 (Linux; U; Android 6.0.1; SM-G900F Build/MMB29M)" which confuses me because the wiki page for Dalvik states it was discontinued and ART is the only [17:34:50] runtime as of Android 5. Am I missing something? [17:35:55] bearloga: dalvik was the old vm [17:36:51] any ideas why I would see Dalvik in use on Android 5 and Android 6 devices? :/ [17:37:47] bearloga: it looks like SM-G900F is a samsung galaxy s5. one website claims it has Android 4.4.2 installed. the dalvik to art change was relatively recent [17:38:25] bearloga: when samsung upgrades a device, from one major version of android to another, they frequently leave out lots of stuff. i'm not sure if dalvik would be included in that or not [17:38:48] bearloga: so the os would report Android 5, Android 6, etc but the underlying implementation may be elderly [17:38:58] i think the UA may still use 'Dalvik' even for ARM versions but I'm not 100% on that [17:39:59] bearloga: just a guess. if someone has an s5 checking the vm should be easy [17:40:33] *ART [17:44:13] can anyone with an android device check? are there dev tools that'd let somebody check if ART is reported as Dalvik 2.1.0 on Android 5+? [17:45:19] dbrant bearND: do either of you happen to have an s5? [17:48:40] bearloga: i'm looking into it. contra my own suggestion, the UA for chrome on Nougat (Android 7) doesn't contain 'dalvik'. But I'll check out what the system webview is reporting. [17:48:45] no s5 here unfortunately [17:48:52] also! there appears to be a single android phone (or at least a speedtest/bot that uses that fakes that UA) responsible for 8K pageviews on a single day (a Trooper X55, to be exact). and a few more devices with 4K PVs. can anyone think of anything in android that would be hitting www.wikipedia.org/ so much in one day? [17:49:22] mdholloway: thanks for looking into it [17:50:39] bearloga: ha, i had a suspicion a bot may be involved... :) we only use 'https://wikipedia.org' as a placeholder return URL in our login/createaccount requests but that shouldn't result in any pageviews. we never actually access the portal in the app. [17:51:02] bearloga: it might be possible if a clever user messed with the dev settings enough but certainly not something that should happen in normal usage [18:20:24] bearloga: niedzielski: ok, it looks like android has its own separate system UA that it will send in some or all cases in addition to any application (e.g., browser) UA [18:20:28] see, for example: https://stackoverflow.com/questions/23804278/browser-sending-dalvik-as-user-agent [18:20:54] and the system UA will always begin with "Dalvik/", even for ART versions [18:21:02] see https://github.com/android/platform_frameworks_base/blob/master/core/java/com/android/internal/os/RuntimeInit.java#L193-L221 [18:21:08] (current AOSP master branch) [18:21:46] still doesn't explain the portal weirdness, but at least clears up the dalvik issue i guess :) [18:22:16] mdholloway: cool i wonder if this is still true now that the webview is updated by the play store or if that's independent [18:26:14] bearND dbrant mdholloway: i'm seeing a weird header or edit issue on API 16 and 23 only that i haven't been able to track down. on api 16, i got a NPE in EditPreviewTask.java:41 deep within the asObject() invocation. i'm seeing a somewhat similar issue (but seems to be independent of headers) on api 23 in FetchSectionWikitextTask.java:39 where optJSONArray("revisions") is returning null [18:30:18] bearND dbrant mdholloway: the api 16 issue did happen during the wikipedia.org troubles but this api 23 issue seems reproducible now on https://zh.wikipedia.org/zh-hans/%E4%B8%AD%E5%9C%8B%E6%96%B0%E6%AD%8C%E8%81%B2_(%E7%AC%AC%E4%B8%80%E5%AD%A3) [18:30:59] (just press the edit button) [18:32:54] niedzielski: not a regression though, right? [18:33:47] dbrant: i haven't looked yet [18:34:01] dbrant: it looks a similar issue on api 16 just happened. https://rink.hockeyapp.net/manage/apps/226650/app_versions/51/crash_reasons/140375430 [18:34:32] niedzielski: yeah, i just repro'd on the current production app. [18:42:33] mdholloway niedzielski-afk: thank you for looking into it! hm... [18:51:23] dbrant: niedzielski-afk: there's an underlying encoding error in preparing the api request we're sending. looks like parens aren't being handled and the title is being truncated. prob affects all pages with parens in the title [18:51:24] https://zh.wikipedia.org/w/api.php?action=query&format=json&prop=revisions&rvprop=content&rvlimit=1&titles=%E4%B8%AD%E5%9B%BD%E6%96%B0%E6%AD%8C%E5%A3%B0_ [18:52:35] bearloga: no worries! sorry we haven't got any more for you [18:53:57] dbrant: niedzielski-afk: maybe only for chinese variants, though, this isn't a problem in en [18:54:25] or when loading via mw rather than rb (which we force for zh-*), better check that too [18:55:31] mdholloway: niedzielski-afk: note -- the problem goes away if I switch to Traditional Chinese. [18:57:28] dbrant: niedzielski-afk: hmm, doesn't even affect a different page with parens in title for simplified chinese... [18:57:50] anyway, i'll phab it [19:49:29] bearND dbrant mdholloway nzr: release notes are cooking in the usual place [19:52:35] olliv: do we still want to do grooming today with you all at the offsite and max out? cc bmansurov_away jdlrobson [19:54:33] jhobs: hi, I'm still here - let's do it [19:55:21] olliv: ok, see you in 10 [20:06:59] jdlrobson, bmansurov_away: grooming if you can make it [20:21:55] niedzielski: looks good to me [20:22:58] 👍 [20:30:37] mdholloway bearND dbrant nzr: i'll publish shortly if i don't hear any objections [21:08:51] niedzielski: sorry, got stuck in meetings. release notes are (were) great. [21:09:28] dbrant: cool i figured you wouldn't mind since we can always change the ones in the play store [21:41:30] gerrit's down! you heard it here first! [21:42:38] ok it's back up [21:58:50] Notice: Undefined property: MobilePage::$revisionTimestamp in /srv/mediawiki/php-1.28.0-wmf.22/extensions/MobileFrontend/includes/models/MobilePage.php on line 66