[00:48:15] aharoni: not sure if you still read this, maybe through the logs. There's some generic Android info about it: https://developer.android.com/guide/topics/resources/string-resource.html#Plurals and my search brought up a task where we had an issue with it due to the missing "other" quantity: T140700. [00:48:16] T140700: [CRASH] Missing plural resources cause app to crash - https://phabricator.wikimedia.org/T140700 [00:48:54] nzr: np [01:28:05] aharoni: the only thing i have to add to bearND's comment is that we always need the "other" quantity string to be present [08:53:36] joakino: have you worked on the flashcard styles for the prototype? [08:53:49] i ask because i couldn't stop thinking about how i'd build the service last night [08:53:51] also o/ [17:02:01] nzr: standup? [19:07:40] jhobs, bmansurov, jdlrobson, nzr: backlog grooming? anybody? [19:07:56] 1sec [19:08:09] ZOMG lunch meeting [19:08:11] did we move it? [19:08:35] I think today's got moved earlier for some reason, yeah [19:37:38] dbrant: around? [19:37:52] dr0ptp4kt: ah sorry, omw [19:37:58] dbrant: k [20:54:52] bearND: can we call this done: https://phabricator.wikimedia.org/T143808 [21:02:02] dr0ptp4kt: I found a way to get rid of empty categories by specifying min number of file in the category to 1. [21:02:22] dr0ptp4kt: Something like: https://commons.wikimedia.org/w/api.php?action=query&continue=gaccontinue||&generator=allcategories&gacprefix=Audio%20files&gacmin=1&gaclimit=500&&gacprop=size [21:35:46] dbrant: I'll close it out in a bit [21:48:20] kaldari: o/ i think i recall that you had some history with abuse filter 94? (sorry if you don't.) it claims it's disabled and it's causing our test to fail by returning an error instead of a warning. can you edit it? https://test.wikipedia.org/wiki/Special:AbuseFilter/94 [21:50:25] niedzielski: sure, do you know how it needs to be changed? [21:50:57] kaldari: no. i was thinking i was hitting T54525 so maybe you can just edit the note, save it, and revert [21:50:58] T54525: AbuseFilter doesn't disable filters for safety measure, but says it does! - https://phabricator.wikimedia.org/T54525 [21:52:36] reading... [21:56:16] niedzielski: Is you test the one that tries to edit User:Yuvipandaaaaaaaa? [21:56:28] kaldari: that's the one [21:56:48] niedzielski: I could just add an exception for that then. [21:57:19] kaldari: hm, well the test is to trigger the rule. in other words, we want to get a warning back [21:57:50] oh [21:59:43] niedzielski: I disabled and re-enblaed it [21:59:56] niedzielski: should be good now, but I expect you will run into this problem again [22:01:06] niedzielski: Maybe I can help you figure out a better solution. What exactly are you trying to test? [22:01:38] kaldari: hm, i guess that's not it. we're still getting back abusefilter-disallowed instead of abusefilter-warning. [22:01:55] kaldari: i think this really just tech debt biting us. we should be mocking out these responses [22:02:41] kaldari: sounds like it's time to pay the debt off :] [22:52:21] niedzielski: sorry, had to go to a meeting, done now... [22:52:55] kaldari: no worries! i just put in a workaround for today. i think we should really fixx this in the app instead of troubling you with it [22:53:28] no problem. [22:53:54] niedzielski: Is the basic thing you're trying to test just that abuse filters work in mobile editing? [22:54:39] kaldari: sorry to have bothered you at all. i was thinking it would be easier than it proved. right, we're really trying to test that deserialization logic works correctly for this specific test [22:57:40] The 5% threshold is actually configurable per wiki. Maybe you could configure it to 101% on a beta cluster wiki and test against that. [22:58:49] or build out some mock functions to handle AbuseFilter like responses, but that requires more work :) [23:04:32] kaldari: thanks for the tips! if there's going to be an investment, i'd rather make it in the right fix which i think in this case is all app side