[14:33:03] <anirudh24seven>	 Will Pull Requests raised on GitHub be ignored for the Wikipedia Android app? Forgot that the process was not the same as Wikipedia iOS. Shall I do it again via Gerrit now?
[14:35:38] <anirudh24seven>	 Referring to this in particular: https://github.com/wikimedia/apps-android-wikipedia/pull/6
[14:55:39] <niedzielski>	 anirudh24seven: yes, please use Gerrit :]
[14:55:56] <anirudh24seven>	 niedzielski: Sure. Got it. :)
[14:55:57] <niedzielski>	 anirudh24seven: notes are here: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Wikipedia_Android_app_hacking
[14:56:07] <anirudh24seven>	 niedzielski: Yes. Saw that. Thanks.
[14:56:51] <niedzielski>	 anirudh24seven: great, thanks!
[15:53:40] <phuedx>	 o/
[16:09:03] <anirudh24seven>	 niedzielski: In Gerrit, can I not create a new Pull Request without a tracking task/bug? I want to submit a PR related to code cleanup.
[16:09:34] <niedzielski>	 anirudh24seven: you shouldn't need a phab task to submit a patch
[16:09:45] <niedzielski>	 anirudh24seven: what's the error message you're seeing?
[16:10:22] <anirudh24seven>	 niedzielski: Oh. It just worked now. Was seeing this earlier: "ERROR: missing Change-Id in commit message footer"
[16:10:34] <anirudh24seven>	 niedzielski: This is the patch: https://gerrit.wikimedia.org/r/#/c/317164/
[16:11:16] <niedzielski>	 anirudh24seven: ah, that just means the git hook needs to be run (it automatically adds a "Change-Id" to your commit message on git commit or git commit --amend)
[16:11:19] <anirudh24seven>	 niedzielski: It worked when I amended my commit message
[16:11:21] <niedzielski>	 anirudh24seven: sweet, thanks!
[16:11:40] <anirudh24seven>	 niedzielski: Thank you too
[16:11:57] <niedzielski>	 :]
[17:21:15] <niedzielski>	 dbrant: when will i see you again?
[17:46:30] <bearND>	 niedzielski: wow, that's a long list of patches. Do you have a suggestion on a couple that should be reviewed first? 
[17:47:32] <niedzielski>	 bearND: there's three in this pile that would be great to get in: https://gerrit.wikimedia.org/r/#/c/316495/ 
[17:48:17] <niedzielski>	 bearND: two here: https://gerrit.wikimedia.org/r/#/c/317065/
[17:48:51] <niedzielski>	 bearND: and then the big stack starts here: https://gerrit.wikimedia.org/r/#/c/317089/
[17:49:23] <niedzielski>	 (i don't think there's a large patch in it though)
[17:51:25] <niedzielski>	 dbrant mdholloway: here's that volunteer patch i mentioned in stand up: https://gerrit.wikimedia.org/r/#/c/317164/ . since it touches most of the java files in the repo, it (and the follow-up patch) would be good to get in sooner rather than later
[17:52:10] <mdholloway>	 yeah, i saw that, will look in a bit
[17:55:12] <bearND>	 niedzielski: since you have so many outstanding patches there is a chance that you'd have to rebase a good portion of them if we merged the optimize imports patch first. Are you ok with that? Otherwise we could just merge your follow-up patch to that one and let AS optimize imports on all files later when there are not so many outstanding ones.
[17:55:48] <niedzielski>	 bearND: yeah, i'd rather put the rebase on my patches than the volunteer
[17:56:15] <niedzielski>	 (but thanks for looking out!)
[18:00:01] <bearND>	 niedzielski: understood
[18:19:22] <jhobs>	 jdlrobson: can you review https://gerrit.wikimedia.org/r/#/c/316978? I don't understand Baha's question
[18:43:17] <raynor>	 jhobs: I put my two cents in https://gerrit.wikimedia.org/r/#/c/316978?
[18:45:10] <raynor>	 question mark is just a copy&paste artifact :)
[18:46:20] <jhobs>	 raynor: how would restoreTitle be called without removeTitle being called first, apart from a manual event trigger in the JS console?
[18:46:40] <raynor>	 just in case something went wrong and data article is not stored
[18:46:55] <raynor>	 if because of some reason this func is called it will remove title
[18:47:01] <jhobs>	 isn't that the point of the patch tho? ;)
[18:47:18] <jhobs>	 to fix what was going wrong with data not being stored?
[18:48:18] <raynor>	 yes, but I'm just saying that removeTooltip has some logic to check if title is there
[18:48:31] <raynor>	 restoreTooltip blindly takes data('title') and puts it back
[18:49:05] <raynor>	 what if someone is moving his mouse and mouseenter and mouseleave comes almost immediately
[18:49:33] <raynor>	 you will have race-condition when removeTooltip didn't set data('title') yet but restoreTooltip will take it
[18:50:10] <raynor>	 better be safe than sorry
[18:50:18] <jhobs>	 yeah, i guess the extra check shouldn't be too costly
[18:51:02] <raynor>	 you can store it in local var and if it's set then assign it to title
[18:51:13] <raynor>	 one extra if is nothing
[18:51:30] <bmansurov>	 jdlrobson: do you know who can give me an import right at https://en.wikipedia.beta.wmflabs.org? I'd like to import some pages for testing the infobox.
[18:51:44] <jdlrobson>	 I can import for you
[18:51:52] <jdlrobson>	 just send me/uploade the dump
[18:53:02] <bmansurov>	 jdlrobson: cool, thanks
[18:53:06] <jhobs>	 raynor: I always try to be as performant as possible. It's "just" one extra if, but that's also extra bytes we're serving. In this case though I think you're right, and I'll update it
[18:58:48] <raynor>	 I agree, performance is important, but we don't want to put `undefined` in titles
[19:04:21] <bmansurov>	 jdlrobson: uploaded a dump at https://phabricator.wikimedia.org/T145216#2735020
[19:06:35] <jdlrobson>	 raynor: jhobs there's definitely lots of race conditions going on in Hovercards :-/ bmansurov done!
[19:07:21] <jhobs>	 jdlrobson: I tested the title attribute method both manually and programmatically, hopefully we should at least be good on that one :)
[20:03:18] <dbrant>	 bearND: retro
[20:28:45] <nzr>	 joakino: flashcard is broken :( 
[20:52:01] <jhobs>	 bmansurov: replied to your comment
[20:52:29] <jhobs>	 bmansurov: feel free to ping me with any further questions/comments because I'm leaving soon but want to try to wrap this up before heading out