[06:24:03] mornig [07:58:18] o/ [07:58:20] o/ joakino [08:00:29] hii [10:37:34] helllooo [13:51:19] Hello everyone [14:01:38] 👋 raynor [15:54:20] mdholloway: can we call this one done? https://phabricator.wikimedia.org/T145075 [15:56:48] dbrant: i'm not sure there's any more to do, but the service-side patches are still outstanding (inc. one with a -1) [15:57:18] mdholloway: ok i see; so i'll move to the new sprint, then? [15:57:22] bearND: have i addressed your concerns with https://gerrit.wikimedia.org/r/#/c/315995/ ? [15:57:27] dbrant: sounds good [16:01:17] there are two events at same time, which one should we join ? [16:01:44] olliv: jdlrobson reading metric or sprint kickoff? [16:02:06] nzr I have some question :) [16:02:11] sprint kickoff :) [16:02:19] kk [16:04:04] nzr: im wondering the same [16:04:40] nzr , jdlrobson: are you joining? [16:04:44] nzr: how can we decide reading metrics without the web team? that seems like a big fail olliv [16:04:53] exactly :( [16:06:09] nzr come to us ;) [16:06:27] they'll be posting the slides afterwards, and it was mainly as a review of our metrics :) [16:06:51] olliv: okay im leaving this and joining kick off [16:41:43] nataliaharateh: i've lost my connection to hangouts, attempting to reconnect now [16:41:47] niedzielski: bearND: dbrant|brb: re: the point dbrant|brb is currently making in-mtg: maybe i should make a point to get https://gerrit.wikimedia.org/r/#/c/317095/ in review-ready shape today so we don't have AMGTV continuing to take up a spot in the most valuable feed real estate [16:41:59] it's not far off really [16:42:11] ok jhobs [16:42:14] :) [16:42:47] mdholloway: i'm not in the mtg at the moment but i followed up on the ticket expressing support [16:43:00] niedzielski: saw that, thx :) [16:43:47] mdholloway: if we don't get it ready this morning we could do https://phabricator.wikimedia.org/T148574 real quick [16:43:50] niedzielski: i think dbrant|brb found that trending (most-read) articles are the most-engaged with from the feed [16:44:19] @joakino oops i wanted to remove design col from two cards.. and i ended up removing the reading-web-backlog tag. can we add it again and put it in current sprint col? not sure if i mess it up more :p [16:44:58] mdholloway: makes sense. in the news card isn't available in many languages making the trending card the topmost and it's probably the most localized. [16:46:42] bearND: yeah, if the bigger patch isn't ready by deploy time I think we'd be justified in adding AMGTV to the blacklist at this point based on the mobile vs desktop pageview criteria [17:01:48] @niedzielski @mdholloway if face detection fails to find a face on a portrait image, does the android app default to showing the image cropped to a rect in the center, the top, or somewhere else? (for context: https://phabricator.wikimedia.org/T148926) [17:03:50] joewalsh: i don't think we're consistent everywhere but i think the best and lead implementation is to show centered and cropped [17:04:06] joewalsh: i haven't looked at the docs to see if there's anything more complex going on but based on experience it's cropped to center [17:04:34] thanks! [17:05:29] nzr: i don't know how milestones work :( bmansurov and olliv should be able to help us [17:07:38] nzr: you probably have to "move on workboard" and move it out of the Design column in Reading web backlog but I'm not sure [18:17:26] hey mobile people: Why were there a large (something like 30+?) changes sent to Gerrit/Jenkins for Android all at once? [18:17:44] I think it slowed some things down and I'm trying to figure out what the use case is here so we can try to address it [18:19:11] ping me when you reply [18:28:57] greg-g: o/ sorry, that was me [18:29:18] greg-g: i had a large chain of dependencies on one patch and several smaller changes. both needed rebasing [18:30:41] * greg-g nods [18:31:05] figured, now to figure out why it prevented changes from unrelated repos to be processed.... :) [18:31:11] jdlrobson: tests are passing now: https://gerrit.wikimedia.org/r/#/c/317551/ [18:31:51] greg-g: sorry, i can stagger my submissions in the future if need be [18:31:59] meh, you shouldn't have to [18:52:13] bmansurov: great! will take a look at that now [20:02:11] niedzielski: i'll give it a quick try, i could be mistaken [20:02:19] what node version are you running locally btw? [20:02:42] mdholloway: 6.5 :] [20:03:31] mdholloway: like, i'll use require to import the package.json sometimes [20:06:56] niedzielski: yep, it works :) just going to double-check in docker with the prod version for good measure [20:07:14] yayyy [20:07:54] mdholloway: i'll put in a change in for that news config as well. thanks for checking! [21:29:24] No more AMGTV [21:43:32] bearND: \o/ [22:17:59] niedzielski: hi, were you able to repro the crash ? [22:18:23] matanya: no, but i haven't tried since i commented on that ticket [22:18:54] if you need anything, just let me know. thanks [22:20:56] matanya: thanks, it's a priority for next release (planned sometime in the next two weeks) but i don't think it's happening in production [22:22:05] niedzielski: it is not, not on beta as well. only since the alpha mentioned in the ticket [22:22:30] matanya: thanks for finding this. we really appreciate the bug report! [22:22:58] sure, always at your service :)