[00:52:14] hi [01:10:59] anyone? [01:18:17] there is problem with viewing this template from the wikipedia app [01:18:17] https://en.wikipedia.org/wiki/Template:Selected_picture [12:09:28] Hi [12:09:38] Someone people told me [12:10:06] that many people from the wikimedia from SF chat here [12:10:36] Can someone take a look at this [12:10:37] https://phabricator.wikimedia.org/T120238#2759525 [12:10:38] ? [12:58:52] lbertolotti: the SF answer will most likely be somethin in the range of [12:59:10] don't make assumptions about how things look on mobile, based on how they look on desktop. [12:59:21] yeah ok [12:59:36] I already noticed that [12:59:36] if you write correct CSS and mostly you won't have a problem. [13:01:01] for instance, this problem can be very easily solved by not using a table [13:11:23] lbertolotti: lemme tinker a bit [13:11:39] ok [13:29:39] lbertolotti: check now [13:33:52] looks good [13:34:08] btw. these are not issues for phabricator [13:35:47] why not? [13:35:47] Those who dress up the christmas tree with lights are expected to make it look good, not the supplier of the tree. [13:36:12] well [13:36:21] there is one thing though [13:36:41] More selected pictures... Read more... [13:36:47] this is not visualizing in the app [13:37:04] the old code could do that [13:37:07] hmm, that would be a seperate issue [13:46:33] What do you think of this? [13:46:34] https://en.wikipedia.org/w/index.php?title=Template%3ASelected_picture&type=revision&diff=747278407&oldid=747276117 [13:47:59] lbertolotti: I think that you just removed one of the three columns in that block [13:48:26] well, that code works with the wikipedia app [13:48:45] so ? you broke it in some situations of the desktop ? [13:52:04] I will think of something else then [13:56:28] lbertolotti: so those elements are completely hidden on android ? [13:56:37] yes [13:56:42] lbertolotti: in that case, it sounds like the app is hiding noprint classes... [13:57:00] which it shouldn't... [13:57:16] It is a bit weird [13:57:19] the mobile view [13:57:24] from the web page [13:57:26] is working fine [13:58:05] I thought the mobile view= view from cellphone [14:05:43] no not necessarily [14:22:51] are you there isn't a problem with how the wikipedia app is processing the code? [14:26:13] lemme pass that thing trough the html validator... [14:29:26] if even you say that is not an issue for phabricator [14:29:59] hmm, wait a minute, the apps get their html from parsoid of course.. that might have different errors. [14:30:01] that the mobile isn't the same of the wikipedia app is a bit an indication that there is something wrong [14:35:40] lbertolotti: question. On android, do you see the "More about engineering" link in the first block ? [14:40:00] yes, both on the mobile view on my Nexus 5 [14:40:24] lbertolotti: k, i'm gonna save something and then if you could refresh and check please ? [14:40:38] lbertolotti: how about now ? [14:42:22] hmm, apparently it will take a while for the change to propagate. [14:43:31] please add a purge cache to the bottom of the page, like this one [14:43:36] https://en.wikipedia.org/wiki/Portal:Capitalism [14:47:21] lbertolotti: i purged a while ago already. anyway. i suspect that in the coming hour, that link will disappear as well for you. [14:47:39] if that happens, then it is definetly because noprint is incorrectly handled by the android app. [14:48:28] ok, I will post the feedback on phab [14:54:19] well that change [14:54:24] messed things a bit [14:57:03] https://phabricator.wikimedia.org/T120238#2759525 [14:57:28] so, it is a bug with the adroid app? [15:03:38] thedj? [15:06:52] lbertolotti: the image being centered is expected [15:07:32] lbertolotti: ah so indeed that "More about engineering" link is gone now. [15:07:50] lbertolotti: that means that this is a noprint-issue, specific to the Android app. [15:08:09] were should this be reported? [15:08:20] in phabricator, in a new ticket. [15:08:32] ok [15:08:36] can you do that? [15:08:42] or do you want me to do it? [15:09:59] i'd rather you do it. [15:10:13] ok [15:10:53] I should name the task [15:11:08] noprint-issue in wikipedia android app [15:11:09] ? [15:11:21] "Android app hides hides class noprint" [15:11:49] and then mention that iOS and mobile view don't. add links to an example page showing the problem and attach the screenshots. [15:12:45] iOS? I don't have access to that [15:21:40] but i do. i checked that. [15:26:31] thedj, you are TheDJ (Derk-Jan Hartman) on phab? [15:29:42] yes [15:37:11] thedj, https://phabricator.wikimedia.org/T149699 [15:37:12] ? [15:50:27] thedj, do you know why phab is not visualizing two images on the same box? [15:51:05] lbertolotti: because bmp is not a supported file formate for inline display in phabricator [15:51:15] ah [15:51:22] what files are supported? [15:51:26] jpg and png [15:51:57] no worries, i got it [15:52:11] dbrant, got what? [15:52:19] the bmp file, and the context therein [15:53:36] Ok, so what do you think can be done abou this issue? [15:53:46] i replied on the task. [15:57:20] was wondering, since i couldn't find back any matching css statement in the repo. [15:57:34] but it being stripped out by MCS or parsoid makes sensen. [16:03:06] olliv: do web need a new sprint board? what's the new naming convention after z? [16:03:22] bearND: do you remember any reason(s) for hiding noprint initially? [16:07:47] dbrant: no good ones. I think I may have mistakenly added it to the same bucket as display:none when it came to trying to remove unnecessary payload. I realize this is wrong. [16:08:27] it used to be hidden on mobile as well, this was corrected somewhere over the past two years. maybe that was just around the same time or something. [16:08:59] ok that's fine. i just wouldn't want to re-introduce any issues that were solved by hiding noprint... [16:10:22] dbrant: thedj: good point. That refreshes my memory a bit. I think I took all CSS rules we had at that time which resulted in a display:none, and added them to the list of elements to remove [16:14:06] right sounds logical. [16:14:30] that whole rewriting of content is a bit dangerious to me [16:14:40] like the assumption that metadata should always be stripped. [16:15:02] bearND, do I have to wait for the patch to be released throught play store? [16:15:02] on english wikipedia that only really holds up for the main namespace really. [16:15:39] lbertolotti: no, this would be changable on the server end. [16:15:47] lbertolotti: but no timeline [16:23:27] lbertolotti: we're going to deploy this change server-side tomorrow afternoon US time. No app update is needed but the page would still show the old content until either someone edits it or any included templates or we force a rerender of all pages, whichever comes first. [16:23:56] ok [16:24:35] so purging chance won't work? [16:26:51] lbertolotti: Not sure what kind of purge you're referring to [16:27:34] purging page cache I mean [16:30:48] lbertolotti: purging the caches for MCS results would be part of any of the three options I mentioned. The first two are for a particular page the last one is for all pages, which takes a very long time. Note that this has to happen after the code change is deployed to production. [16:31:09] I got it [17:05:16] mdholloway: bearND in the android app, do you request different image sizes than what you receive in the feed? https://en.wikipedia.org/api/rest_v1/feed/featured/2016/11/01 [17:05:45] for instance there, the featured article pic is only 150 wide [18:03:32] coreyfloyd: the original isn't any bigger [18:04:10] coreyfloyd: because it's fair use [18:59:51] thedj: thanks… i realized that later…its not a great example but it seems like max width is 320 [19:14:27] coreyfloyd: hey, sorry i missed that, no, we never request different sizes than we receive [19:24:40] mdholloway: thanks [19:35:07] dbrant: call? [20:08:23] coreyfloyd: mdholloway: There's a project called Thumbor which is supposedly going to improve the situation regarding thumbnail URIs. I don't know much about it yet but am going to ask in the -perf channel [20:09:14] yeah, i remember that sounding promising [20:09:39] bearND: ok - I have heard of that but not sure of how far along it was [20:10:01] bearND: any specific reason you went with 320? [20:10:40] bearND: i would imagine most of your devices are higher resolution than that right? Are you worried about data usage or low power phones? [20:12:44] coreyfloyd: I think it started with link previews. There was a long discussion on a task about that for the summary endpoint. We settled on 320 pixels. [20:13:16] Data usage was definitely a concern [20:31:32] bearND: do you have a ticket with that conversation? [20:31:33] Thumbor sounds like a Tolkien character. [20:33:07] dbrant: lol [22:48:12] dbrant: i'm going through your patches now and see that i had some patches of my own from yesterday that are quite similar to yours. i neglected push mine up until now, so please hold off on merging them. they weren't meant to copy yours, i just noticed some lints while i was resolving warnings in the upgrade process [22:49:15] i'll resolve the conflicts in mine once we get yours merged