[12:25:58] jdlrobson: ping? [12:26:57] jdlrobson: most of the patches for https://phabricator.wikimedia.org/T145662#2779152 should not be dependent on each other, could you decouple them so we can merge them as they are good to go please? [13:55:37] mobrovac: the patches are dependent on each other to avoid merge conflicts. [13:55:54] mobrovac: sadly gerrit doesnt handle pull requests nicely like github [13:56:16] if you have a preferred order feel free to chery pick them to master where possible [13:56:23] (if possible) [16:40:45] phuedx: yt? [16:41:20] dr0ptp4kt: I believe he ran out quickly to pick up his son [16:41:33] thx jhobs [20:31:54] dr0ptp4kt: here's the test and client i mentioned (just expand the deleted files): https://phabricator.wikimedia.org/rAPAWdb8c990611a9197cc81fa277663d6bd5141e0c46 [20:32:56] it looks like there's similar logic in master under AggregatedFeedContentClient [21:03:37] just noticed that today the wikipedia android app has 400 stars on github [21:09:21] has anyone had a problem before of `git review -d ` not working on a fresh install of git-review? I'm trying to setup a new workspace and everything appears to be in working order EXCEPT for that [21:09:59] I always get 404 errors because `git review -d` is requesting (what I assume is) the wrong URL [21:16:24] jhobs: I have not run into this but I would probably check the .gitreview file in the repo first, then if the URL in `git remote -v` are correct [21:17:00] bearND: the .gitreview file is fine because it works fine on my other workstation [21:17:21] and the remote is correct too [21:17:46] it's only when using `git review -d` specifically that it doesn't work :/ pushing and pulling are fine [21:18:28] the new workstation I'm trying to set up is Windows, so I'm sure it has something to do with that [21:19:14] but it seems odd to me that it would be checking the completely wrong URL ("GET https://gerrit.wikimedia.org/changes/?q=1235&o=CURRENT_REVISION") [21:22:59] jhobs: sorry, I don't usually use `git review -d`. I copy the git command needed to download the changes from the Web UI [21:23:54] bearND: thanks for trying! I'll probably resort to the UI as well when using the new workstation for now