[18:15:33] <mdholloway>	 be there 1 min
[18:33:16] <bearND>	 dbrant: I don't see a task for announcements data client on the Kanban board yet
[18:56:19] <dbrant>	 bearND: I was referring to https://phabricator.wikimedia.org/T140012
[18:59:12] <niedzielski>	 mdholloway: https://github.com/niedzielski/TranslucentActivityDemo
[18:59:25] <niedzielski>	 mdholloway: i think you're just hitting weird style inheritance issues in our codebase
[19:00:25] <mdholloway>	 niedzielski: that sounds plausible
[19:01:02] <niedzielski>	 mdholloway: captured here T146383
[19:01:02] <stashbot>	 T146383: Theme styles should be structured hierarchically - https://phabricator.wikimedia.org/T146383
[19:01:37] <mdholloway>	 i know it should be possible, but i couldn't make it happen in the context of a SingleFragmentActivity (or other similar activity inheriting from (I think) AppCompatActivity)
[19:01:53] <maxbinder>	 bearND: mdholloway just need you
[19:02:33] <niedzielski>	 mdholloway: hm, i'm innheriting from AppCompatActivity. not sure about singlefragmentactivitt
[19:16:50] <mdholloway>	 niedzielski: i'll look at your demo code and try the activity approach once more.  it would certainly easily solve some pesky issues re: orientation changes
[19:18:02] <niedzielski>	 mdholloway: cool. just look at the delta between the first and second patch
[19:18:41] <coreyfloyd>	 dbrant: for the GeoIP header… is there any information on what the official format of the country codes is?
[19:18:47] <coreyfloyd>	 cc bearND ^
[19:35:06] <niedzielski>	 mdholloway: like, the hierarchy is kind of messed up because we have two things we inherit from, the name, "Foo.Bar.Baz", and the parent, parent="Theme.A.B.C", and app theme actually like inherits from light theme instead of the other way around
[19:35:34] <niedzielski>	 singlefragmentactivity does do some stuff with themes and the toolbar IIRC, so there's at least the potential for great confusion
[20:02:53] <coreyfloyd>	 mdholloway: bearND|afk could you check this quick change out when you get a chance? https://gerrit.wikimedia.org/r/#/c/322300/
[20:03:04] <coreyfloyd>	 quick string change
[20:05:01] <mdholloway>	 coreyfloyd: bearND|afk: done
[20:05:18] <coreyfloyd>	 mdholloway: 👍
[20:08:00] <coreyfloyd>	 mdholloway: is there any way you check and see if its cool to do a deployment so I can get that sting change live? bearND|afk said to check with you (he’s at lunch)
[20:08:15] <coreyfloyd>	 i think he just wanted to make sure anything else that was merged was cool to deploy
[20:19:26] <mdholloway>	 coreyfloyd: sorry, missed that, it should be fine, i usually just say something in -operations a few minutes before i do the deployment.  you cool deploying or should i?
[20:19:51] <coreyfloyd>	 mdholloway: would you mind… I havent done one yet
[20:20:10] <coreyfloyd>	 mdholloway: i was learning with bearnd… but we ran into issues that night
[20:20:44] <mdholloway>	 ah i see.  yeah, i'll do a quick deployment
[20:21:21] <coreyfloyd>	 mdholloway: thanks!
[20:24:23] <bearND>	 mdholloway: coreyfloyd : looks like the only other change that made it since yesterday's deploy is a failrly benign hygiene patch
[20:24:57] <coreyfloyd>	 bearND: its fin as long as we can deploy next week
[20:25:08] <coreyfloyd>	 we were just talking about how we couldn’t so was trying to do it today
[20:26:53] <bearND>	 coreyfloyd: ok, just caught up on ops channel. Please cc me and mdholloway when you send the mail to Greg
[20:28:21] <bearND>	 mdholloway: I guess we still could prep the deploy repo. Just don't push it to Gerrit yet until we're ready to deploy
[20:29:04] <coreyfloyd>	 bearND: done and done
[20:29:19] <coreyfloyd>	 bearND: sorry didnt realize small changes were a big deal on fridays
[20:38:36] <dbrant>	 coreyfloyd: I'm not aware of an official list of possible country codes... All I know is that the country code provided in the GeoIP parameter is compatible with the codes used by CentralNotice.
[20:39:08] <coreyfloyd>	 dbrant: ok - yeah its just hard to test “Canada” when I’m not there
[20:39:28] <coreyfloyd>	 just wanted to know if its using some sort of agreed upon abbreviation
[21:58:41] <mdholloway>	 niedzielski: so, it turns out that the leading alpha bits in the color value are respected if i set them in the windowBackground in the theme, but not when i set them in a layout background value in view_description_edit_success.xml
[21:59:06] <mdholloway>	 niedzielski: that and i think i was previously picking up a theme from ThemedActionBarActivity, which SingleFragmentActivity inherits from
[21:59:21] <mdholloway>	 you'd think the *Themed* might have set off a light bulb, but no
[21:59:22] <mdholloway>	 anyway
[21:59:35] <mdholloway>	 all good now :) thanks for the pointers
[22:01:13] <niedzielski>	 mdholloway: weird. i think there's a lot of complexity there (some of it ours, some if android) for something that sounds simple. glad you found a solution that'll work!