[16:27:35] mdholloway: I can file a task for the change-prop issue (unless you're already typing it?) [16:33:42] dbrant: ah, no, i hadn't started yet, go for it! [16:33:46] done [17:41:48] niedzielski: mdholloway: bearND|afk: got a minute for batcave? [17:42:08] dbrant: one min to find headphones and i'll be there! [17:42:27] dbrant: be there in one min [17:43:19] ok i'm there [18:04:06] niedzielski: should i just combine those two patches or are you finding the separation helpful? [18:04:49] i managed to get rid of some of the duplicative boilerplate/cruft in the latest but the relevant changes are in the second half so it might be hard to follow. [18:05:17] mdholloway: checking it out now [18:06:08] mdholloway: i think your approach of making the boilerplate activity / fragment type stuff in the first patch was nice [18:07:04] mdholloway: if it's causing problems though, it won't be any trouble for me to view these patches merged together either [18:08:01] mdholloway: however the patch i was digging into in the meeting is actually this is older one: https://gerrit.wikimedia.org/r/#/c/323177/ [18:09:02] ah i see [19:20:16] phuedx|afk: reinserted the version field as discussed: https://www.mediawiki.org/w/index.php?title=Beta_Features/Hovercards/Functionality&diff=2305664&oldid=2298069 [19:20:54] phuedx|afk: btw regarding the "cardType" addition, is this part of the rewrite or should i create a separate task for it? [19:28:02] HaeB: i can include it in the rewrite -- it's fairly easy to do [19:29:49] phuedx|afk: cool - want me to extend the schema page on meta with a specification for the cardtype field, or do it yourself? (should be straighforward) [19:30:59] HaeB: "generic" and "specific" cool? [19:31:59] phuedx|afk: yes, unless you can think of a better term than "generic" (expressing the notion that these cards are a bit deficient in some way ;) [19:32:16] HaeB: awesome!!1 and awesomer!!1 [19:33:59] ๐Ÿ˜Ž vs. ๐Ÿ˜– [19:38:21] niedzielski: hey are you about to discus https://phabricator.wikimedia.org/T148444 [19:39:12] coreyfloyd: it's merged. is there anything left to do? [19:39:34] niedzielski: im not sureโ€ฆ i was just trying to understand the fixes and the issue [19:40:05] niedzielski: mind hanging out to explain it to me? [19:40:11] coreyfloyd: oh, well it was a feature to add the subject of each news headline to the most read content service response [19:40:19] coreyfloyd: sure [19:40:38] niedzielski: bat cave? [21:08:57] dbrant: mobrovac: the mobile-sections vs. mobile-sections-lead discrepancy is back again [21:09:12] https://en.wikipedia.org/api/rest_v1/page/mobile-sections/Monogram_(company) [21:09:20] https://en.wikipedia.org/api/rest_v1/page/mobile-sections-lead/Monogram_(company)