[16:27:38] raynor: around? [16:29:23] yes [16:29:57] dr0ptp4kt: whats up ? [16:30:11] raynor: wanted to check in on a few things. able to do a google hangout? [16:31:05] yes, sure [16:33:40] dbrant mdholloway bearND : o/ i think gerrit is really messed up. i seem to get emails about new patches but no reviewers are being added. for example: https://gerrit.wikimedia.org/r/#/c/326457/ [16:52:01] jdlrobson: About? [16:52:22] niedzielski: Reviewers are done by a bot... Which may be broken atm [16:52:52] Reedy: ok thanks [16:53:11] https://www.mediawiki.org/wiki/Git/Reviewers [17:35:34] mdholloway: hey, when's the next service deploy? [17:35:58] dbrant: next one scheduled is 4pm today [17:37:28] mdholloway: ok great. (i'll have a tiny patch) [18:40:58] Reedy: hey! yes! [18:45:20] jdlrobson: Can you review that GCI task? :D [18:45:21] <3 [18:45:33] Reedy: which one - ive got a few on my plate [18:45:55] link me up [18:47:34] If RelatedArticles one Reedy im on it [18:51:08] Perfect, thanks [19:46:47] how can i trigger the different between ..org and .m..org on a local vagrant install? useskin=minerva gets half way there, but it doesn't seem to be the same because the resources included are different. I'm trying to test if changing a resource definition to have 'targets' => ['desktop','mobile'] will have the desired effect [19:48:12] ebernhardson: can you click mobile view at the bottom (&mobileaction=toggle_view_mobile)? [19:48:56] checking [19:54:24] niedzielski: that seems to have done the trick, thanks! [19:54:46] ebernhardson: sweet! [20:03:31] ^ i actually often find this behavior flaky in a local vagrant instance [20:03:47] as in, clicking the mobile view link does nothing [20:03:54] i've managed to work around it as needed, though [20:31:53] bearND: mdholloway: just to double-check: /feed/announcements is only used on en.wikipedia domain and nothing will happen if we remove it from the other domains, right? [20:32:27] Pchelolo: well, it's supposed to return an empty array on other domains [20:32:45] but what if it starts returning 404? [20:33:15] I can check the Android code. Not sure how the iOS code would behave [20:33:48] we're going to split out a special project for enwiki in RESTBase and so we can remove the announcements from all the other domain's docs [20:34:23] bearND: Pchelolo: the Android app *should* just omit the announcement card from the feed if that request 404's, but we should test that first [20:34:49] but if we're not entirely sure this won't break the apps I'd better be safe then sorry and not remove it.. [20:34:58] At least make a separate PR for that. [20:39:13] When I wrote https://phabricator.wikimedia.org/T151085 I added that clients should restrict this to enwiki for now and stop sending requests if a 404 is encountered for the announcement endpoint (for the case this endpoint goes away) but it looks like those have not been implemented [20:59:05] bearND: if you agree with putting back the manual blacklist for most-read, want to try to get that into today's deployment? https://gerrit.wikimedia.org/r/#/c/326544 [21:00:06] bearND: actually, that might need a sanity check, don't merge just yet (if you were) [21:00:43] mdholloway: ok, was about to. But it can probably wait until tomorrow, too [21:05:53] bearND: yeah, let's wait on it. it won't take long to fix but it's not not critical. needs updating to work with the $merge nodes [21:05:58] i'll start the deploy prep