[00:16:06] bearND: what are your concerns with surfacing metadata? [00:16:20] my concern with not, is we are giving something inconsistent to the mediawiki api [00:17:00] the information in it is not currently in the response [00:19:25] i can remove it and we can argue it later? [00:43:31] jdlrobson: Oops, sorry, just noticed the ping. I just want to be careful when adding new properties that we really need them. Adding properties later is easy, removing them later is not. [00:43:55] will look more at your updated patch after dinner. [16:18:08] niedzielski: bearND: objections to production push? [16:18:20] dbrant: none [16:18:30] dbrant: checking [16:21:03] dbrant: none! [16:21:10] alright! [18:00:30] niedzielski: pls check out when you can: https://gerrit.wikimedia.org/r/327552 [18:00:43] dbrant: sure thing [21:43:44] niedzielski: regarding https://gerrit.wikimedia.org/r/327558 ... [21:43:53] niedzielski: when you say "Bad subtitle leading is present in these images", are you referring to the apparent exponential increase of line height? [21:44:18] dbrant: yes :] reets spotted that in T152213 which i'm working on [21:44:18] T152213: Long Wikidata descriptions get clipped - https://phabricator.wikimedia.org/T152213 [21:44:36] dbrant: it seems to be an issue in LeadingSpan [21:45:14] niedzielski: ok, just checking; so these patches are g2g then [21:45:57] dbrant: that's right. i really want to be careful with the article header view since it's a little fragile so i wrote tests around it before fixing it [21:46:11] :thumbsup: