[19:39:59] bearND|lunch: in the case you mentioned on the review when getting the old description after returning to the description edit activity, did you go return to the description edit activity quickly, before the page finished loading? [19:40:48] i'm thinking updating title and titleOriginal immediately rather than in the page load callback might fix it, but still have to repro and test [19:41:16] dr0ptp4kt: you in today? [20:15:52] mdholloway: yes, I did it as fast as possible [20:19:58] bearND: OK, that's what I thought. I couldn't reproduce it but I just pushed a patch that I think will fix that [20:20:05] an update, that is [20:55:58] mdholloway: I still see that older description value in the DescriptionEditActivity when i go from the edit success activity to the PageActivity quickly. [20:56:57] bearND: oh, i think i misunderstood earlier. so, after editing you go SuccessActivity- [20:57:13] SuccessActivity->PageActivity->EditActivity as quickly as possible? [20:57:23] I was not hurrying through SuccessActivity [20:57:33] mdholloway: only SuccessActivity->PageActivity has to be quick [20:57:43] the other transition doesn't matter [20:57:54] and is it updated on PageActivity when you get there but not on DescriptionEditActivity, or old on both? [20:57:55] i see [20:57:58] that can be slow of quick [20:58:02] or [20:58:37] It's updated on PageActivity correctly but when re-entering DescriptionEditActivity it shows the previous value [20:59:50] bearND: thanks, i'll try again to repro [21:01:02] mdholloway: actually, the first transition doesn't even have to be quick either. Now I waited 10 seconds and still ran into it [21:03:00] bearND: wait a minute... are you hitting back rather than the done button coming out of the success activity? that might cause this [21:03:04] and it probably shoudn't matter [21:03:37] ok, i think that's what it is [21:03:38] mdholloway: no, i always used the Done button [21:04:55] oh. :( i just repro'd it that way. it's probably wrong to be checking the result code coming out of the success activity in any case [21:25:08] bearND: mind trying once more with the latest? [21:25:52] mdholloway: checking... [21:26:47] maxbinder: yep, i'm in [21:26:56] mdholloway: still the same behavior [21:28:15] bearND: maybe i'll have to try on a different device or something. it shouldn't matter but i'm having a hard time seeing this [21:28:42] mdholloway: I'm just editing the description of the WD sandbox item [21:29:24] mdholloway: I'm using a Nexus 5 with Android 6 on it [21:29:40] oh, where is that? i've been having to test on live articles [21:31:41] mdholloway: on enwiki search for "Wikipedia:Wikidata/" then you should see the Sandox article [21:32:34] mdholloway: I just prepended the description with some letters. I guess now that the layout issues are fixed I could have also put it at the end [21:36:27] bearND: ok, just got it in an emulator [21:36:35] thanks for the pointer to the sandbox! [22:23:29] bearND: ok, i simplified things quite a bit and that seems to have helped. i can no longer reproduce the issue in the emulator i was able to do so with before [22:23:43] the refresh is no more [22:24:09] and a lot less data is getting passed around between activities and fragments. [22:25:33] mdholloway: sounds great. Simpler is better. Sorry, I just got out of a meeting. Will check the updated patch shortly [22:25:44] bearND: sounds good! [22:30:48] mdholloway: The description update looks good now. I see all expected values after the edits. A small annoyance is the screen seems to flash due to the refresh after coming back to the PageActivity. Not sure what can be done about that. But at least the main thing is working correctly.