[18:48:43] dbrant: what action constitutes a reversion for which i should get a notification? this didn't seem to do it: https://www.wikidata.org/w/index.php?title=Q4115189&type=revision&diff=424954913&oldid=424949767 [20:31:06] dr0ptp4kt: in hangout [22:18:28] niedzielski: ah! i was wonder why "mocha --grep eslint" didn't seem to do anything any more! :) https://github.com/montehurd/mediawiki-services-mobileapps/commit/58e2b04d93473afc332d75ffe14539500086951a [22:19:32] :] [22:19:58] niedzielski: oh how do you kick off the linting instead of "mocha --grep eslint" now? [22:20:38] mhurd: i think i normally do npm run -s lint [22:20:52] niedzielski: ah makes sense! thanks! [22:21:15] mhurd: actually, i guess i normally just use my ide to alert to me to issues as i edit and npm test will report any lints missed [22:21:52] mhurd: my ide / text editor is visual studio code (open source) and seems to work out of the box? [22:22:35] niedzielski: it works now, but the first time i tried it from the command line it said to run "npm i eslint-plugin-json@latest --save-dev". after i did that it worked perfectly [22:22:57] niedzielski: oh i'm using Atom [22:22:59] mhurd: oh, i think you just need to do a fresh npm install [22:23:19] so `npm i` [22:23:22] niedzielski: oh that's right! i probably didn't do that after pulling your changes the other day [22:25:09] niedzielski: hey thanks again for the code review!! [22:25:43] mhurd: oh np man!