[17:21:11] <bearND>	 mdholloway: There's now an MCS patch to remove the titles in the href from reference links: https://gerrit.wikimedia.org/r/#/c/332423/. I also have another patch to fix the tests.
[17:23:53] <mdholloway>	 bearND: cool, i'll have a look
[19:41:56] <mdholloway>	 niedzielski: dbrant: account creation seems to be broken on all versions of the app.  looks like captcha retrieval is messed up somehow.
[19:42:14] <dbrant>	 :.(
[19:43:13] <niedzielski>	 geez, i can repro that :|
[19:44:05] <mdholloway>	 looks like the url from authmanager may have changed...  although it would be odd for that suddenly to go live on all wikis at the same time, without notice...
[19:45:39] <mdholloway>	 nope, that's not it
[19:45:44] <niedzielski>	 i cannot create an account on wikipedia.org?
[19:46:26] <niedzielski>	 ah, capcha got me twice!
[19:46:52] <mdholloway>	 i've gotta switch IPs, getting throttled now :(
[19:54:38] <jdlrobson>	 mdholloway: around?
[19:54:53] <mdholloway>	 jdlrobson: o/
[19:55:09] <jdlrobson>	 So was about to merge your patch https://gerrit.wikimedia.org/r/#/c/325044/ but noticed apihelp-query+pageimages-param-prop needs updating
[19:55:14] <jdlrobson>	 so it shows up in http://localhost:8888/w/index.php/Special:ApiSandbox#action=query&format=json&prop=pageimages&titles=Hannah+Montana&pithumbsize=50
[19:55:29] <jdlrobson>	 are you able to quickly fix that before i merge?
[19:55:52] <mdholloway>	 jdlrobson: sure, i'll have a look
[19:58:03] <niedzielski>	 mdholloway: is there a ticket for the account creation bug or should i make one?
[19:59:42] <mdholloway>	 niedzielski: not yet afaik, have been trying to quickly track the cause down but no luck so far, if you wouldn't mind making a phab that would be splendid!
[20:00:09] <niedzielski>	 mdholloway: sure thing. thanks! i'll cc you on it
[20:13:44] <mdholloway>	 niedzielski: were you testing manually when you were looking at my account creation series a couple hours ago?  i know account creation was working as recently as yesterday afternoon
[20:29:04] <mdholloway>	 jdlrobson: patch updated! https://gerrit.wikimedia.org/r/#/c/325044/
[20:33:42] <niedzielski>	 mdholloway: i don't believe i tried of the new patches so i think that's independent of this issue
[21:21:55] <jdlrobson>	 mdholloway: on it
[21:22:48] <jdlrobson>	 mdholloway: doesnt seem to be showing on https://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&format=json&prop=pageimages ?
[21:22:54] <jdlrobson>	 ahh en.wikipedia.
[21:22:56] <jdlrobson>	 not localhost
[21:55:58] <niedzielski>	 mdholloway: i saw your commonet on T155535. do you think this is an image lib / cookie issue? it seems more like the initial request for a captcha is misunderstood
[21:55:58] <stashbot>	 T155535: Account creation fails - https://phabricator.wikimedia.org/T155535
[21:57:20] <mdholloway>	 niedzielski: i'm really not sure.  it does seem to be fresco-specific.  beyond that...?
[21:57:44] <mdholloway>	 fresco's logging isn't particularly helpful, either
[21:57:49] <niedzielski>	 mdholloway: on my device, i don't even get a broken image. i just get the snackbar and never even attempt to show an image
[22:00:44] <niedzielski>	 mdholloway: actually, the only place i see captchas even being requested is in the onclick listener for the refresh captcha button
[22:02:38] <mdholloway>	 niedzielski: yeah, fresco's own requests don't show up in logcat (assuming it's happening here at all -- i played a little bit with fresco's logging as directed at http://frescolib.org/docs/troubleshooting.html#using-the-logcat but not much help)
[22:10:29] <niedzielski>	 mdholloway: i tried the fresco patch on top of master with a local vagrant install (with captcha) and it still seems to fail for me
[22:10:54] <mdholloway>	 niedzielski: the picasso patch?
[22:11:18] <niedzielski>	 er, sorry, yes. this guy: https://gerrit.wikimedia.org/r/#/c/332647/
[22:27:31] <mdholloway>	 niedzielski: i just verified again that the picasso patch loads the captcha on prod enwiki
[23:42:06] <mdholloway>	 niedzielski: well here's something interesting
[23:42:28] <mdholloway>	 seeing this, i decided to try to repro on a api 16 nexus S emulator: https://github.com/facebook/fresco/issues/1041
[23:42:41] <mdholloway>	 and captcha loading works fine in that emulator
[23:42:47] <mdholloway>	 so we might have something device specific
[23:42:50] <niedzielski>	 neat!
[23:42:55] <niedzielski>	 if i set the image as initially visible, it doesn't load but re-tapping does load it
[23:42:55] <mdholloway>	 I've been on my 6P
[23:43:47] <niedzielski>	 me too
[23:43:57] <niedzielski>	 i was wondering if it was some variation of this though: https://github.com/facebook/fresco/issues/1430 (not quite the same thing)
[23:45:09] <mdholloway>	 niedzielski: also, via a random redditor: "P.S. The way to use Fresco "wrong" is by using it."
[23:45:18] <mdholloway>	 lol
[23:45:30] <niedzielski>	 :]
[23:48:00] <mdholloway>	 niedzielski: i'm trying to get over a post-travel cold so I think I'm going to call it a day, but at least it looks like we have some good leads.
[23:48:27] <niedzielski>	 mdholloway: sounds good. see ya tomorrow!
[23:48:32] <niedzielski>	 btw, what i'm trying to figure out is whether images will load if their visibility is GONE
[23:49:05] <mdholloway>	 niedzielski: ooh... good question.
[23:49:30] <mdholloway>	 niedzielski: see you tomorrow!
[23:49:36] <niedzielski>	 o/