[01:04:36] <bmansurov>	 nzr: yt?
[01:04:47] <nzr>	 bmansurov: yes!
[01:05:05] <bmansurov>	 nzr: i have a couple of questions regarding https://phabricator.wikimedia.org/T152459, got a minute?
[01:06:05] <nzr>	 bmansurov: yeah sure
[01:06:20] <bmansurov>	 nzr: are the widths of the logo and the search bar fixed?
[01:06:41] <nzr>	 yes
[01:06:52] <bmansurov>	 nzr: what are the dimensions?
[01:07:03] <bmansurov>	 nzr: also, we expect every logo to fit in the space, right?
[01:07:32] <nzr>	 oh.. actually the logo basically has fixed height and flexible width. my bad. 
[01:07:50] <nzr>	 but you can definitely add max-width
[01:07:51] <bmansurov>	 nzr: ok what's the width of the search bar?
[01:08:05] <nzr>	 and use ellipses if the name of the wiki is too long
[01:09:03] <nzr>	 max width can be around 160px
[01:10:03] <bmansurov>	 cool
[01:10:07] <bmansurov>	 nzr: search bar width?
[01:10:24] <nzr>	 375 as in zeplin
[01:10:35] <bmansurov>	 nzr: thanks
[01:11:27] <bmansurov>	 nzr: one more thing: how much space is there between the logo and the search bar?
[01:11:45] <bmansurov>	 nzr: i know it varies but at least how much?
[01:12:19] <nzr>	 the min margin should 15
[01:12:38] <bmansurov>	 k
[16:14:16] <niedzielski>	 dbrant: o/ i don't think it causes any harm but i wasn't sure if this notification unmarshalling exception was expected: https://phabricator.wikimedia.org/P4794 . the issue is that an MwQueryResponse may be successful or not so @Required doesn't really work for the error case
[16:15:30] <dbrant>	 niedzielski: ah thanks; will have a look
[16:16:23] <niedzielski>	 dbrant: i don't think it's likely to break anything, just a caveat of @Requried
[16:36:02] <mdholloway>	 dbrant: niedzielski: how frequently do we look at event logging for MobileWikiAppAppearanceSettings?
[16:36:46] <dbrant>	 mdholloway: not much at all
[16:36:55] <niedzielski>	 i haven't looked at it recently
[16:37:24] <mdholloway>	 dbrant: i'm asking because i was thinking of making a third theme, Theme.GALLERY, that just inherits from DARK and updates the background color to black
[16:37:31] <mdholloway>	 but there's some EL logic involved with the Theme class
[16:37:52] <mdholloway>	 but it seems like a pretty stagnant data source, like something we don't use much these days
[16:38:30] <mdholloway>	 dbrant: or i could always just set a new background color in GalleryActivity after setTheme()
[16:38:57] <mdholloway>	 but if there's a task in here to audit our funnels and removed unused once it might be a good opportunity to phab it at least
[16:39:09] <mdholloway>	 s/once/ones
[16:39:35] <dbrant>	 +1 for background color
[16:43:00] <mdholloway>	 dbrant: done!  
[16:43:24] <mdholloway>	 dbrant: also, for T149915, looks like i'll need to create a new schema revision -- correct?
[16:43:24] <stashbot>	 T149915: Instrument eventlogging for description editing - https://phabricator.wikimedia.org/T149915
[16:44:43] <dbrant>	 mdholloway: yep, that's right. let me know if you want to chat about any specifics and/or logic.
[17:21:46] <sandaru>	 dbrant: Regarding the renaming the ArticleHeaderView to PageHeaderView, I have some more clarifications. Should ArticleHeaderImageView be changed to PageHeaderImageView too? Apart from Article header view there are other resources like view_article_header_image.xml, strings like article_header_hint , menus like menu_article_header_edit.xml. I should change them too right?
[17:24:05] <dbrant>	 sandaru: all of those things, except string resources. thanks!
[17:26:32] <sandaru>	 dbrant: thank you very much for the clarification!
[18:01:55] <sandaru>	 dbrant: one last question. In the commit message, the phabricator task id should be present, according to this https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines 
[18:02:26] <sandaru>	 In the example they have given the task id of a bug. So it goes like Bug: T169
[18:02:27] <stashbot>	 T169: Create a Gerrit plugin to notify Phabricator tasks about related patches - https://phabricator.wikimedia.org/T169
[18:03:06] <sandaru>	 But here since it is not a bug, What should I include?
[18:03:22] <sandaru>	 Should it go like Task: T169?
[18:03:45] <dbrant>	 sandaru: Yes, the syntax is to say "Bug:" in all cases, even if the task is not strictly a bug.
[18:04:30] <sandaru>	 dbrant: Okay. Thank you very much for the clarification
[20:09:39] <mdholloway>	 dbrant: for logging the editing 'start' action, do we want to log the event when the preliminary steps (login verification and possibly the tutorial) are complete and the editor is about to be launched, or at the time the user initially chooses to edit a description and before the preliminaries?
[20:11:15] <dbrant>	 mdholloway: i think it's ok to log it only when the actual editing activity is launched. (i'm guessing that's simpler, too)
[20:12:15] <mdholloway>	 dbrant: sounds good, thanks!
[21:41:12] <matanya>	 dbrant mdholloway thanks for the 2fa patch, tested. working well for me
[21:41:18] <matanya>	 cc niedzielski ;)
[21:41:39] <niedzielski>	 yay! :]
[21:41:49] <mdholloway>	 matanya: you're welcome!  glad to hear it's working well.
[21:42:23] <matanya>	 now add notifications and i won't need mobile web anymore :D
[23:15:50] <mdholloway>	 dbrant: any objection to zapping the userId field from https://meta.wikimedia.org/wiki/Schema:MobileWikiAppEdit and updating the EL patch?
[23:18:02] <dbrant>	 mdholloway: none. As long as we use the editSessionToken to follow each individual session
[23:18:33] <mdholloway>	 dbrant: great.  yep, that appeared to be working well when i was testing earlier
[23:19:28] <mdholloway>	 dbrant: events also appeared to be getting double-logged, but as i understand it that's an ongoing issue with EventLogging itself, not our app