[00:57:42] jdlrobson: is this event setup ok for you? https://phabricator.wikimedia.org/T145829 [00:59:56] coreyfloyd: hey [01:00:15] jdlrobson: yo yo [01:01:06] coreyfloyd: so tbh im not 100% sure right now and i've not been following too closely [01:01:36] i'm not in a rush right now to incorporate ores as i'm not sure to what extent it would help (would it give me a score for the current state of the page? A change in score? Or a score for the edit itself? [01:02:13] because if someone enters the text "Corey is a ninconpoop" into a featured article will I be able to see a change in ORES score? [01:19:11] jdlrobson: its ok if you dont want to do it yet… just need to make sure the events are bale to be used by you [01:20:40] jdlrobson: (sorry got caught up in something) Since they are planning Review Stream now I want to make sure that it is planned in a way that works for the Trending Service [02:31:51] jdlrobson: oh to answer your question: you can get a score for the current state of the page, and the edit… and if you want the difference… [02:32:52] jdlrobson: but the way Review Stream is being proposed to work is that there will be a separate event for the edit and the score… because the score is delayed. My thinking is that you can just listen for the ORES score event and then get everything you need then [17:55:18] mdholloway: hey - hate to distract you, but could get some help today on this code review and deployment with Bernd out sick https://gerrit.wikimedia.org/r/#/c/336358/ [17:55:40] coreyfloyd: sure thing, looking now [17:55:56] mdholloway: thanks! [17:57:10] coreyfloyd: mdholloway : see my comment on https://phabricator.wikimedia.org/T156419. I think the button text is a tad long IMO. [17:58:28] bearND|afk: thanks, but since its what design/product wanted I wasn’t going to look in to change unless it breaks layout [17:58:33] mdholloway: ^ [17:58:52] coreyfloyd: ah, just commented on the task [17:59:12] i think "user" can come out (what other kind of testing would a user be doing) but design's the boss [17:59:17] mdholloway: thanks FWIW carolyn already approved the screen shot in the iOS app [17:59:38] and actually made some text changes [18:17:38] coreyfloyd: bearND|afk: anything else you wanted to get deployed today? [18:17:43] or reviewed for, etc. [18:18:19] thats the only thing pressing [18:18:23] mdholloway: ^ [18:19:41] coreyfloyd: cool, i'll get this deployed when the time comes [18:24:01] mdholloway: 👍 🙏 [19:07:59] mdholloway sorry late breaking change: https://gerrit.wikimedia.org/r/336662 [19:08:15] coreyfloyd: yep, saw the emails, pulling it up now [19:56:56] dbrant mdholloway: any objections to starting another beta? testing has gone well so far [19:57:13] niedzielski: nope! let's go for it [19:57:18] yesss [20:15:53] coreyfloyd: any objection to my merging https://gerrit.wikimedia.org/r/#/c/330820/ and getting it deployed today too? [20:16:57] mdholloway: nope. Just didn't want to push for it with bernd out [20:17:11] But if it's ready let's do it! [20:48:01] Hey, FYI - I've updated nodejs to 6 on appservice.wmflabs.org - we've forgot about it before [20:49:15] Also, this patch: https://gerrit.wikimedia.org/r/#/c/330820/ introduced some syntax supported only on node 6, on node 4 the service doesn't start any more [20:49:33] might be worth fixing, we didn't deprecate node 4 support across the services yet [20:55:12] Pchelolo: thanks, i'll check it out [20:56:08] thank you mdholloway [21:03:44] HaeB: I've tracked down the source of the `wiki` parameter issue, and will be patched by next update. [21:13:32] dbrant: \o/ [21:22:18] Pchelolo: i was thinking i'd just deploy up to HEAD^ but i'm not sure if that's possible. is there a parameter or something i can use with ./server.js build --deploy-repo to do that? [21:22:58] mdholloway: unfortunately it's not supported [21:23:02] just building with that commit checked out didn't work, unfortunately [21:23:10] Pchelolo: guess i'll have to revert... [21:23:27] mdholloway: revert what exactly? [21:24:04] Actually it's a nice to have feature to build deploy repo up until a specific commit in the source repo. I'll file a task for supporting that [21:24:47] Pchelolo: the "on this day" endpoints patch https://gerrit.wikimedia.org/r/#/c/330820/ -- i'm guessing it's some of the syntax here (https://gerrit.wikimedia.org/r/#/c/330820/21/routes/on-this-day.js) that's node 6-specific [21:25:03] Pchelolo: seemed like a little much to try to patch in a hurry before deploying [21:26:00] works for me either way.. If it's a couple of LOC to fix I'd try to fix that though [21:26:00] Pchelolo: cool, thanks for filing, that would be a good feature :) [21:41:01] Pchelolo: https://gerrit.wikimedia.org/r/#/c/336699/ [21:49:46] Pchelolo: thanks for merging! deploying shortly [22:13:24] mdholloway dbrant: i just merged that eventlogging patch (thanks dbrant and HaeB!) but i'd like to get in the notification patch just pushed as well. would one of you mind taking a look when you get a chance? [22:15:19] by the byte, there was some talk about a corrupted wikipedia toolbar logo a long time ago where letters are missing. i can't remember who mentioned it but i finally repro'd it. it's on a device that frequently loses images in the webview so i think it's an out of memory issue [22:58:04] i surprised there haven't been any "don't keep activity" lifecycle exceptions lately. looking good on that front so far [23:03:08] Pchelolo: https://en.wikipedia.org/api/rest_v1/feed/announcements seems to need a purge somewhere, the new content still isn't appearing [23:03:25] it looked good in an internal request from tin [23:04:32] one moment mdholloway [23:04:55] kk [23:19:04] dbrant|brb: coreyfloyd: JoshM: announcements content is up: https://en.wikipedia.org/api/rest_v1/feed/announcements [23:21:35] dbrant mdholloway: release notes cooking in the usual place :] [23:21:59] dbrant|brb: niedzielski: if we're looking for a way to improve the random card in the feed, is it out of the question to go back to a full featured-article type card? i know there was some user research saying it was confusing to people but that's still how it is in the iOS app and as a user i personally really like it [23:22:25] niedzielski: cool, looking [23:23:16] mdholloway: if you're talking about the delay between tapping the button and seeing a result, does the ui matter? we could have a full featured article card model just not show it until the user taps it [23:23:53] niedzielski: i was talking about no tap required, the random card just shows up like any other [23:24:04] mdholloway: if we had a dice button on the bottom of the card for another random entry so i could still get my "play the odds fix", i think showing an article inline would be awesome [23:24:17] oh, i like that idea [23:25:08] mdholloway: 👍 thanks for deploying [23:32:23] mdholloway dbrant: should be done in a bit. all's well so far [23:37:02] niedzielski: i know we've had a couple more volunteer patches than that, were they not interested in shout-outs? [23:38:13] (i'm checking gerrit) [23:38:27] mdholloway: since the last release, the list of volunteer patches is generated by step 8 here: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Release_process#Beta_release [23:42:45] one volunteer declined, another never responded [23:46:15] niedzielski: ah, that's better, i knew it was generated along these lines but only saw the one name (the discoverer) before, maybe you hadn't gotten there yet [23:46:56] mdholloway: oh, sorry :] right, i didn't fill out the reference information yet, just the commits [23:50:10] oh man. just went to the wikipedia page for shrub. this is like a glamour shot of shrubbery. where i live, a more realistic photo would be of a bush eating a mailbox and taking on the sidewalk [23:52:55] mdholloway: purged finally, we've has some issue with the script.. [23:54:08] Pchelolo: thanks! it showed up a while ago on my end