[00:13:55] mdholloway dbrant: just uploading files and updating descriptions. once the google test results come back, we're ready to publish tonight / tomorrow [10:48:16] rdg [14:53:32] dbrant mdholloway: release is good to go on my end. please check the release notes when you get a chance [14:53:43] looking! [14:56:05] niedzielski: release notes look good to me [15:18:41] niedzielski: lgtm [15:19:56] 👍 [15:20:08] Not sure if I asked, but when does this go live? https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Wikipedia_Android_app_store_description/sr [15:23:39] srdjan_m: o/ which feature specifically? i think this is already in store [15:25:28] I meant the translations. [15:25:34] Does seem to be live right now https://play.google.com/store/apps/details?id=org.wikipedia&hl=sr [15:29:06] 👍 [15:29:22] srdjan_m: ah, I hadn't noticed that those translations have been updated! The problem is that they don't get synced automatically to the Play Store; we have to copy/paste them manually. We'll get them in there shortly. [15:30:20] niedzielski: do you want to paste those in, or shall I? [15:30:24] I also imported the translations for the Android app in bs on TranslateWiki that I had been working on offline. Guess they're gonna be available on the next release. [15:31:02] dbrant: go for it. about to drop the hottest beta of 2017 [15:31:14] srdjan_m: those are indeed synced regularly. [15:31:40] I got the MoreLocale thing to test them out until there's a fix to be able to change languages independently of the system language. [15:31:55] Can the release notes be translated? [15:37:34] They can, but given the timing of our release process, it's not really practical to wait for a sufficient number of language translations before issuing a release. [15:42:55] niedzielski: dbrant: i just did a search-and-replace that seems to have had the side effect of adding a newline to the end of every java file in our repo that doesn't currently have one. keep it? [15:43:57] mdholloway dbrant: i don't feel strongly about this [15:44:10] me neither [15:45:15] cool, i'll leave it in the patch then [15:47:36] Also, is Bosnian available in the "Add your own translations" list in the Android Developers Console? Last time I had access to it, it was not. [15:49:30] Just so I know if I should translate it on that page on MW. [15:55:21] srdjan_m: Bosnian doesn't seem to be available. [15:55:42] Thanks for checking. [16:24:49] dbrant mdholloway: 7 folks with a nosuchmethod error on this apache commons method, removealloccurrences(): https://rink.hockeyapp.net/manage/apps/226650/app_versions/79/crash_reasons/156658637 [16:25:26] i just rebuilt a release version of the app and ArrayUtil.s.removeAllOccurences is not stripped [16:25:58] i also put in some dummy code to call the method in a release build and that works fine too [16:26:42] the trace says "(declaration of 'org.apache.commons.lang3.ArrayUtils' appears in /system/framework/framework.jar:classes2.dex)" so i'm wondering if the oem put a different version of ArrayUtils in the system path [16:32:08] sounds plausible, and HA backs it up. [16:37:26] another person with this issue: https://github.com/jamesagnew/hapi-fhir/issues/394 [16:37:39] (solved by using a local function) [16:44:56] nice. got a patch going [17:23:07] Hello all. I just wanted to clear a little doubt i have about using the wikipedia app in a custom rom [17:24:24] Is the app supposed to work correctly in a custom rom such as cyanogen mod? [17:25:54] kaartic: there's no reason it wouldn't work [17:26:26] kaartic: if the API level is 16 or above, yes [17:26:31] mdholloway dbrant: bug fix release or wait a bit? looks like 13 people have seen the removeAllOccurrences() issue [17:26:58] mdholloway dbrant: (BTW looks like the IRC bridge is down on my normal client so gonna use this screen name for a bit) [17:27:54] I have flashed cyanogen mod 11(android 4.4.4) in my device (for an unavoidable reason) and the app doesn't seem to be working well in it. I couldn't use the app for about 2 minutes continuously. It's crashing repeatedly. [17:28:42] kaartic: eek. do you know which version of the app? [17:30:28] kaartic: i have a samsung galaxy s3 with CM 11 and the app has no problem. :( which device are you using, out of curiosity? i'd guess it's not CM that's the issue [17:30:34] Both the alpha(2.5.187-alpha) and the latest beta version (2.5.187-beta) [17:31:44] I have a samsung galaxy s duos 2 [17:32:15] niedzielskii: looks like that's the only crash that's not OOM or in native code, eh? i'd maybe give it another few hours to see if anything shakes out but then go for it [17:32:22] only crash *so far [17:33:04] mdholloway: this is cm 4.4.4 https://rink.hockeyapp.net/manage/apps/226650/app_versions/79/crash_reasons/156667338?type=crashes [17:33:09] mdholloway: oom [17:36:19] kaartic: by any chance was it you who reported the weird issue with letters missing in the wikipedia logo? [17:37:24] niedzielski: yes. But that was when the stock rom was working good [17:38:24] I started using cyanogen because the stock rom started failing and i was unable to use it anymore [17:39:24] kaartic: i finally repro'd that issue yesterday (also on API 19 ). i see missing images in the webview and i suspect it's due to out of memory errors [17:41:11] niedzielskii: hmm. It seems the memory's starting to come into picture. [17:41:47] BTW Could the log output be of any use to detect the error? Moreover, is it worth finding the problem, anyway? [17:43:13] kaartic: i'd be happy to examine your log to confirm the issue. i think the hockeyapp crash reports strongly suggest an out of memory issue [17:52:16] niedzielskii: thank you. I'll let you know when i get them ready. [18:31:41] * mdholloway recalls https://github.com/facebook/fresco/issues/1363 [19:37:53] if anyone is looking for something to listen to: https://www.youtube.com/watch?v=eVrAx3AmUvA [19:50:57] niedzielskii: I have created pastes in phabricator for the logcat outputs that i got during the crash. You could find them at https://phabricator.wikimedia.org/P4919 and https://phabricator.wikimedia.org/P4920 [19:51:32] kaartic: thanks! [19:52:37] you're welcome. The first one is a bot too long and was obtained when the app crashed and restarted to show the "We're sorry, the Wikipedia app ..." message. [19:53:18] The second one is a bit shorter and was obtained when the app crashed but didn't restart. [19:53:32] kaartic: the second one is an out of memory error [19:53:57] kaartic: were you typing text in the first one when it crashed? [19:54:40] kaartic: we submitted a workaround patch to try to gracefully handle the out of memory scenario you experienced. it will only prevent crashing in production (not beta or alpha) and you may still see a crash if you run out of memory somewhere else [19:54:43] niedzielskii: i can't remember exactly. I guess i was typing something into the search bar. [19:54:55] kaartic: hm [19:55:44] kaartic: was the first crash on today's beta? [19:56:07] niedzielskii: both of them were on today's beta [19:57:19] niedzielskii: so, could i use the production release without much trouble in my device? [19:58:00] kaartic: hm, i wonder why our crash report service didn't break out the nullpointerexception in the first crash you saw. it looks like it was reported from the device's perspective [19:58:52] kaartic: you might still see spurious errors. one thing you will see is that face detection in pictures fails when there's no memory so articles with misaligned photos won't be centered [19:59:31] kaartic: sorry, gotta hop into a meeting. i'll try to dig into that first crash you saw more. very odd [20:00:04] niedzielskii: ok. i'll catch you later. [20:00:15] kaartic: thanks for the help! [20:03:04] niedzielskii: i'm the one who should be thanking for your support. Thanks! [20:03:28] kaartic: not at all :] thanks again! [20:03:36] phuedx: o/