[16:35:28] niedzielski:hello [16:39:03] niedzielski: you told that day that face detection is used to center images in the app. Is it used to center lead images of articles too? [17:36:10] joewalsh tgr coreyfloyd bmansurov niedzielski i rescheduled reading tech leads meeting to today, in order to avoid a schedule conflict tomorrow. thx coreyfloyd for noticing we had a meeting conflict [18:29:44] mdholloway: hi there [18:30:09] kaartic: o/ sorry, i've been in meetings! yes, that is correct [18:30:15] dr0ptp4kt: sounds good [18:30:30] thx niedzielski [18:30:32] niedzielski: have some regressions from last alpha release [18:30:49] would put them on phab shortly, but would love a verification before [18:31:54] matanya: sure and thanks! i have a meeting for the next half hour but can follow up thereafter [18:32:12] niedzielski: great, i will be around [18:52:41] Hi, I'm quite a bit new to Android! I see some easy phabricator issues around "Retrofit" here https://phabricator.wikimedia.org/maniphest/query/0pQOZawilr3q/. I'm not sure where to start & what is the task expected in these issues? It would be helpful if someone kindly direct me to wiki pages or related solved issues. Thanks! [18:56:22] dbrant: ^ [19:06:06] matanya: ok, please share what you've found! [19:07:16] niedzielski: 1) 2fa breaks after one edit [19:07:32] it asks you to log out and back in after every edit [19:07:47] 2) editing desc stopped working [19:08:42] matanya: is this alpha from the last day or two? [19:09:00] 2017-02-10 [19:09:09] @HaeB will you be in the office today? I have some reading depth questions [19:10:39] 3) I don't think it is a regression, but when system lang is set to rtl and i search in ltr lang, all the results are aligned to the wrong dir [19:10:40] jdlrobson: yes - can we chat sometime after 2:30pm? (busy with other things until then) [19:10:48] happy to dig into this in any case [19:11:55] sure. [19:15:41] 3) i don't think this will fully cover your issue if you want LTR results to align on the left and RTL to align on the right but T142019 blocks it [19:15:42] T142019: App language should replace system language - https://phabricator.wikimedia.org/T142019 [19:15:46] oops that should say 3 [19:17:09] mdholloway dbrant: can you verify matanya's 2fa edit issue (edit twice and make sure it works)? i'm having issues with my account [19:17:40] will try [19:17:48] thanks [19:17:56] thanks niedzielski / dbrant [19:17:58] niedzielski: yeah, will look into it. [19:19:47] matanya: 2 i can't seem to repro an issue when editing descriptions. maybe this is a complication with 1 [19:20:00] probably [19:23:40] vbar o/ [19:24:00] sorry, these Retrofit tasks should have contained the following addendum "This task isn't quite 'Easy' but it's a good candidate for volunteer contributors looking to get more familiar with the codebase, MediaWiki API, and unit tests" [19:24:24] if you're new to android, i recommend picking one of the non-retrofit Easy tasks [19:27:10] if you haven't already, i recommend checking out our getting started guide: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Wikipedia_Android_app_hacking [19:28:58] and here's a quick link to our easy board: https://phabricator.wikimedia.org/project/board/489/query/CUdtv7rO0Rkw/ [19:32:15] geez, we need to identify more Easy tasks [19:32:50] can't seem to reproduce the 2fa issue... [19:33:13] niedzielski: when logged in with a 2FA account i cannot edit descriptions either [19:33:23] the 2FA login needed notice appears [19:33:42] i was able to make section edits one after another with no problems though [19:33:52] dbrant: matanya: ^ [19:34:15] mdholloway: anything telling in the logcat? [19:34:15] interesting [19:34:44] in any case, we need to refine how our token retrieval mechanisms interact with a user logged in with a 2FA-enabled account [19:37:04] this is one of those times it would be awfully nice to have one true login pipeline rather than having similar logic repeated in three places [19:38:39] i can refine the report [19:39:13] i am showed as logged in the main activity, but when i try to edit i get the 2fa alert [19:52:32] ah, i'm able to reproduce now. I wasn't on the latest master. This is likely the result of our latest patch to explicitly refresh the edit token [19:54:02] yep [19:55:01] regular section editing is working because we don't explicitly refresh the token on every edit. [20:20:23] dbrant: niedzielski: should we roll back https://gerrit.wikimedia.org/r/#/c/337054, then? do we know for a fact that it fixed T157810? [20:20:24] T157810: "An unknown error occurred" when trying to save a description while logged in - https://phabricator.wikimedia.org/T157810 [20:21:02] mdholloway: niedzielski: can we batcave for a minute? [20:21:13] sure [20:21:22] omw [21:00:18] Please let me know if any help is needed on my part dbrant / niedzielski /mdholloway [21:01:37] thanks matanya! [21:01:50] :) [21:27:43] bearND: will you be deploying MCS? [21:27:49] or mdholloway [21:28:08] i.e. will the route name change happen? [21:28:13] today, that is [21:28:17] mobrovac: i am doing it right now on beta cluster [21:28:21] * mobrovac is still digesting food [21:28:29] awesome, thnx bearND [21:30:04] mobrovac: Will do in a bit on prod. Just wanted to verify in beta first locally. What's the port number in beta? 8888 doesn't seem to work there [21:34:18] bearND: 6927 [21:43:33] mobrovac: Pchelolo : MCS change is deployed in prod as well [22:35:28] bearND: hm... It seems the links are incorrent for 'onthisday' endppint in production [22:36:03] the `$merge` links have a 'wiki%2F' prefix [22:37:51] Pchelolo: ohoh, that looks familiar ;( [22:38:24] bearND: I've been in the process of RB deploy when noticed that [22:38:40] only got through staging env, will rollback for now [22:39:48] could you have a look into this, I'd like to fix the MCS and continue deploying RB [22:41:35] Pchelolo: sure [22:41:51] cool, thank you.