[03:31:59] https://twitter.com/pattaprateek/status/848055320505012225 [17:01:27] is it okay for editing file in gerrit for a trivial change? [17:11:04] hlakhara: that's probably fine. i normally only edit commit messages but other folks are more comfortable with gerrit [17:15:30] niedzielski: thanks. published the edit. :] [17:15:55] hlakhara: great! thanks [17:17:16] combined apps standup happening now 💥 [19:26:10] niedzielski: hey have some time to chat this afternoon or tomorrow? [19:27:06] mhurd: sure [19:28:50] niedzielski: i don't have many meetings in either case so whatever's convenient for you probably works for me [19:29:28] mhurd: i can do any time today but would prefer tomorrow if it's not pressing [19:29:39] niedzielski: works for me! [19:29:51] niedzielski: (tomorrow morning) [19:30:23] niedzielski: if you have a morning slot [19:30:37] mhurd: sounds good! feel free to block off time or just ping me [19:30:49] niedzielski: k i'll throw an invite your way [19:31:04] 👍 [19:32:37] niedzielski: sent. feel free to adjust time as needed [19:33:15] mhurd: looks good! [19:38:09] niedzielski: in mean time i may take a stab at a another transform consolidation - the redlinks one is super simple [19:39:09] mhurd: go for it! [20:00:32] nzr: I invited you back into the channel, please let me know if you can't get in [20:00:41] maxbinder: nope [20:38:29] Hi, is there a way to avoid that when accessing Wikipedia from your mobile device, you always get forwarded to the mobile site first? Is there a setting for this? [20:38:47] The user reporting this issue would like to browse Wikipedia in desktop view from his tablet, but reports that everytime he goes to Wikipedia, he is forwarded to the mobile page and first needs to scroll down to change back to the desktop version. [20:41:34] I think there's a cookie for that [20:41:43] he is probably not keeping it [20:48:35] Platonides, stored for longer than a session? [20:50:52] not sure for how long the server sets it [20:51:01] nor how his tablet treats them [21:49:33] bmansurov: hey do you know where the css for the iOS app is maintained? https://en.wikipedia.org/w/load.php?debug=false&lang=en&only=styles&skin=vector&modules=skins.minerva.base.reset|skins.minerva.content.styles|mobile.app.pagestyles.ios [21:49:41] or jdlrobson ^ [21:51:29] coreyfloyd, not sure, let me see if I can find it [21:54:24] bmansurov: thanks! [21:54:57] bmansurov: could this be it? https://github.com/wikimedia/mediawiki-extensions-MobileApp/blob/6bbc4b4cc68c4f8ab9a6017f63961cc0b5a0064c/extension.json [21:55:44] coreyfloyd looks like so [21:56:13] bmansurov: thanks… I can’t find a media wiki page for that extension -I guess there just isn’t one? [21:56:38] perhaps, let me see if it's mentioned in the readme file [21:57:24] https://www.mediawiki.org/wiki/Extension:MobileApp coreyfloyd ? [21:57:42] bmansurov: thanks… missed that [21:57:51] np [22:20:55] niedzielski: does the android app only use styles in the Android directory here? https://github.com/wikimedia/mediawiki-extensions-MobileApp [22:22:59] coreyfloyd: there are styles that come with the article and soon to be styles in applib but mobileapp currently contains all the overrides for android. monte and i are hoping to deprecate it (email coming soon) [22:23:15] niedzielski: thanks [22:23:55] coreyfloyd: the android directory has android specific overrides but still uses the non-platform specific styles [22:24:18] niedzielski: got it… and you still have some code within the Android repository as well, right? [22:24:36] I mean i know you have JS… but you also have CSS I mean [22:25:48] coreyfloyd: we do but those come from upstream https://phabricator.wikimedia.org/diffusion/APAW/browse/master/scripts/make-css-assets.bash [22:26:04] coreyfloyd: the css files you see in the android repo are just build products of that scripts and bundled statically with the apk [22:26:15] that script* [22:26:47] niedzielski: got it… I think the iOS app I believe has a few more that are not in that repo but need to check to be sure [22:27:18] coreyfloyd: that's right. mhurd's accounting for that in consolidation of the widen images logic currently, for example [22:32:20] coreyfloyd: css not from upstream mobile web and not directly tied to a specific js transform should probably be DRY'ed up between iOS and Android too, but probably after JS transform consolidation... lots of moving parts just with JS consolidation atm [22:33:06] mhurd: thanks… no worries, I’m just trying to succinctly document where all of these things live [22:33:13] coreyfloyd: cool cool [22:50:00] coreyfloyd: hey have a minute? [22:57:21] mhurd: yeah [22:57:46] coreyfloyd: bat cave? [22:57:51] sure