[00:32:43] niedzielski: hey are you still around? [00:33:10] Sure what's up? [00:34:28] niedzielski: oh cool! i'm stuck on something silly. i added a "test/ElementUtilities.js" file and can't seem to get it to import the "src/ElementUtilities" so i can test its methods... not sure what's going on... [00:34:51] niedzielski: i'm using "import elementUtilities from '../src/ElementUtilities'" [00:35:59] Just a moment [00:36:36] niedzielski: our collapse table and widen images tests are just importing applib via "import applib from '../build/applib'" [00:37:11] mhurd: hm, i wonder if this is an issue with the way es6 and mocha are configured [00:37:58] mhurd: is there a reason you wouldn't import applib.ElementUtilities? [00:38:01] niedzielski: should i just add a "test" entry to index.js and expose the element utilities methods that way? [00:38:27] niedzielski: oh lemme try that [00:39:01] mhurd: if i understand correctly, you were just exposing a test object of the project code. the code was still production but the access was for test only [00:39:18] if you have a pure test-only module, then that would go in test/ [00:40:34] niedzielski: ya it's production but i can't access it for testing atm [00:41:52] mhurd: if it's production, then access it through the applib build product [00:42:48] mhurd: so you'd update index.js to export ElementUtilities and then access in test via applib.ElementUtilities.test.foo [00:42:52] niedzielski: hmm applib uses it but doesn't make it public... so i would have to expose it in the index.js? [00:43:13] haha messages crossed :) [00:43:30] mhurd: could you do export it in applib as .test instead? [00:48:46] niedzielski: ya exporting it in applib as test ElementUtilites worked [00:49:00] yayyyyy [00:49:05] niedzielski: then in the test i just do "const elementUtilities = applib.test.ElementUtilities" [00:49:16] makes sense [00:49:40] niedzielski: cool thx for the help! [00:50:40] mhurd: np! i have mixed feelings about the way we test the applib build product. on one hand, we test the actual bytes shipped currently. on the other, it feels more unit-y to import the sources tested directly :/ [00:51:41] niedzielski:ha that was exactly what i was wondering about! whether to directly import into test. open to changing if it makes sense [00:54:33] mhurd: not sure which is best. maybe we can talk the web folks. one thing in paritcular that i like to have tested are that the imports off of index.js are set when adding new modules. maybe we can write an integration test that lists out src/ and tests for each appbuild.Module. idk [00:56:38] niedzielski: moar tests! :) [15:35:55] niedzielski: have localization changes stopped propagating back to twn for android? [15:36:23] joewalsh: we're still getting them. let me check when the last one was [15:37:05] joewalsh: er, yeah we got one today [15:37:22] the sync still works, but when we make a change (such as fixing a string format token) it doesn’t get updated on TWN [15:38:42] joewalsh: i've had spurious issues with that in the past. when it happens, i use the twn web interface but i don't know why it only occurs rarely [15:39:06] joewalsh: is this with nonenglish strings only? [15:39:26] niedzielski: the recent issues, yeah [15:40:15] niedzielski: unrelated question, how do you drop the [m] from your irc username when using matrix.org [15:40:37] cc amrox[m] [15:41:18] joewalsh: i think i just used irc commands to change the nick [15:41:42] joewalsh: so you have your irc bridge setup and authenticated to your handle? [15:46:53] niedzielski: i think the issue is trying to use the riot client. you have a bridge setup manually? [15:48:17] joewalsh: you're on riot.im/app? [15:49:32] niedzielski: yeah [15:49:57] joewalshnotm: ok so it's been a while but i just had to configure their bridge. just a moment [15:53:13] joewalshnotm: so you're doing `!nick joewalsh`? you have to change your IRC nick not the matrix one [15:53:30] !nick justatest [15:53:32] ah, i was doing `/nick` [15:55:07] joewalsh: er, i think you have to join a room with "ipv6.chat.freenode.net" [15:55:22] and then do that `!nick joewalsh` [15:55:59] joewalsh: in my sidebar i have a room called "IRC Admin Room" under the people section [16:20:32] niedzielski: hmm, looks like something will need to be updated either in the interceptors or error view's ErrorType logic. i'm getting HttpStatusExceptions rather than UnknownHostExceptions now when on airplane mode [16:21:44] mdholloway: i'll check it out [16:21:59] niedzielski: cool, thx [18:57:07] mdholloway: is the save page sync service running for you? [18:57:41] niedzielski: lemme check, i've been looking at other stuff for a bit [19:16:14] niedzielski: it doesn't seem to be, but i think i know what's breaking it [19:17:25] https://github.com/wikimedia/apps-android-wikipedia/blob/master/app/src/main/java/org/wikipedia/savedpages/ReadingListPageObserver.java#L39-L41 [19:18:57] mdholloway: that does look suspect [19:30:37] niedzielski: i'm getting lots of ui jank in the feed all of a sudden, too [19:31:37] everywhere, actually [19:31:41] mdholloway: you mean it's laggy? [19:31:56] yeah [19:32:36] mdholloway: i'm not seeing that but will keep my eye out [19:34:01] not seeing anything either [19:35:36] that's good, i guess! i was seeing big lags on both an emulator and my 6P [19:40:05] mdholloway: it probably doesn't matter but what language? [19:40:14] niedzielski: en [19:47:46] anyway, restarted (actually just updated to 7.1.2) and relaunched with the new patch and now everything seems fine. [21:14:17] mdholloway: still looking into that caching issue you found. it looks like the saved pages cache is working properly but the net cache is not. i've got a couple other things on my plate today so it's probably going to bleed into tonight / tomorrow [21:15:32] niedzielski: sounds good. no rush. i just won't move those tickets over yet until we have the offline handling straightened out again. [21:15:48] mdholloway: sounds good, thanks :]