[17:07:17] mdholloway: niedzielski I have a few open questions for you both on the page rendering doc - can you guys take a look at that today when you have time? [17:11:12] coreyfloyd: sure, looking now [17:31:17] coreyfloyd: will do. thanks [17:45:33] mdholloway: niedzielski: the beta release has been greenlit [17:45:38] warp speed [17:48:21] yayyyy [17:49:56] \o/ [17:58:44] mdholloway: niedzielski: i forget -- do we have the APKs built for this release? or do we still need to build them? [17:59:46] mdholloway dbrant: i think i built them this time but michael went through the normal release process including uploading to google drive? [18:00:17] niedzielski: dbrant: (pulling up the release process notes) [18:01:40] actually, i stopped at step 16 after getting blocked there [18:01:49] sorry if there was a misunderstanding there [18:14:13] mdholloway dbrant: eek! so you did you push the tags, do the testing, scp the files, update the wiki, etc or are these still pending? [18:16:49] niedzielski: i did quite a bit of alpha build testing [18:17:11] i didn't get further than that, because the problem was that i could not build the beta or prod APKs. [18:18:30] mdholloway dbrant: ok, cool. i'll go through the remaining steps. the tag in particular is really important because sometimes we cherry pick bug fixes (like last release) [18:44:49] niedzielski: thanks and sorry about the mixup. i can firm up the release notes in the meantime (i got the commits down on the etherpad back during testing) [18:46:37] mdholloway: thanks! i'm trying to figure out what's up with our device support. this release supports about a 1000 fewer devices and i'm not sure why yet. we now have two extra features for the mapbox library but they're both marked optional in our manifest. the play store interface does not make this clear but, for example, wifi hardware is no longer required mapbox and it shows up as a feature. [18:46:37] https://phabricator.wikimedia.org/diffusion/APAW/browse/master/app/src/main/AndroidManifest.xml;9a8bc889e5d2692743db64977824413ab42d06c3$35 https://github.com/mapbox/mapbox-gl-native/blob/62ea1f21858c69f6921c775ba7a3de201f0514d8/platform/android/MapboxGLAndroidSDK/src/main/AndroidManifest.xml#L5 https://developer.android.com/guide/topics/manifest/uses-feature-element.html [18:48:52] mdholloway: it looks like an implicit uses-feature from a permission but i don't see any new permissions added [19:05:22] mdholloway dbrant: this is my best guess https://gerrit.wikimedia.org/r/#/c/348787/ [19:08:31] mdholloway dbrant: i won't publish the prod alpha, the beta, or push the amazon build, but i will update bromine and the release notes [19:13:49] ok everything else is updated. we can cherry pick this change onto 192 and cut a new build [19:29:16] mdholloway: would you update the SoS etherpad? [19:29:26] bearND: yep, doing now [19:29:31] ty [19:29:50] bearND: btw, did you want me to review those mcs patches (the parsoid version upgrade and test fixtures update)? [19:33:06] mdholloway: yes, also the one patch that's marked as a spike result (a script I'd like to keep in the repo). Thanks! [19:33:25] bearND: sure thing [19:45:50] jdlrobson: are any of your projects using the formatted endpoints? [19:51:10] dbrant: niedzielski: btw, i've got some provisional release notes ready whenever you're ready to have a look [20:32:09] bearND: uh, sorry, I got distracted [20:32:27] I would have copied the same line anyway [20:32:49] tgr: ok. No worries [20:43:50] bearND: hey [20:44:00] bearND: i dont think so because they're not public yet right? [20:44:12] i'd like them too.. [20:44:51] jdlrobson: Right. It's not public yet. Just wanted to see if you used in weekipedia or similar side projects. I looked at the former, and I see only the mobile-sections endpoint used there. [20:45:29] I'm going to remove the url rewriting (T147043). Just didn't want to break you. [20:45:30] T147043: Do not rewrite urls via _rewriteUrlAttribute - https://phabricator.wikimedia.org/T147043 [21:04:36] bearND: so apparently i rewrite the rewrite of urls [21:04:51] will there be a way to know whether im getting a response which rewrites or not? [21:23:12] jdlrobson: where is the second rewrite happening? We could coordinate the deployments. [21:42:09] jdlrobson: nvm, that change would only happen for the non-legacy portion (the formatted endpoint). So, I guess there's no need to coordinate deployments. [22:37:02] mdholloway: FYI, just noticed there seems to be some progress on T39902 :) [22:37:02] T39902: RFC: Implement rendering of redlinks in Parsoid HTML as post-processor - https://phabricator.wikimedia.org/T39902 [22:37:22] bearND: i noticed that! \o/